From 0abd984285abbafff1ab4703ae16bcbe347eb962 Mon Sep 17 00:00:00 2001
From: shankar0123 <skreddy040@gmail.com>
Date: Sat, 28 Mar 2026 21:25:25 -0400
Subject: [PATCH] fix: staticcheck S1016 struct conversion + Helm with/else-if
 parse error

- Use type conversion DigestStatusCount(c) instead of struct literal
- Replace with...else-if (invalid in Go templates) with if...else-if chain
- Add *.bak and cmd/agent/*.key/*.pem to .gitignore

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 .gitignore                                           | 5 +++++
 deploy/helm/certctl/templates/server-deployment.yaml | 8 ++++----
 internal/service/digest.go                           | 5 +----
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index 99aa3d1..08a141a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -43,6 +43,11 @@ vendor/
 tmp/
 temp/
 *.log
+*.bak
+
+# Private keys (agent-generated, never commit)
+cmd/agent/*.key
+cmd/agent/*.pem
 
 # Database
 *.db
diff --git a/deploy/helm/certctl/templates/server-deployment.yaml b/deploy/helm/certctl/templates/server-deployment.yaml
index 16a9a79..7481587 100644
--- a/deploy/helm/certctl/templates/server-deployment.yaml
+++ b/deploy/helm/certctl/templates/server-deployment.yaml
@@ -181,16 +181,16 @@ spec:
         {{- if .Values.server.volumes }}
         {{- toYaml .Values.server.volumes | nindent 8 }}
         {{- end }}
-      {{- with .Values.nodeAffinity }}
+      {{- if .Values.nodeAffinity }}
       affinity:
         nodeAffinity:
-          {{- toYaml . | nindent 10 }}
+          {{- toYaml .Values.nodeAffinity | nindent 10 }}
       {{- else if .Values.podAntiAffinity }}
       affinity:
         podAntiAffinity:
-          {{- toYaml . | nindent 10 }}
+          {{- toYaml .Values.podAntiAffinity | nindent 10 }}
       {{- else if .Values.podAffinity }}
       affinity:
         podAffinity:
-          {{- toYaml . | nindent 10 }}
+          {{- toYaml .Values.podAffinity | nindent 10 }}
       {{- end }}
diff --git a/internal/service/digest.go b/internal/service/digest.go
index d98bf5c..7002101 100644
--- a/internal/service/digest.go
+++ b/internal/service/digest.go
@@ -122,10 +122,7 @@ func (s *DigestService) GenerateDigest(ctx context.Context) (*DigestData, error)
 		s.logger.Warn("failed to get status counts for digest", "error", err)
 	} else if counts, ok := statusRaw.([]CertificateStatusCount); ok {
 		for _, c := range counts {
-			digest.StatusCounts = append(digest.StatusCounts, DigestStatusCount{
-				Status: c.Status,
-				Count:  c.Count,
-			})
+			digest.StatusCounts = append(digest.StatusCounts, DigestStatusCount(c))
 		}
 	}