From 7cc3f2576f2b61d2ba4a094f514b78435e7c5992 Mon Sep 17 00:00:00 2001 From: Tanish Manku Date: Fri, 1 May 2026 22:37:54 -0700 Subject: [PATCH] Upload modals: comment why content is invoked inline --- .../app/src/components/reusable/UploadModal3D/UploadModal3D.tsx | 1 + .../components/reusable/UploadModalImage/UploadModalImage.tsx | 1 + .../reusable/UploadModalMedia/UploadImageMediaModal.tsx | 1 + .../components/reusable/UploadModalMedia/UploadModalMedia.tsx | 1 + .../components/reusable/UploadModalSplat/UploadModalSplat.tsx | 1 + 5 files changed, 5 insertions(+) diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx index feeddceb7b..fadfa5b6e7 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModal3D/UploadModal3D.tsx @@ -165,6 +165,7 @@ export function UploadModal3D(props: Props) { className="max-w-xl" showClose={true} > + {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx index 8fd43101a3..6a4bda62df 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalImage/UploadModalImage.tsx @@ -129,6 +129,7 @@ export function UploadModalImage(props: Props) { className="max-w-xl" showClose={true} > + {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx index 0e029e0cee..cfc13c6340 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadImageMediaModal.tsx @@ -113,6 +113,7 @@ export function UploadImageMediaModal({ return ( + {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx index 10009a191c..7e154cb67c 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalMedia/UploadModalMedia.tsx @@ -100,6 +100,7 @@ export function UploadModalMedia({ return ( + {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} {UploaderModalContent()} ); diff --git a/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx b/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx index dd1adb5e2a..c76d4aeb0a 100644 --- a/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx +++ b/frontend/apps/artcraft/app/src/components/reusable/UploadModalSplat/UploadModalSplat.tsx @@ -137,6 +137,7 @@ export function UploadModalSplat(props: Props) { className="max-w-xl" showClose={true} > + {/* Inline call — `` would be a fresh component reference each render and remount the subtree. */} {UploaderModalContent()} );