mirror of
https://github.com/Portabase/agent.git
synced 2026-09-10 10:08:01 +00:00
charles-gauthereau
87f33af772
helm/templates/env-configmap.yaml never listed RETRY_ATTEMPTS and RETRY_BACKOFF_MS even though values.yaml gained them, so --set env.RETRY_ATTEMPTS=N was silently ignored by Kubernetes deployments. Add both keys in the same explicit style as the existing entries. src/utils/retry.rs logged its own "failed after N attempts" error on exhaustion, on top of the terminal log each call site already writes, producing two error entries per failure. Worse, it changed a log level: FileLock::acquire's "backup_already_in_progress" bails through the combinator, which now logged it as error before runner.rs got a chance to reclassify it as the routine warn it always was. A manual backup colliding with a scheduled one would show up as a hard error on the dashboard instead of the harmless warn it used to be, breaking the "fails exactly as it does today" guarantee for job records. Drop the combinator's terminal error log and give download_backup its own terminal error log so all three call sites (runner, uploader, downloader) own their failure logging uniformly. Update the two tests that asserted the removed message to assert the new behavior instead.