mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-03 18:55:33 +00:00
goodolclint-claude[bot]
b90791e2bf
D001-D021 become ADR 0001-0021 in docs/decisions/, one decision per file. D017's PESTER_VERSION amendment was a second decision in one entry and becomes ADR 0022. ADR 0023 records the migration and reverses the lane2-change-plan ruling that deliberately kept DECISIONS.md until the CI lane work landed. DECISIONS.md is reduced to a stub with a D-to-ADR redirect table, so the four released CHANGELOG entries and older issue bodies that cite it degrade to a redirect rather than a dead reference. docs/review/ and docs/lane2-change-plan.md are deleted (ADR 0024). Of 91 findings, 83 were resolved and six of the seven still open were already GitHub issues; F021 was the exception and is now #130. CLAUDE.md's Key Conventions list gains the two rules it was missing and becomes the checklist, with the ADRs carrying rationale.
208 lines
7.8 KiB
YAML
208 lines
7.8 KiB
YAML
name: Unit Tests
|
|
|
|
# Pinned, not floored. Pester is installed fresh on every run, so a version range
|
|
# lets a new major reach the required checks with no commit to this repo (#112).
|
|
# Keep in step with PESTER_VERSION in tests/Dockerfile.test.
|
|
env:
|
|
PESTER_VERSION: 6.1.0
|
|
|
|
on:
|
|
push:
|
|
branches: [ main ]
|
|
pull_request:
|
|
branches: [ main ]
|
|
|
|
jobs:
|
|
# ── Build module artifacts (only job that needs .NET SDK) ──────────
|
|
build:
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 10
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- os: windows-latest
|
|
framework: netstandard2.0
|
|
- os: ubuntu-latest
|
|
framework: netstandard2.0
|
|
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Setup .NET
|
|
uses: actions/setup-dotnet@v6
|
|
with:
|
|
dotnet-version: '10.0.x'
|
|
|
|
- name: Build module
|
|
run: dotnet publish src/PSProxmoxVE/PSProxmoxVE.csproj --configuration Release --framework ${{ matrix.framework }} --output ./publish/${{ matrix.framework }}
|
|
|
|
- name: Clean publish output for PS module loading
|
|
shell: bash
|
|
run: rm -f ./publish/${{ matrix.framework }}/*.deps.json ./publish/${{ matrix.framework }}/*.runtimeconfig.json
|
|
|
|
- name: Upload module artifact
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: module-${{ matrix.framework }}-${{ matrix.os }}
|
|
path: ./publish/${{ matrix.framework }}/
|
|
|
|
# ── Pester tests (no .NET SDK — just PowerShell + Pester) ─────────
|
|
pester-tests:
|
|
needs: build
|
|
timeout-minutes: 15
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- os: windows-latest
|
|
ps_version: '5.1'
|
|
framework: netstandard2.0
|
|
artifact_os: windows-latest
|
|
shell: powershell
|
|
- os: windows-latest
|
|
ps_version: '7.5'
|
|
framework: netstandard2.0
|
|
artifact_os: windows-latest
|
|
shell: pwsh
|
|
- os: ubuntu-latest
|
|
ps_version: '7.5'
|
|
framework: netstandard2.0
|
|
artifact_os: ubuntu-latest
|
|
shell: pwsh
|
|
- os: macos-latest
|
|
ps_version: '7.5'
|
|
framework: netstandard2.0
|
|
artifact_os: ubuntu-latest
|
|
shell: pwsh
|
|
|
|
runs-on: ${{ matrix.os }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
|
|
- name: Download module artifact
|
|
uses: actions/download-artifact@v8
|
|
with:
|
|
name: module-${{ matrix.framework }}-${{ matrix.artifact_os }}
|
|
path: ./publish/${{ matrix.framework }}/
|
|
|
|
# -RequiredVersion accepts an empty value and degrades to "latest" with
|
|
# exit 0, so an unset variable would silently restore the float this pin
|
|
# removes. Fail the job instead.
|
|
- name: Verify PESTER_VERSION is set
|
|
shell: pwsh
|
|
run: |
|
|
if ([string]::IsNullOrWhiteSpace($env:PESTER_VERSION)) { throw 'PESTER_VERSION is not set' }
|
|
"Pinning Pester to $env:PESTER_VERSION"
|
|
|
|
- name: Install Pester (PS 5.1)
|
|
if: matrix.ps_version == '5.1'
|
|
shell: powershell
|
|
run: |
|
|
Install-Module -Name Pester -RequiredVersion $env:PESTER_VERSION -Force -Scope CurrentUser -SkipPublisherCheck
|
|
|
|
- name: Install Pester (PS 7.x)
|
|
if: matrix.ps_version != '5.1'
|
|
shell: pwsh
|
|
run: |
|
|
Install-Module -Name Pester -RequiredVersion $env:PESTER_VERSION -Force -Scope CurrentUser
|
|
|
|
- name: Copy module to module path (PS 5.1)
|
|
if: matrix.ps_version == '5.1'
|
|
shell: powershell
|
|
run: |
|
|
$modulePath = "$env:USERPROFILE\Documents\WindowsPowerShell\Modules\PSProxmoxVE"
|
|
New-Item -ItemType Directory -Path $modulePath -Force | Out-Null
|
|
Copy-Item -Path .\publish\${{ matrix.framework }}\* -Destination $modulePath -Recurse -Force
|
|
|
|
- name: Copy module to module path (PS 7.x, Windows)
|
|
if: matrix.ps_version != '5.1' && matrix.os == 'windows-latest'
|
|
shell: pwsh
|
|
run: |
|
|
$modulePath = "$env:USERPROFILE\Documents\PowerShell\Modules\PSProxmoxVE"
|
|
New-Item -ItemType Directory -Path $modulePath -Force | Out-Null
|
|
Copy-Item -Path .\publish\${{ matrix.framework }}\* -Destination $modulePath -Recurse -Force
|
|
|
|
- name: Copy module to module path (PS 7.x, non-Windows)
|
|
if: matrix.ps_version != '5.1' && matrix.os != 'windows-latest'
|
|
shell: pwsh
|
|
run: |
|
|
$modulePath = "$HOME/.local/share/powershell/Modules/PSProxmoxVE"
|
|
New-Item -ItemType Directory -Path $modulePath -Force | Out-Null
|
|
Copy-Item -Path ./publish/${{ matrix.framework }}/* -Destination $modulePath -Recurse -Force
|
|
|
|
- name: Run Pester tests (PS 5.1)
|
|
if: matrix.ps_version == '5.1'
|
|
shell: powershell
|
|
run: |
|
|
Import-Module Pester -RequiredVersion $env:PESTER_VERSION
|
|
$config = New-PesterConfiguration
|
|
$config.Run.Path = "tests/PSProxmoxVE.Tests"
|
|
$config.Run.Exit = $true
|
|
$config.Filter.ExcludeTag = @("Integration")
|
|
$config.Output.Verbosity = "Detailed"
|
|
$config.TestResult.Enabled = $true
|
|
$config.TestResult.OutputFormat = "NUnitXml"
|
|
$config.TestResult.OutputPath = "TestResults/pester-results.xml"
|
|
Invoke-Pester -Configuration $config
|
|
|
|
- name: Run Pester tests (PS 7.x)
|
|
if: matrix.ps_version != '5.1'
|
|
shell: pwsh
|
|
run: |
|
|
Import-Module Pester -RequiredVersion $env:PESTER_VERSION
|
|
$config = New-PesterConfiguration
|
|
$config.Run.Path = "tests/PSProxmoxVE.Tests"
|
|
$config.Run.Exit = $true
|
|
$config.Filter.ExcludeTag = @("Integration")
|
|
$config.Output.Verbosity = "Detailed"
|
|
$config.TestResult.Enabled = $true
|
|
$config.TestResult.OutputFormat = "NUnitXml"
|
|
$config.TestResult.OutputPath = "TestResults/pester-results.xml"
|
|
Invoke-Pester -Configuration $config
|
|
|
|
- name: Upload test results
|
|
if: always()
|
|
uses: actions/upload-artifact@v7
|
|
with:
|
|
name: pester-results-${{ matrix.os }}-ps${{ matrix.ps_version }}
|
|
path: TestResults/
|
|
|
|
# ── CI infrastructure shell self-checks ─────────────────────────────
|
|
# These guard the provisioning and reporting scripts, whose real exercise is
|
|
# a ~45-minute nested-PVE run. They stub ssh/gh/git and finish in seconds, so
|
|
# a regression in them is caught on the PR rather than a week later.
|
|
shell-selfchecks:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 5
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: prepare-test-environment self-check
|
|
run: bash tests/infrastructure/scripts/prepare-test-environment.test.sh
|
|
|
|
- name: report-package-currency self-check
|
|
run: bash tests/infrastructure/scripts/report-package-currency.test.sh
|
|
|
|
- name: preflight-cleanup self-check
|
|
run: bash tests/infrastructure/scripts/preflight-cleanup.test.sh
|
|
|
|
# The pin lives in two files; split-brain is exactly the unexplained
|
|
# breakage ADR 0022 exists to prevent, so assert they agree.
|
|
- name: Pester pin agrees across workflow and image
|
|
run: |
|
|
wf=$(sed -n 's/^ PESTER_VERSION: *//p' .github/workflows/unit-tests.yml)
|
|
img=$(sed -n 's/^ARG PESTER_VERSION=//p' tests/Dockerfile.test)
|
|
echo "workflow=$wf image=$img"
|
|
[ -n "$wf" ] && [ -n "$img" ] || { echo "could not read one of the pins" >&2; exit 1; }
|
|
[ "$wf" = "$img" ] || { echo "PESTER_VERSION differs: workflow=$wf image=$img" >&2; exit 1; }
|
|
|
|
- name: Shell syntax check
|
|
run: |
|
|
for f in tests/infrastructure/scripts/*.sh; do
|
|
bash -n "$f" || exit 1
|
|
done
|