mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-06 03:59:04 +00:00
goodolclint-claude[bot]
9a92577794
WaitForStatusTransition and InvokeGuestTask lived on PveCmdletBase with hard-coded qemu/lxc paths, a Thread.Sleep(2000) loop and their own PveHttpClient, so ADR 0015's lock-clear wait and ADR 0020's flock retry could only be exercised through the 45-minute integration lane. Moves both into a new GuestLifecycleService on PveServiceBase, following TaskService's shape: a parameterless ctor, an IPveHttpClient-injecting ctor, and an internal ctor with a Func<TimeSpan, Task> pollDelay seam so a test can drive the poll loop without sleeping. PveCmdletBase keeps the same protected method signatures as thin forwarders wiring WriteVerbose into a single Action<string>? onProgress callback, so none of the 14 cmdlet call sites change. ParseLinks moves to a pure CorosyncLinks.Parse in Core (dictionary plus the malformed entries), with PveCmdletBase.ParseLinks kept as a forwarder that emits the WriteWarning — the same forwarder shape as the lifecycle methods, so the warning stays in one place instead of being copied into the three cluster cmdlets that call it. Behaviour is unchanged: same status/current polling per guest type, same GuestStatusSnapshot.Evaluate lock semantics, same filtered PveApiException catch, same GuestLockRetry wrapping, same PveTaskTimeoutException. Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>