mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-08-11 06:46:53 +00:00
Clint Branham
dc9b253195
Cmdlet fixes:
- GetPveSnapshotCmdlet: add -Name filter; fix s.SnapName → s.Name
- GetPveStorageCmdlet: add -Storage name filter
- GetPveNetworkCmdlet: add -Iface optional filter
- NewPveNetworkCmdlet: rename Interface → Iface (consistency with Set/Remove)
- SetPveNetworkCmdlet, RemovePveNetworkCmdlet: rename Interface → Iface
- RemovePveNetworkCmdlet, RemovePveSdnZoneCmdlet, RemovePveSdnVnetCmdlet,
RemovePveUserCmdlet: add ConfirmImpact = ConfirmImpact.High
- SetPveCloudInitConfigCmdlet: rename User → CiUser; move GetSession() first;
remove duplicate session variable
- SendPveIsoCmdlet: add sha512 to ChecksumAlgorithm ValidateSet
- GetPveUserCmdlet: add -Enabled switch; refactor into MatchesFilters(); fix
int? comparison (Enabled != 1)
- GetPvePermissionCmdlet: rename UgId → UserId
- SetPvePermissionCmdlet: rename RoleId → Role
- NewPveTemplateCmdlet: add ConfirmImpact.High; move GetSession() before
ShouldProcess so -WhatIf-less calls throw session error first
- NewPveVmFromTemplateCmdlet: rename Node → TemplateNode with [Alias("Node")]
- RemovePveSnapshotCmdlet, RestorePveSnapshotCmdlet: move GetSession() before
ShouldProcess so session check precedes confirm prompt
Test fixes:
- All 18 Pester test files: update DLL candidates to net9.0
- Fix foreach+It closure capture using -TestCases pattern
- Remove-PveVm, Remove-PveContainer no-session tests: add -Confirm:$false to
bypass ConfirmImpact.High prompt before GetSession() check
- Get-PveStorageContent test: add mandatory -Node/-Storage params
- Send-PveIso test: create temp file to satisfy FileExistsValidation
- New-PveVmFromTemplate test: add NewVmId to parameter splat
Tooling:
- Invoke-Tests.ps1: add -FromTerraform, explicit lab params, fix TFM
auto-detection via Select-Xml, fix Pester import, fix variable scoping
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
314 lines
11 KiB
PowerShell
314 lines
11 KiB
PowerShell
#Requires -Module Pester
|
|
<#
|
|
.SYNOPSIS
|
|
Pester 5 tests for container lifecycle cmdlets:
|
|
New-PveContainer, Remove-PveContainer,
|
|
Start-PveContainer, Stop-PveContainer, Restart-PveContainer.
|
|
|
|
All tests are fully offline — no live Proxmox VE target is required.
|
|
If a cmdlet is not yet compiled into the DLL the test is marked Skipped.
|
|
#>
|
|
|
|
BeforeAll {
|
|
$moduleRoot = Resolve-Path (Join-Path $PSScriptRoot '../../../src/PSProxmoxVE')
|
|
$dllCandidates = @(
|
|
Join-Path $moduleRoot 'bin/Debug/net9.0/PSProxmoxVE.dll'
|
|
Join-Path $moduleRoot 'bin/Release/net9.0/PSProxmoxVE.dll'
|
|
Join-Path $moduleRoot 'bin/Debug/net48/PSProxmoxVE.dll'
|
|
Join-Path $moduleRoot 'bin/Release/net48/PSProxmoxVE.dll'
|
|
)
|
|
|
|
$script:ModuleDll = $dllCandidates | Where-Object { Test-Path $_ } | Select-Object -First 1
|
|
|
|
if ($null -eq $script:ModuleDll) {
|
|
throw "PSProxmoxVE.dll not found. Build the project before running Pester tests."
|
|
}
|
|
|
|
Import-Module $script:ModuleDll -Force -ErrorAction Stop
|
|
|
|
# Pre-calculate availability for each cmdlet.
|
|
$script:Availability = @{}
|
|
foreach ($name in @('New-PveContainer', 'Remove-PveContainer',
|
|
'Start-PveContainer', 'Stop-PveContainer',
|
|
'Restart-PveContainer',
|
|
'Get-PveContainerConfig', 'Set-PveContainerConfig',
|
|
'Copy-PveContainer')) {
|
|
$script:Availability[$name] = $null -ne (Get-Command $name -ErrorAction SilentlyContinue)
|
|
}
|
|
|
|
function Skip-IfMissing([string]$Name) {
|
|
if (-not $script:Availability[$Name]) {
|
|
Set-ItResult -Skipped -Because "$Name is not yet implemented in this build"
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# New-PveContainer
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'New-PveContainer' {
|
|
|
|
BeforeAll { $script:Cmd = Get-Command 'New-PveContainer' -ErrorAction SilentlyContinue }
|
|
|
|
Context 'Command existence' {
|
|
It 'Should be available after module import' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
$script:Cmd | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'ShouldProcess support' {
|
|
It 'Should support WhatIf' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Required parameters' {
|
|
It 'Node should be Mandatory' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should throw when Node is omitted' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
{ New-PveContainer -ErrorAction Stop } | Should -Throw
|
|
}
|
|
}
|
|
|
|
Context 'Optional parameters' {
|
|
It 'Should have Wait switch parameter' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should have Session parameter' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('Session') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active (without -WhatIf)' {
|
|
Skip-IfMissing 'New-PveContainer'
|
|
{ New-PveContainer -Node 'pve-node1' -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Remove-PveContainer
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Remove-PveContainer' {
|
|
|
|
BeforeAll { $script:Cmd = Get-Command 'Remove-PveContainer' -ErrorAction SilentlyContinue }
|
|
|
|
Context 'Command existence' {
|
|
It 'Should be available after module import' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$script:Cmd | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'ShouldProcess / ConfirmImpact' {
|
|
It 'Should support WhatIf' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should declare ConfirmImpact High' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$attr = $script:Cmd.ImplementingType.GetCustomAttributes(
|
|
[System.Management.Automation.CmdletAttribute], $false) |
|
|
Select-Object -First 1
|
|
$attr.ConfirmImpact | Should -Be ([System.Management.Automation.ConfirmImpact]::High)
|
|
}
|
|
}
|
|
|
|
Context 'Required parameters' {
|
|
It 'Node should be Mandatory' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'VmId should be Mandatory' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['VmId'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'Optional parameters' {
|
|
It 'Should have Purge switch parameter' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('Purge') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should have Wait switch parameter' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active (without -WhatIf)' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
{ Remove-PveContainer -Node 'pve-node1' -VmId 200 -Confirm:$false -ErrorAction Stop } | Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
|
|
It 'Should not throw with -WhatIf' {
|
|
Skip-IfMissing 'Remove-PveContainer'
|
|
{ Remove-PveContainer -Node 'pve-node1' -VmId 200 -WhatIf -ErrorAction Stop } |
|
|
Should -Not -Throw
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Start-PveContainer
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Start-PveContainer' {
|
|
|
|
BeforeAll { $script:Cmd = Get-Command 'Start-PveContainer' -ErrorAction SilentlyContinue }
|
|
|
|
Context 'Command existence' {
|
|
It 'Should be available after module import' {
|
|
Skip-IfMissing 'Start-PveContainer'
|
|
$script:Cmd | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'Parameter metadata' {
|
|
It 'Node should be Mandatory' {
|
|
Skip-IfMissing 'Start-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'VmId should be Mandatory' {
|
|
Skip-IfMissing 'Start-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['VmId'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should have Wait switch parameter' {
|
|
Skip-IfMissing 'Start-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should support ShouldProcess' {
|
|
Skip-IfMissing 'Start-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
Skip-IfMissing 'Start-PveContainer'
|
|
{ Start-PveContainer -Node 'pve-node1' -VmId 200 -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Stop-PveContainer
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Stop-PveContainer' {
|
|
|
|
BeforeAll { $script:Cmd = Get-Command 'Stop-PveContainer' -ErrorAction SilentlyContinue }
|
|
|
|
Context 'Command existence' {
|
|
It 'Should be available after module import' {
|
|
Skip-IfMissing 'Stop-PveContainer'
|
|
$script:Cmd | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'Parameter metadata' {
|
|
It 'Node should be Mandatory' {
|
|
Skip-IfMissing 'Stop-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'VmId should be Mandatory' {
|
|
Skip-IfMissing 'Stop-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['VmId'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should have Wait switch parameter' {
|
|
Skip-IfMissing 'Stop-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should support ShouldProcess' {
|
|
Skip-IfMissing 'Stop-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
Skip-IfMissing 'Stop-PveContainer'
|
|
{ Stop-PveContainer -Node 'pve-node1' -VmId 200 -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Restart-PveContainer
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Restart-PveContainer' {
|
|
|
|
BeforeAll { $script:Cmd = Get-Command 'Restart-PveContainer' -ErrorAction SilentlyContinue }
|
|
|
|
Context 'Command existence' {
|
|
It 'Should be available after module import' {
|
|
Skip-IfMissing 'Restart-PveContainer'
|
|
$script:Cmd | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'Parameter metadata' {
|
|
It 'Node should be Mandatory' {
|
|
Skip-IfMissing 'Restart-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'VmId should be Mandatory' {
|
|
Skip-IfMissing 'Restart-PveContainer'
|
|
$isMandatory = $script:Cmd.Parameters['VmId'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should support ShouldProcess' {
|
|
Skip-IfMissing 'Restart-PveContainer'
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
Skip-IfMissing 'Restart-PveContainer'
|
|
{ Restart-PveContainer -Node 'pve-node1' -VmId 200 -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|