mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-03 18:55:33 +00:00
goodolclint-claude[bot]
8255e506a6
* fix: recognize boolean and varied integer formats for guest exec exited status The guest-agent schema declares 'exited' as a boolean, but the PVE API may return it in different formats: as a JSON boolean true, or as integers 1/0, or string '1'/'0'. The cmdlet was only checking for long 1L, causing it to timeout on any PVE build that passed a boolean true unchanged. Add ApiValueHelper.IsExited() to normalize these values and recognize true, 1L, 1, and '1' as exited. Update the polling loop to use it. * test: add integration tests for ApiValueHelper with real JSON payloads Add tests that feed JSON data through the actual JsonHelper.ToNative parsing pipeline to verify ApiValueHelper.IsExited correctly recognizes boolean true and numeric 1 values as they arrive from the PVE API. These tests pin the contract between the JSON parsing layer and the value-recognition logic, ensuring the fix for issue #141 works end-to-end with real API response shapes. * fix: restore correct IsExited implementation with type checks The helper must handle boolean true, long/int 1, and string "1" as the issue specifies. This restores the correct multi-type check that was inadvertently reverted. * fix: correct boolean value handling in IsExited --------- Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>