goodolclint-claude[bot] 1f1c414632 refactor: one firewall scope validator instead of 18 copies (#204) ...

Collapses the ~24-line Level/Node/VmId/Group validation block duplicated
across 18 Firewall cmdlets into a single FirewallScope.TryValidate helper
in PSProxmoxVE.Core, beside FirewallService.BuildBasePath which already
owns the level-to-path mapping (ADR 0021: request-payload/validation
correctness is proven offline, not against a live cluster).

Each cmdlet now makes one TryValidate call and, on failure, one
ThrowTerminatingError with the same ErrorId (NodeRequired/VmIdRequired/
GroupRequired), ErrorCategory.InvalidArgument, target object (null) and
message text it used before, so the Pester assertions under
tests/PSProxmoxVE.Tests/Firewall/ keep passing unedited.

Part of #154.

Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>

2026-09-03 00:44:03 +00:00

..

infrastructure

fix: verify checksums for downloaded ISOs/images, keep sshpass off argv (#166)

2026-09-02 17:20:36 +00:00

PSProxmoxVE.Core.Tests

refactor: one firewall scope validator instead of 18 copies (#204)

2026-09-03 00:44:03 +00:00

PSProxmoxVE.Tests

refactor: wire Group level onto the firewall rule cmdlets (#126) (#202)

2026-09-03 00:14:47 +00:00

.env.test.example

chore: repair the local dev path and delete its dead scaffolding

2026-09-01 16:27:10 -05:00

docker-compose.test.yml

chore: repair the local dev path and delete its dead scaffolding

2026-09-01 16:27:10 -05:00

Dockerfile.test

docs: migrate DECISIONS.md to house-format ADRs, and retire the review folder (#131)

2026-09-02 14:49:07 +00:00