mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-04 03:05:32 +00:00
goodolclint-claude[bot]
2dff02f2bd
PveNetwork already deserialised bridge_vlan_aware as BridgeVlanAware, so a VLAN-aware bridge could be read back but never created or changed. Both write paths now take a -BridgeVlanAware switch. Clearing the flag does not use bridge_vlan_aware=0. PVE merges the supplied keys onto the stored stanza and accepts that 0 without acting on it, so the obvious form is a silent no-op: an integration run against PVE 9 issued it and Get-PveNetwork still reported 1. The endpoint's delete list is what actually removes the key. The API schema advertises a plain boolean and gives no hint of this, which is why the behaviour is pinned by an integration test rather than inferred. Set-PveNetwork guards the switch on BoundParameters so an update that omits it leaves the flag alone; the create path follows the existing -Autostart form. Only bridge_vlan_aware is added. bridge_vids is an independent parameter that PVE defaults to 2-4094, and the issue asks only for the flag. Coverage: the integration suite pins create, disable, re-enable, and that an unrelated Set leaves the flag alone -- that last one kills a mutant that drops the BoundParameters guard, which every other test survives. A model test pins the read path the assertions depend on. The Pester unit tests assert only parameter metadata; the defect is server-side, so nothing offline can catch it. Closes #92
131 lines
4.1 KiB
PowerShell
131 lines
4.1 KiB
PowerShell
#Requires -Module Pester
|
|
|
|
BeforeAll {
|
|
. $PSScriptRoot/_IntegrationHelper.ps1
|
|
Connect-TestPve
|
|
|
|
function Get-PveBridge99 {
|
|
$bridge = Get-PveNetwork -Node $script:Node |
|
|
Where-Object { $_.Iface -eq 'vmbr99' }
|
|
$bridge | Should -Not -BeNullOrEmpty
|
|
$bridge
|
|
}
|
|
}
|
|
|
|
AfterAll {
|
|
if (-not $script:SkipReason) {
|
|
# Clean up pester network bridge if it still exists
|
|
try { Remove-PveNetwork -Node $script:Node -Iface 'vmbr99' -Confirm:$false -ErrorAction SilentlyContinue } catch { }
|
|
try { Invoke-PveNetworkApply -Node $script:Node -Wait -ErrorAction SilentlyContinue } catch { }
|
|
}
|
|
Disconnect-TestPve
|
|
}
|
|
|
|
Describe 'Network — Integration' -Tag 'Integration' {
|
|
Context 'Network — Read' {
|
|
It 'Should list networks' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
$networks = Get-PveNetwork -Node $script:Node
|
|
$networks | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should filter by interface type' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
# Filter for bridges — every PVE node has at least vmbr0
|
|
$bridges = Get-PveNetwork -Node $script:Node -Type 'bridge'
|
|
$bridges | Should -Not -BeNullOrEmpty
|
|
$bridges | ForEach-Object { $_.Type | Should -Be 'bridge' }
|
|
}
|
|
}
|
|
|
|
Context 'Network — CRUD' {
|
|
It 'Should create a Linux bridge' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
{ New-PveNetwork `
|
|
-Node $script:Node `
|
|
-Iface 'vmbr99' `
|
|
-Type 'bridge' `
|
|
-Autostart `
|
|
-BridgeVlanAware `
|
|
-ErrorAction Stop } | Should -Not -Throw
|
|
}
|
|
|
|
It 'Should find the new bridge in pending changes' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
$networks = Get-PveNetwork -Node $script:Node
|
|
$networks | Where-Object { $_.Iface -eq 'vmbr99' } |
|
|
Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should report the new bridge as VLAN aware' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
$bridge = Get-PveBridge99
|
|
$bridge.BridgeVlanAware | Should -Be 1
|
|
}
|
|
|
|
It 'Should disable VLAN awareness via Set-PveNetwork' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
(Get-PveBridge99).BridgeVlanAware | Should -Be 1
|
|
|
|
Set-PveNetwork -Node $script:Node -Iface 'vmbr99' -Type 'bridge' `
|
|
-BridgeVlanAware:$false -ErrorAction Stop
|
|
|
|
(Get-PveBridge99).BridgeVlanAware | Should -BeIn @($null, 0)
|
|
}
|
|
|
|
It 'Should re-enable VLAN awareness via Set-PveNetwork' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
(Get-PveBridge99).BridgeVlanAware | Should -BeIn @($null, 0)
|
|
|
|
Set-PveNetwork -Node $script:Node -Iface 'vmbr99' -Type 'bridge' `
|
|
-BridgeVlanAware -ErrorAction Stop
|
|
|
|
(Get-PveBridge99).BridgeVlanAware | Should -Be 1
|
|
}
|
|
|
|
It 'Should update bridge comments' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
{ Set-PveNetwork `
|
|
-Node $script:Node `
|
|
-Iface 'vmbr99' `
|
|
-Type 'bridge' `
|
|
-Comments 'Created by Pester integration test' `
|
|
-ErrorAction Stop } | Should -Not -Throw
|
|
}
|
|
|
|
It 'Should leave VLAN awareness alone when the switch is not passed' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
(Get-PveBridge99).BridgeVlanAware | Should -Be 1
|
|
}
|
|
|
|
It 'Should remove the bridge' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
{ Remove-PveNetwork `
|
|
-Node $script:Node `
|
|
-Iface 'vmbr99' `
|
|
-Confirm:$false `
|
|
-ErrorAction Stop } | Should -Not -Throw
|
|
}
|
|
|
|
It 'Should revert pending changes (apply to baseline)' {
|
|
if (Skip-IfNoTarget) { return }
|
|
|
|
# Apply reverts any pending changes back to the running config
|
|
{ Invoke-PveNetworkApply `
|
|
-Node $script:Node `
|
|
-Wait `
|
|
-ErrorAction Stop } | Should -Not -Throw
|
|
}
|
|
}
|
|
}
|