mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-04 03:05:32 +00:00
goodolclint-claude[bot]
09a2384cd6
* docs: record the branch protection that is actually configured CLAUDE.md has claimed since March that main had 'required build checks, required review, admin enforced'. Two of those three were wrong: direct pushes to main were still permitted until 2026-09-02, and admin bypass is now deliberately available rather than enforced. Records what is actually set: required checks, required PR with an approving review, stale reviews dismissed on push, and review from Code Owners required. Explains the narrow CODEOWNERS, so a future session knows why a workflow or ADR change needs the operator while ordinary work does not. Admin bypass is available on purpose. GitHub does not let an author approve their own PR, so without it an operator-authored governance change would deadlock. It is not a hole here: App installations do not get admin bypass, so it does nothing for a compromised or injected bot. ADR 0025 previously said enabling code-owner review was the operator's action and not done by that decision. It has been done, so the dismissal gate is now defence-in-depth rather than the load-bearing control - GitHub enforces the property directly, including against approvals from claude.yml, the ungated path the gate cannot see. * docs: trim a clause ADR 0025 stated twice in four lines Review nit on #133. The 'claude.yml is an ungated second path the dismissal step cannot see' clause appeared in consecutive paragraphs. The first states it; the second now refers back rather than restating. --------- Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>