Files
PSProxmoxVE/tests/PSProxmoxVE.Tests/Tasks/TaskCmdlets.Tests.ps1
T
goodolclint-claude[bot] 109dca657a refactor: make the offline Pester suite able to fail (#153) (#205)
Skip-IfMissing skipped a test whenever the cmdlet under test was absent
from the build, including the test asserting it exists. Every cmdlet
compiles into one assembly, so there is no partial-build case for it to
serve; all it did was hide a missing cmdlet. Delete the 37 copies and
every call site, and drop the residual conditional skips in the same
family (CmdExists probes, an attribute-presence skip in SdnCmdlets, a
lifecycle helper skipping on a cmdlet-name collision fixed long ago).

894 It blocks only reflected [Cmdlet] and [Parameter] attributes back at
the compiler: existence, CommandType -eq 'Cmdlet', Parameters.ContainsKey,
IsMandatory reflection, and per-file CmdletsToExport asserts for whichever
names an author remembered. Nothing reflected over the built assembly, so
a new cmdlet missing from the manifest shipped invisible. One data-driven
file replaces them: it diffs CmdletsToExport against the assembly's cmdlet
types in both directions and asserts the conventions reflection can see.

Behavioural tests are untouched: no-session errors, binding rejections,
ShouldProcess and -WhatIf, ConfirmImpact, ValidateSet and ValidateRange
values, parameter types, positions and pipeline binding.

The generated help covered 169 of 194 cmdlets. Regenerated with the repo's
own generate-help.ps1: 25 new markdown stubs, 13 existing docs picking up
parameters added in earlier waves, and a rebuilt MAML.

Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
2026-09-03 00:54:02 +00:00

184 lines
6.9 KiB
PowerShell

#Requires -Module Pester
<#
.SYNOPSIS
Pester 5 tests for Get-PveTask and Wait-PveTask.
All tests are fully offline — no live Proxmox VE target is required.
#>
BeforeAll {
. $PSScriptRoot/../_TestHelper.ps1
}
# ---------------------------------------------------------------------------
# Get-PveTask
# ---------------------------------------------------------------------------
Describe 'Get-PveTask' {
Context 'Parameter validation' {
BeforeAll {
$script:Cmd = Get-Command 'Get-PveTask'
}
It 'Node should be at Position 0' {
$p = $script:Cmd.Parameters['Node']
$pos = $p.ParameterSets.Values | ForEach-Object { $_.Position }
$pos | Should -Contain 0
}
It 'Node should be of type String' {
$script:Cmd.Parameters['Node'].ParameterType | Should -Be ([string])
}
It 'Upid should be at Position 1' {
$p = $script:Cmd.Parameters['Upid']
$pos = $p.ParameterSets.Values | ForEach-Object { $_.Position }
$pos | Should -Contain 1
}
It 'Upid should be of type String' {
$script:Cmd.Parameters['Upid'].ParameterType | Should -Be ([string])
}
It 'Upid should accept pipeline input by property name' {
$p = $script:Cmd.Parameters['Upid']
$acceptsByPropName = $p.ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
It 'Should declare PveTask as OutputType' {
$outputTypes = $script:Cmd.OutputType.Type
$outputTypes.Name | Should -Contain 'PveTask'
}
It 'Both Node and Upid should be required together' {
$mandatoryParams = @('Node', 'Upid')
foreach ($paramName in $mandatoryParams) {
$p = $script:Cmd.Parameters[$paramName]
$isMandatory = $p.ParameterSets.Values | Where-Object { $_.IsMandatory }
$isMandatory | Should -Not -BeNullOrEmpty -Because "$paramName should be mandatory"
}
}
}
Context 'Without active session' {
It 'Should throw when no session is active and no -Session is supplied' {
{ Get-PveTask -Node 'pve1' -Upid 'UPID:pve1:00001234:0A1B2C3D:12345678:qmcreate:100:user@pam:' -ErrorAction Stop } |
Should -Throw '*No active Proxmox VE session*'
}
It 'Should throw PveNotConnectedException type' {
try {
Get-PveTask -Node 'pve1' -Upid 'UPID:pve1:00001234:0A1B2C3D:12345678:qmcreate:100:user@pam:' -ErrorAction Stop
}
catch {
$_.Exception.GetType().Name | Should -Match 'PveNotConnectedException|CmdletInvocationException'
}
}
It 'Should require the Node parameter' {
{ Get-PveTask -Upid 'UPID:pve1:00001234:0A1B2C3D:12345678:qmcreate:100:user@pam:' -ErrorAction Stop } |
Should -Throw '*Node*'
}
It 'Should require the Upid parameter' {
{ Get-PveTask -Node 'pve1' -ErrorAction Stop } |
Should -Throw '*Upid*'
}
}
}
# ---------------------------------------------------------------------------
# Wait-PveTask
# ---------------------------------------------------------------------------
Describe 'Wait-PveTask' {
Context 'Parameter validation' {
BeforeAll {
$script:Cmd = Get-Command 'Wait-PveTask'
}
It 'Node should be at Position 0' {
$p = $script:Cmd.Parameters['Node']
$pos = $p.ParameterSets.Values | ForEach-Object { $_.Position }
$pos | Should -Contain 0
}
It 'Node should be of type String' {
$script:Cmd.Parameters['Node'].ParameterType | Should -Be ([string])
}
It 'Upid should be at Position 1' {
$p = $script:Cmd.Parameters['Upid']
$pos = $p.ParameterSets.Values | ForEach-Object { $_.Position }
$pos | Should -Contain 1
}
It 'Upid should be of type String' {
$script:Cmd.Parameters['Upid'].ParameterType | Should -Be ([string])
}
It 'Upid should accept pipeline input by property name' {
$p = $script:Cmd.Parameters['Upid']
$acceptsByPropName = $p.ParameterSets.Values |
Where-Object { $_.ValueFromPipelineByPropertyName }
$acceptsByPropName | Should -Not -BeNullOrEmpty
}
It 'Timeout should be of type Nullable[TimeSpan]' {
$script:Cmd.Parameters['Timeout'].ParameterType |
Should -Be ([System.Nullable[System.TimeSpan]])
}
It 'PollInterval should be of type Nullable[TimeSpan]' {
$script:Cmd.Parameters['PollInterval'].ParameterType |
Should -Be ([System.Nullable[System.TimeSpan]])
}
It 'Should declare PveTask as OutputType' {
$outputTypes = $script:Cmd.OutputType.Type
$outputTypes.Name | Should -Contain 'PveTask'
}
It 'Both Node and Upid should be required, Timeout and PollInterval optional' {
$mandatoryParams = @('Node', 'Upid')
foreach ($paramName in $mandatoryParams) {
$p = $script:Cmd.Parameters[$paramName]
$isMandatory = $p.ParameterSets.Values | Where-Object { $_.IsMandatory }
$isMandatory | Should -Not -BeNullOrEmpty -Because "$paramName should be mandatory"
}
$optionalParams = @('Timeout', 'PollInterval', 'Session')
foreach ($paramName in $optionalParams) {
$p = $script:Cmd.Parameters[$paramName]
$isMandatory = $p.ParameterSets.Values | Where-Object { $_.IsMandatory }
$isMandatory | Should -BeNullOrEmpty -Because "$paramName should be optional"
}
}
}
Context 'Without active session' {
It 'Should throw when no session is active and no -Session is supplied' {
{ Wait-PveTask -Node 'pve1' -Upid 'UPID:pve1:00001234:0A1B2C3D:12345678:qmcreate:100:user@pam:' -ErrorAction Stop } |
Should -Throw '*No active Proxmox VE session*'
}
It 'Should throw PveNotConnectedException type' {
try {
Wait-PveTask -Node 'pve1' -Upid 'UPID:pve1:00001234:0A1B2C3D:12345678:qmcreate:100:user@pam:' -ErrorAction Stop
}
catch {
$_.Exception.GetType().Name | Should -Match 'PveNotConnectedException|CmdletInvocationException'
}
}
It 'Should require the Node parameter' {
{ Wait-PveTask -Upid 'UPID:pve1:00001234:0A1B2C3D:12345678:qmcreate:100:user@pam:' -ErrorAction Stop } |
Should -Throw '*Node*'
}
It 'Should require the Upid parameter' {
{ Wait-PveTask -Node 'pve1' -ErrorAction Stop } |
Should -Throw '*Upid*'
}
}
}