mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-04 03:05:32 +00:00
goodolclint-claude[bot]
109dca657a
Skip-IfMissing skipped a test whenever the cmdlet under test was absent from the build, including the test asserting it exists. Every cmdlet compiles into one assembly, so there is no partial-build case for it to serve; all it did was hide a missing cmdlet. Delete the 37 copies and every call site, and drop the residual conditional skips in the same family (CmdExists probes, an attribute-presence skip in SdnCmdlets, a lifecycle helper skipping on a cmdlet-name collision fixed long ago). 894 It blocks only reflected [Cmdlet] and [Parameter] attributes back at the compiler: existence, CommandType -eq 'Cmdlet', Parameters.ContainsKey, IsMandatory reflection, and per-file CmdletsToExport asserts for whichever names an author remembered. Nothing reflected over the built assembly, so a new cmdlet missing from the manifest shipped invisible. One data-driven file replaces them: it diffs CmdletsToExport against the assembly's cmdlet types in both directions and asserts the conventions reflection can see. Behavioural tests are untouched: no-session errors, binding rejections, ShouldProcess and -WhatIf, ConfirmImpact, ValidateSet and ValidateRange values, parameter types, positions and pipeline binding. The generated help covered 169 of 194 cmdlets. Regenerated with the repo's own generate-help.ps1: 25 new markdown stubs, 13 existing docs picking up parameters added in earlier waves, and a rebuilt MAML. Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
85 lines
3.1 KiB
PowerShell
85 lines
3.1 KiB
PowerShell
#Requires -Module Pester
|
|
<#
|
|
.SYNOPSIS
|
|
Pester 5 tests for Invoke-PveStorageDownload.
|
|
|
|
All tests are fully offline — no live Proxmox VE target is required.
|
|
#>
|
|
|
|
BeforeAll {
|
|
. $PSScriptRoot/../_TestHelper.ps1
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Invoke-PveStorageDownload
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Invoke-PveStorageDownload' {
|
|
BeforeAll { $script:Cmd = Get-Command 'Invoke-PveStorageDownload' }
|
|
|
|
Context 'ShouldProcess support' {
|
|
It 'Should support WhatIf' {
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should support Confirm' {
|
|
$script:Cmd.Parameters.ContainsKey('Confirm') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Required parameters' {
|
|
It 'Node should be at Position 0' {
|
|
$pos = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
ForEach-Object { $_.Position }
|
|
$pos | Should -Contain 0
|
|
}
|
|
|
|
It 'Storage should be at Position 1' {
|
|
$pos = $script:Cmd.Parameters['Storage'].ParameterSets.Values |
|
|
ForEach-Object { $_.Position }
|
|
$pos | Should -Contain 1
|
|
}
|
|
|
|
It 'Url should be at Position 2' {
|
|
$pos = $script:Cmd.Parameters['Url'].ParameterSets.Values |
|
|
ForEach-Object { $_.Position }
|
|
$pos | Should -Contain 2
|
|
}
|
|
|
|
It 'Filename should be at Position 3' {
|
|
$pos = $script:Cmd.Parameters['Filename'].ParameterSets.Values |
|
|
ForEach-Object { $_.Position }
|
|
$pos | Should -Contain 3
|
|
}
|
|
}
|
|
|
|
Context 'Optional parameters' {
|
|
It 'ContentType should have a ValidateSet of iso, vztmpl, backup, import' {
|
|
$validateSet = $script:Cmd.Parameters['ContentType'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] }
|
|
$validateSet | Should -Not -BeNullOrEmpty
|
|
$validValues = $validateSet.ValidValues
|
|
$validValues | Should -Contain 'iso'
|
|
$validValues | Should -Contain 'vztmpl'
|
|
$validValues | Should -Contain 'backup'
|
|
$validValues | Should -Contain 'import'
|
|
}
|
|
|
|
It 'Should have Wait switch parameter' {
|
|
$script:Cmd.Parameters.ContainsKey('Wait') | Should -BeTrue
|
|
$script:Cmd.Parameters['Wait'].SwitchParameter | Should -BeTrue
|
|
}
|
|
|
|
It 'TimeoutSeconds should reject negative values' {
|
|
{ Invoke-PveStorageDownload -Node 'pve1' -Storage 'local' -Url 'https://example.com/test.iso' -Filename 'test.iso' -TimeoutSeconds -1 -Confirm:$false -ErrorAction Stop } |
|
|
Should -Throw
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
{ Invoke-PveStorageDownload -Node 'pve1' -Storage 'local' -Url 'https://example.com/test.iso' -Filename 'test.iso' -Confirm:$false -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|