mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-04 03:05:32 +00:00
goodolclint-claude[bot]
109dca657a
Skip-IfMissing skipped a test whenever the cmdlet under test was absent from the build, including the test asserting it exists. Every cmdlet compiles into one assembly, so there is no partial-build case for it to serve; all it did was hide a missing cmdlet. Delete the 37 copies and every call site, and drop the residual conditional skips in the same family (CmdExists probes, an attribute-presence skip in SdnCmdlets, a lifecycle helper skipping on a cmdlet-name collision fixed long ago). 894 It blocks only reflected [Cmdlet] and [Parameter] attributes back at the compiler: existence, CommandType -eq 'Cmdlet', Parameters.ContainsKey, IsMandatory reflection, and per-file CmdletsToExport asserts for whichever names an author remembered. Nothing reflected over the built assembly, so a new cmdlet missing from the manifest shipped invisible. One data-driven file replaces them: it diffs CmdletsToExport against the assembly's cmdlet types in both directions and asserts the conventions reflection can see. Behavioural tests are untouched: no-session errors, binding rejections, ShouldProcess and -WhatIf, ConfirmImpact, ValidateSet and ValidateRange values, parameter types, positions and pipeline binding. The generated help covered 169 of 194 cmdlets. Regenerated with the repo's own generate-help.ps1: 25 new markdown stubs, 13 existing docs picking up parameters added in earlier waves, and a rebuilt MAML. Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
83 lines
3.1 KiB
PowerShell
83 lines
3.1 KiB
PowerShell
#Requires -Module Pester
|
|
<#
|
|
.SYNOPSIS
|
|
Pester 5 tests for firewall options/ref cmdlets:
|
|
Get-PveFirewallOptions, Set-PveFirewallOptions, Get-PveFirewallRef.
|
|
|
|
All tests are fully offline — no live Proxmox VE target is required.
|
|
#>
|
|
|
|
BeforeAll {
|
|
. $PSScriptRoot/../_TestHelper.ps1
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Get-PveFirewallOptions
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Get-PveFirewallOptions' {
|
|
BeforeAll { $script:Cmd = Get-Command 'Get-PveFirewallOptions' }
|
|
|
|
Context 'Parameter metadata' {
|
|
It 'Should have mandatory Level parameter with ValidateSet' {
|
|
$param = $script:Cmd.Parameters['Level']
|
|
$param | Should -Not -BeNullOrEmpty
|
|
$isMandatory = $param.ParameterSets.Values | Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
$validateSet = $param.Attributes | Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] }
|
|
$validateSet | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
{ Get-PveFirewallOptions -Level 'cluster' -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Set-PveFirewallOptions
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Set-PveFirewallOptions' {
|
|
BeforeAll { $script:Cmd = Get-Command 'Set-PveFirewallOptions' }
|
|
|
|
Context 'ShouldProcess support' {
|
|
It 'Should support WhatIf' {
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Parameter metadata' {
|
|
It 'Should have mandatory Level parameter with ValidateSet' {
|
|
$param = $script:Cmd.Parameters['Level']
|
|
$param | Should -Not -BeNullOrEmpty
|
|
$isMandatory = $param.ParameterSets.Values | Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
$validateSet = $param.Attributes | Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] }
|
|
$validateSet | Should -Not -BeNullOrEmpty
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
{ Set-PveFirewallOptions -Level 'cluster' -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Get-PveFirewallRef
|
|
# ---------------------------------------------------------------------------
|
|
Describe 'Get-PveFirewallRef' {
|
|
BeforeAll { $script:Cmd = Get-Command 'Get-PveFirewallRef' }
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active' {
|
|
{ Get-PveFirewallRef -Level Cluster -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
}
|
|
}
|
|
}
|