mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-09-03 18:55:33 +00:00
goodolclint-claude[bot]
109dca657a
Skip-IfMissing skipped a test whenever the cmdlet under test was absent from the build, including the test asserting it exists. Every cmdlet compiles into one assembly, so there is no partial-build case for it to serve; all it did was hide a missing cmdlet. Delete the 37 copies and every call site, and drop the residual conditional skips in the same family (CmdExists probes, an attribute-presence skip in SdnCmdlets, a lifecycle helper skipping on a cmdlet-name collision fixed long ago). 894 It blocks only reflected [Cmdlet] and [Parameter] attributes back at the compiler: existence, CommandType -eq 'Cmdlet', Parameters.ContainsKey, IsMandatory reflection, and per-file CmdletsToExport asserts for whichever names an author remembered. Nothing reflected over the built assembly, so a new cmdlet missing from the manifest shipped invisible. One data-driven file replaces them: it diffs CmdletsToExport against the assembly's cmdlet types in both directions and asserts the conventions reflection can see. Behavioural tests are untouched: no-session errors, binding rejections, ShouldProcess and -WhatIf, ConfirmImpact, ValidateSet and ValidateRange values, parameter types, positions and pipeline binding. The generated help covered 169 of 194 cmdlets. Regenerated with the repo's own generate-help.ps1: 25 new markdown stubs, 13 existing docs picking up parameters added in earlier waves, and a rebuilt MAML. Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
57 lines
2.0 KiB
PowerShell
57 lines
2.0 KiB
PowerShell
#Requires -Module Pester
|
|
<#
|
|
.SYNOPSIS
|
|
Pester 5 tests for New-PveContainer.
|
|
All tests are fully offline — no live Proxmox VE target is required.
|
|
#>
|
|
|
|
BeforeAll {
|
|
. $PSScriptRoot/../_TestHelper.ps1
|
|
}
|
|
|
|
Describe 'New-PveContainer' {
|
|
Context 'ShouldProcess support' {
|
|
BeforeAll {
|
|
$script:Cmd = Get-Command 'New-PveContainer'
|
|
}
|
|
|
|
It 'Should support ShouldProcess (WhatIf parameter present)' {
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should support ShouldProcess (Confirm parameter present)' {
|
|
$script:Cmd.Parameters.ContainsKey('Confirm') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'RootFsSize validation' {
|
|
# Validation runs before ShouldProcess so -WhatIf is enough to exercise it
|
|
# without an active session.
|
|
|
|
It 'Should reject sub-GB units (e.g. 512M)' {
|
|
{ New-PveContainer -Node 'pve-node1' -RootFsStorage 'local-lvm' -RootFsSize '512M' -WhatIf -ErrorAction Stop } |
|
|
Should -Throw '*unsupported unit*'
|
|
}
|
|
|
|
It 'Should reject sub-GB units even when -RootFsStorage is omitted' {
|
|
{ New-PveContainer -Node 'pve-node1' -RootFsSize '512M' -WhatIf -ErrorAction Stop } |
|
|
Should -Throw '*unsupported unit*'
|
|
}
|
|
|
|
It 'Should reject malformed input (e.g. 8.5G)' {
|
|
{ New-PveContainer -Node 'pve-node1' -RootFsStorage 'local-lvm' -RootFsSize '8.5G' -WhatIf -ErrorAction Stop } |
|
|
Should -Throw '*not a valid size*'
|
|
}
|
|
|
|
It 'Should accept a bare integer with -WhatIf' {
|
|
{ New-PveContainer -Node 'pve-node1' -RootFsStorage 'local-lvm' -RootFsSize '8' -WhatIf -ErrorAction Stop } |
|
|
Should -Not -Throw
|
|
}
|
|
|
|
It 'Should accept "8G" with -WhatIf' {
|
|
{ New-PveContainer -Node 'pve-node1' -RootFsStorage 'local-lvm' -RootFsSize '8G' -WhatIf -ErrorAction Stop } |
|
|
Should -Not -Throw
|
|
}
|
|
}
|
|
}
|