mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-08-07 21:13:12 +00:00
f3b06171b2
PveHttpClient was constructed without setting HttpClient.Timeout, so .NET's 100s default applied to every request. Multi-GB ISO uploads via Send-PveFile on a real LAN reliably tripped this with TaskCanceledException after 100 seconds, and there was no way to override it. - PveSession gains a Timeout (TimeSpan) property, defaulting to 100s. - PveHttpClient accepts an optional per-instance timeout override that takes precedence over the session timeout. - Connect-PveServer exposes -TimeoutSeconds to set the session default. - Send-PveFile and Invoke-PveStorageDownload expose -TimeoutSeconds with a 30-minute implicit default so large uploads/downloads do not trip the 100s default. -TimeoutSeconds 0 means Timeout.InfiniteTimeSpan. Tracked as F087. Closes #59. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
184 lines
8.2 KiB
PowerShell
184 lines
8.2 KiB
PowerShell
#Requires -Module Pester
|
|
<#
|
|
.SYNOPSIS
|
|
Pester 5 tests for Send-PveFile.
|
|
All tests are fully offline — no live Proxmox VE target is required.
|
|
If the cmdlet is not yet compiled the tests are marked Skipped.
|
|
#>
|
|
|
|
BeforeAll {
|
|
. $PSScriptRoot/../_TestHelper.ps1
|
|
|
|
$script:CmdExists = $null -ne (Get-Command 'Send-PveFile' -ErrorAction SilentlyContinue)
|
|
}
|
|
|
|
Describe 'Send-PveFile' {
|
|
|
|
Context 'Manifest declaration' {
|
|
It 'Should be declared in CmdletsToExport' {
|
|
$manifestPath = Join-Path (Get-Module PSProxmoxVE).ModuleBase 'PSProxmoxVE.psd1'
|
|
if (-not (Test-Path $manifestPath)) { Set-ItResult -Skipped -Because 'Manifest not found'; return }
|
|
$manifest = Import-PowerShellDataFile $manifestPath
|
|
$manifest.CmdletsToExport | Should -Contain 'Send-PveFile'
|
|
}
|
|
}
|
|
|
|
Context 'Command existence' {
|
|
It 'Should be available after module import' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
(Get-Command 'Send-PveFile').CommandType | Should -Be 'Cmdlet'
|
|
}
|
|
}
|
|
|
|
Context 'Required parameters' {
|
|
BeforeAll {
|
|
$script:Cmd = Get-Command 'Send-PveFile' -ErrorAction SilentlyContinue
|
|
}
|
|
|
|
It 'Should have Node parameter (Mandatory)' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$isMandatory = $script:Cmd.Parameters['Node'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should have Storage parameter (Mandatory)' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$isMandatory = $script:Cmd.Parameters['Storage'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'Should have Path parameter (Mandatory)' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$isMandatory = $script:Cmd.Parameters['Path'].ParameterSets.Values |
|
|
Where-Object { $_.IsMandatory }
|
|
$isMandatory | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
}
|
|
|
|
Context 'ChecksumAlgorithm ValidateSet' {
|
|
BeforeAll {
|
|
$script:Cmd = Get-Command 'Send-PveFile' -ErrorAction SilentlyContinue
|
|
}
|
|
|
|
It 'Should have ChecksumAlgorithm parameter' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$script:Cmd.Parameters.ContainsKey('ChecksumAlgorithm') | Should -BeTrue
|
|
}
|
|
|
|
It 'ChecksumAlgorithm should have a ValidateSet attribute' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$validateSetAttr = $script:Cmd.Parameters['ChecksumAlgorithm'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] }
|
|
$validateSetAttr | Should -Not -BeNullOrEmpty
|
|
}
|
|
|
|
It 'ChecksumAlgorithm ValidateSet should include md5' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$validateSetAttr = $script:Cmd.Parameters['ChecksumAlgorithm'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] } |
|
|
Select-Object -First 1
|
|
$validateSetAttr.ValidValues | Should -Contain 'md5'
|
|
}
|
|
|
|
It 'ChecksumAlgorithm ValidateSet should include sha1' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$validateSetAttr = $script:Cmd.Parameters['ChecksumAlgorithm'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] } |
|
|
Select-Object -First 1
|
|
$validateSetAttr.ValidValues | Should -Contain 'sha1'
|
|
}
|
|
|
|
It 'ChecksumAlgorithm ValidateSet should include sha256' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$validateSetAttr = $script:Cmd.Parameters['ChecksumAlgorithm'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] } |
|
|
Select-Object -First 1
|
|
$validateSetAttr.ValidValues | Should -Contain 'sha256'
|
|
}
|
|
|
|
It 'ChecksumAlgorithm ValidateSet should include sha512' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$validateSetAttr = $script:Cmd.Parameters['ChecksumAlgorithm'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] } |
|
|
Select-Object -First 1
|
|
$validateSetAttr.ValidValues | Should -Contain 'sha512'
|
|
}
|
|
}
|
|
|
|
Context 'ContentType parameter' {
|
|
BeforeAll {
|
|
$script:Cmd = Get-Command 'Send-PveFile' -ErrorAction SilentlyContinue
|
|
}
|
|
|
|
It 'Should have ContentType parameter' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$script:Cmd.Parameters.ContainsKey('ContentType') | Should -BeTrue
|
|
}
|
|
|
|
It 'ContentType should have a ValidateSet attribute with iso, vztmpl, import' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$validateSetAttr = $script:Cmd.Parameters['ContentType'].Attributes |
|
|
Where-Object { $_ -is [System.Management.Automation.ValidateSetAttribute] } |
|
|
Select-Object -First 1
|
|
$validateSetAttr.ValidValues | Should -Contain 'iso'
|
|
$validateSetAttr.ValidValues | Should -Contain 'vztmpl'
|
|
$validateSetAttr.ValidValues | Should -Contain 'import'
|
|
}
|
|
}
|
|
|
|
Context 'ShouldProcess support' {
|
|
BeforeAll {
|
|
$script:Cmd = Get-Command 'Send-PveFile' -ErrorAction SilentlyContinue
|
|
}
|
|
|
|
It 'Should support WhatIf' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$script:Cmd.Parameters.ContainsKey('WhatIf') | Should -BeTrue
|
|
}
|
|
}
|
|
|
|
Context 'Optional parameters' {
|
|
BeforeAll {
|
|
$script:Cmd = Get-Command 'Send-PveFile' -ErrorAction SilentlyContinue
|
|
}
|
|
|
|
It 'Should have Checksum parameter' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$script:Cmd.Parameters.ContainsKey('Checksum') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should have Session parameter' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$script:Cmd.Parameters.ContainsKey('Session') | Should -BeTrue
|
|
}
|
|
|
|
It 'Should have TimeoutSeconds parameter' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$script:Cmd.Parameters.ContainsKey('TimeoutSeconds') | Should -BeTrue
|
|
}
|
|
|
|
It 'TimeoutSeconds should reject negative values' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$tmpIso = [System.IO.Path]::GetTempFileName()
|
|
try {
|
|
{ Send-PveFile -Node 'n' -Storage 's' -Path $tmpIso -TimeoutSeconds -1 -Confirm:$false -ErrorAction Stop } |
|
|
Should -Throw
|
|
} finally { Remove-Item $tmpIso -ErrorAction SilentlyContinue }
|
|
}
|
|
}
|
|
|
|
Context 'Without active session' {
|
|
It 'Should throw when no session is active (without -WhatIf)' {
|
|
if (-not $script:CmdExists) { Set-ItResult -Skipped -Because 'Not yet compiled'; return }
|
|
$tmpIso = [System.IO.Path]::GetTempFileName()
|
|
try {
|
|
{ Send-PveFile -Node 'pve-node1' -Storage 'local' -Path $tmpIso -Confirm:$false -ErrorAction Stop } |
|
|
Should -Throw '*No active Proxmox VE session*'
|
|
} finally { Remove-Item $tmpIso -ErrorAction SilentlyContinue }
|
|
}
|
|
}
|
|
}
|