mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-07-26 07:58:14 +00:00
68dadbfdc0
Phase 1 — Trivial fixes: - F071: Add Uri.EscapeDataString to GetPveTemplateCmdlet node path - F077: Add ValidateRange(100, 999999999) to GetPveTaskListCmdlet.VmId - F076: Create .github/dependabot.yml (nuget + github-actions, weekly) - F079: Fix unit-tests.yml dotnet SDK from 9.0.x to 10.0.x - F048: Mark wont_fix — sync-over-async accepted for PS 5.1 compat Phase 2 — Framework targeting (D009 compliance): - F047: Reduce publishable csproj to netstandard2.0 only, remove all #if NET48/NETSTANDARD2_0 conditionals from PveHttpClient.cs, restructure build.yml for netstandard2.0 publish + net10.0/net48 tests - F064: Resolved by F047 — SMA 7.5.0 ItemGroup removed with net10.0 TFM - F070: Add PS 5.1 smoke-test job to publish.yml (windows-latest) Phase 3 — IPveHttpClient interface extraction (F045): - Extract IPveHttpClient interface from PveHttpClient - Add constructor injection to all 14 service classes - Services use injected client when available, create+dispose when not Phase 4 — Service unit tests (F078): - 196 new xUnit tests across 10 service test files - All services tested via Moq-mocked IPveHttpClient - Total test count: 382 (was 186) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
128 lines
5.2 KiB
C#
128 lines
5.2 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Threading.Tasks;
|
|
using Moq;
|
|
using Xunit;
|
|
using PSProxmoxVE.Core.Authentication;
|
|
using PSProxmoxVE.Core.Client;
|
|
using PSProxmoxVE.Core.Services;
|
|
|
|
namespace PSProxmoxVE.Core.Tests.Services
|
|
{
|
|
public class ClusterServiceTests
|
|
{
|
|
private static PveSession CreateSession()
|
|
{
|
|
return new PveSession("pve.example.com", 8006, false,
|
|
"root@pam!testtoken=aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee");
|
|
}
|
|
|
|
[Fact]
|
|
public void GetClusterStatus_ReturnsStatusArray()
|
|
{
|
|
// Arrange
|
|
var json = @"{""data"": [
|
|
{""type"": ""cluster"", ""name"": ""pve-cluster"", ""nodes"": 3, ""quorate"": 1, ""version"": 5},
|
|
{""type"": ""node"", ""name"": ""pve1"", ""online"": 1, ""local"": 1, ""nodeid"": 1, ""ip"": ""10.0.0.1""},
|
|
{""type"": ""node"", ""name"": ""pve2"", ""online"": 1, ""local"": 0, ""nodeid"": 2, ""ip"": ""10.0.0.2""}
|
|
]}";
|
|
var mockClient = new Mock<IPveHttpClient>();
|
|
mockClient.Setup(c => c.GetAsync("cluster/status")).ReturnsAsync(json);
|
|
var service = new ClusterService(mockClient.Object);
|
|
|
|
// Act
|
|
var statuses = service.GetClusterStatus(CreateSession());
|
|
|
|
// Assert
|
|
Assert.Equal(3, statuses.Length);
|
|
Assert.Equal("cluster", statuses[0].Type);
|
|
Assert.Equal("pve-cluster", statuses[0].Name);
|
|
Assert.Equal(3, statuses[0].Nodes);
|
|
Assert.Equal(1, statuses[0].Quorate);
|
|
Assert.Equal("node", statuses[1].Type);
|
|
Assert.Equal("pve1", statuses[1].Name);
|
|
Assert.Equal(1, statuses[1].Online);
|
|
Assert.Equal("10.0.0.1", statuses[1].Ip);
|
|
Assert.Equal("node", statuses[2].Type);
|
|
Assert.Equal("pve2", statuses[2].Name);
|
|
mockClient.Verify(c => c.GetAsync("cluster/status"), Times.Once);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetClusterResources_ReturnsResourcesArray()
|
|
{
|
|
// Arrange
|
|
var json = @"{""data"": [
|
|
{""id"": ""node/pve1"", ""type"": ""node"", ""node"": ""pve1"", ""status"": ""online"", ""maxcpu"": 16, ""maxmem"": 68719476736, ""cpu"": 0.05},
|
|
{""id"": ""qemu/100"", ""type"": ""qemu"", ""node"": ""pve1"", ""name"": ""test-vm"", ""status"": ""running"", ""vmid"": 100, ""maxcpu"": 4, ""maxmem"": 8589934592},
|
|
{""id"": ""storage/local"", ""type"": ""storage"", ""node"": ""pve1"", ""status"": ""available"", ""maxdisk"": 107374182400, ""disk"": 53687091200}
|
|
]}";
|
|
var mockClient = new Mock<IPveHttpClient>();
|
|
mockClient.Setup(c => c.GetAsync("cluster/resources")).ReturnsAsync(json);
|
|
var service = new ClusterService(mockClient.Object);
|
|
|
|
// Act
|
|
var resources = service.GetClusterResources(CreateSession());
|
|
|
|
// Assert
|
|
Assert.Equal(3, resources.Length);
|
|
Assert.Equal("node/pve1", resources[0].Id);
|
|
Assert.Equal("node", resources[0].Type);
|
|
Assert.Equal("qemu/100", resources[1].Id);
|
|
Assert.Equal("test-vm", resources[1].Name);
|
|
Assert.Equal(100, resources[1].VmId);
|
|
Assert.Equal("storage/local", resources[2].Id);
|
|
Assert.Equal("storage", resources[2].Type);
|
|
mockClient.Verify(c => c.GetAsync("cluster/resources"), Times.Once);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetClusterResources_WithTypeFilter_AppendsQueryString()
|
|
{
|
|
// Arrange
|
|
var json = @"{""data"": [
|
|
{""id"": ""qemu/100"", ""type"": ""qemu"", ""node"": ""pve1"", ""name"": ""test-vm"", ""status"": ""running"", ""vmid"": 100}
|
|
]}";
|
|
var mockClient = new Mock<IPveHttpClient>();
|
|
mockClient.Setup(c => c.GetAsync("cluster/resources?type=vm")).ReturnsAsync(json);
|
|
var service = new ClusterService(mockClient.Object);
|
|
|
|
// Act
|
|
var resources = service.GetClusterResources(CreateSession(), "vm");
|
|
|
|
// Assert
|
|
Assert.Single(resources);
|
|
Assert.Equal("qemu/100", resources[0].Id);
|
|
mockClient.Verify(c => c.GetAsync("cluster/resources?type=vm"), Times.Once);
|
|
}
|
|
|
|
[Fact]
|
|
public void GetClusterStatus_NullSession_ThrowsArgumentNullException()
|
|
{
|
|
// Arrange
|
|
var mockClient = new Mock<IPveHttpClient>();
|
|
var service = new ClusterService(mockClient.Object);
|
|
|
|
// Act & Assert
|
|
Assert.Throws<ArgumentNullException>(() => service.GetClusterStatus(null!));
|
|
}
|
|
|
|
[Fact]
|
|
public void GetClusterResources_NullSession_ThrowsArgumentNullException()
|
|
{
|
|
// Arrange
|
|
var mockClient = new Mock<IPveHttpClient>();
|
|
var service = new ClusterService(mockClient.Object);
|
|
|
|
// Act & Assert
|
|
Assert.Throws<ArgumentNullException>(() => service.GetClusterResources(null!));
|
|
}
|
|
|
|
[Fact]
|
|
public void Constructor_NullClient_ThrowsArgumentNullException()
|
|
{
|
|
Assert.Throws<ArgumentNullException>(() => new ClusterService(null!));
|
|
}
|
|
}
|
|
}
|