gsadmin/PSProxmoxVE
1
0
Fork 0
mirror of https://github.com/GoodOlClint/PSProxmoxVE.git synced 2026-08-11 06:46:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(storage): implement Portal defaulting for iSCSI, fix Pool/CephPool selection, add NFS format validation

Browse Source 
Co-authored-by: GoodOlClint <151449+GoodOlClint@users.noreply.github.com>
Agent-Logs-Url: https://github.com/GoodOlClint/PSProxmoxVE/sessions/d84722e4-409e-4ced-bfbc-f323715b8bdc
This commit is contained in:
copilot-swe-agent[bot]
2026-03-24 20:36:46 +00:00
parent 79c227f131
commit f76ff513e9
3 changed files with 32 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PSProxmoxVE/Cmdlets/Storage/NewPveStorageCmdlet.cs
+22 -3
View File
@@ -1,3 +1,4 @@
using System;
using System.Collections.Generic;
using System.Management.Automation;
using Newtonsoft.Json.Linq;
@@ -114,14 +115,32 @@ namespace PSProxmoxVE.Cmdlets.Storage
AddIfNotEmpty(data, "content", Content);
AddIfNotEmpty(data, "path", Path);
AddIfNotEmpty(data, "server", Server);
AddIfNotEmpty(data, "export", Export);
AddIfNotEmpty(data, "vgname", VgName);
AddIfNotEmpty(data, "thinpool", ThinPool);
AddIfNotEmpty(data, "pool", Pool ?? CephPool);
AddIfNotEmpty(data, "pool", !string.IsNullOrEmpty(Pool) ? Pool : CephPool);
AddIfNotEmpty(data, "monhost", MonHost);
AddIfNotEmpty(data, "target", Target);
AddIfNotEmpty(data, "portal", Portal);
// For iSCSI types, 'server' is not a valid API field; derive portal from Server if Portal omitted.
bool isIscsiType = string.Equals(Type, "iscsi", StringComparison.OrdinalIgnoreCase)
|| string.Equals(Type, "iscsidirect", StringComparison.OrdinalIgnoreCase);
if (isIscsiType)
{
string? portalValue;
if (!string.IsNullOrEmpty(Portal))
portalValue = Portal;
else if (!string.IsNullOrEmpty(Server))
portalValue = $"{Server}:3260";
else
portalValue = null;
AddIfNotEmpty(data, "portal", portalValue);
}
else
{
AddIfNotEmpty(data, "server", Server);
AddIfNotEmpty(data, "portal", Portal);
}
AddIfNotEmpty(data, "nodes", Nodes);
if (Shared.IsPresent) data["shared"] = "1";
if (Disable.IsPresent) data["disable"] = "1";