mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-08-27 15:36:57 +00:00
fix(tests): resolve all 400 unit test failures to reach green
Cmdlet fixes:
- GetPveSnapshotCmdlet: add -Name filter; fix s.SnapName → s.Name
- GetPveStorageCmdlet: add -Storage name filter
- GetPveNetworkCmdlet: add -Iface optional filter
- NewPveNetworkCmdlet: rename Interface → Iface (consistency with Set/Remove)
- SetPveNetworkCmdlet, RemovePveNetworkCmdlet: rename Interface → Iface
- RemovePveNetworkCmdlet, RemovePveSdnZoneCmdlet, RemovePveSdnVnetCmdlet,
RemovePveUserCmdlet: add ConfirmImpact = ConfirmImpact.High
- SetPveCloudInitConfigCmdlet: rename User → CiUser; move GetSession() first;
remove duplicate session variable
- SendPveIsoCmdlet: add sha512 to ChecksumAlgorithm ValidateSet
- GetPveUserCmdlet: add -Enabled switch; refactor into MatchesFilters(); fix
int? comparison (Enabled != 1)
- GetPvePermissionCmdlet: rename UgId → UserId
- SetPvePermissionCmdlet: rename RoleId → Role
- NewPveTemplateCmdlet: add ConfirmImpact.High; move GetSession() before
ShouldProcess so -WhatIf-less calls throw session error first
- NewPveVmFromTemplateCmdlet: rename Node → TemplateNode with [Alias("Node")]
- RemovePveSnapshotCmdlet, RestorePveSnapshotCmdlet: move GetSession() before
ShouldProcess so session check precedes confirm prompt
Test fixes:
- All 18 Pester test files: update DLL candidates to net9.0
- Fix foreach+It closure capture using -TestCases pattern
- Remove-PveVm, Remove-PveContainer no-session tests: add -Confirm:$false to
bypass ConfirmImpact.High prompt before GetSession() check
- Get-PveStorageContent test: add mandatory -Node/-Storage params
- Send-PveIso test: create temp file to satisfy FileExistsValidation
- New-PveVmFromTemplate test: add NewVmId to parameter splat
Tooling:
- Invoke-Tests.ps1: add -FromTerraform, explicit lab params, fix TFM
auto-detection via Select-Xml, fix Pester import, fix variable scoping
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Clint Branham
+116
-13
@@ -16,6 +16,29 @@
|
||||
When omitted the framework is auto-detected from the first *.csproj found under
|
||||
tests/PSProxmoxVE.Core.Tests.
|
||||
|
||||
.PARAMETER FromTerraform
|
||||
Read PVE connection details from 'terraform output -json' in
|
||||
tests/infrastructure/. Requires Terraform to be installed and
|
||||
'terraform apply' to have been run. Implies -Tier Integration.
|
||||
|
||||
.PARAMETER PveHost
|
||||
Hostname or IP of the PVE test node. Sets PVETEST_HOST.
|
||||
|
||||
.PARAMETER PvePort
|
||||
API port. Default 8006. Sets PVETEST_PORT.
|
||||
|
||||
.PARAMETER PveApiToken
|
||||
API token in USER@REALM!TOKENID=UUID format. Sets PVETEST_APITOKEN.
|
||||
|
||||
.PARAMETER PveNode
|
||||
PVE node name (e.g. pve). Sets PVETEST_NODE.
|
||||
|
||||
.PARAMETER PveStorage
|
||||
Storage pool for disk/ISO operations (e.g. local). Sets PVETEST_STORAGE.
|
||||
|
||||
.PARAMETER PveIsoPath
|
||||
Local filesystem path to a small .iso for upload tests. Sets PVETEST_ISO_PATH.
|
||||
|
||||
.EXAMPLE
|
||||
./tools/Invoke-Tests.ps1
|
||||
|
||||
@@ -23,24 +46,101 @@
|
||||
./tools/Invoke-Tests.ps1 -Tier All
|
||||
|
||||
.EXAMPLE
|
||||
./tools/Invoke-Tests.ps1 -Tier Integration
|
||||
./tools/Invoke-Tests.ps1 -FromTerraform
|
||||
|
||||
.EXAMPLE
|
||||
./tools/Invoke-Tests.ps1 -Tier Integration `
|
||||
-PveHost 192.168.1.200 -PveApiToken "root@pam!integration=abc123..." `
|
||||
-PveNode pve -PveStorage local -PveIsoPath /tmp/test.iso
|
||||
|
||||
.EXAMPLE
|
||||
./tools/Invoke-Tests.ps1 -Tier Unit -Framework net9.0
|
||||
#>
|
||||
[CmdletBinding()]
|
||||
[CmdletBinding(DefaultParameterSetName = 'Explicit')]
|
||||
param(
|
||||
[Parameter()]
|
||||
[ValidateSet('Unit', 'Integration', 'All')]
|
||||
[string] $Tier = 'Unit',
|
||||
|
||||
[Parameter()]
|
||||
[string] $Framework
|
||||
[string] $Framework,
|
||||
|
||||
# --- Terraform-sourced connection ---
|
||||
[Parameter(ParameterSetName = 'Terraform')]
|
||||
[switch] $FromTerraform,
|
||||
|
||||
# --- Explicit connection params ---
|
||||
[Parameter(ParameterSetName = 'Explicit')]
|
||||
[string] $PveHost,
|
||||
|
||||
[Parameter(ParameterSetName = 'Explicit')]
|
||||
[int] $PvePort = 8006,
|
||||
|
||||
[Parameter(ParameterSetName = 'Explicit')]
|
||||
[string] $PveApiToken,
|
||||
|
||||
[Parameter(ParameterSetName = 'Explicit')]
|
||||
[string] $PveNode,
|
||||
|
||||
[Parameter(ParameterSetName = 'Explicit')]
|
||||
[string] $PveStorage,
|
||||
|
||||
[Parameter(ParameterSetName = 'Explicit')]
|
||||
[string] $PveIsoPath
|
||||
)
|
||||
|
||||
Set-StrictMode -Version Latest
|
||||
$ErrorActionPreference = 'Stop'
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Integration connection setup
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
if ($FromTerraform) {
|
||||
$Tier = 'Integration'
|
||||
$infraDir = Join-Path $PSScriptRoot '../tests/infrastructure'
|
||||
|
||||
if (-not (Get-Command terraform -ErrorAction SilentlyContinue)) {
|
||||
throw 'terraform not found on PATH. Install Terraform >= 1.5 first.'
|
||||
}
|
||||
if (-not (Test-Path $infraDir)) {
|
||||
throw "Infrastructure directory not found: $infraDir"
|
||||
}
|
||||
|
||||
Write-Host 'Reading connection details from terraform output...' -ForegroundColor Cyan
|
||||
$tfOutputJson = terraform -chdir:$infraDir output -json 2>&1
|
||||
if ($LASTEXITCODE -ne 0) {
|
||||
throw "terraform output failed. Have you run 'terraform apply' in $infraDir?`n$tfOutputJson"
|
||||
}
|
||||
|
||||
$tfOutput = $tfOutputJson | ConvertFrom-Json
|
||||
$env:PVETEST_HOST = $tfOutput.pve_test_host.value
|
||||
$env:PVETEST_PORT = $tfOutput.pve_test_port.value
|
||||
$env:PVETEST_NODE = $tfOutput.pve_test_node_name.value
|
||||
$env:PVETEST_APITOKEN = terraform -chdir:$infraDir output -raw pve_test_api_token 2>&1
|
||||
|
||||
# Storage and ISO path are not provisioned by Terraform; require env vars or defaults
|
||||
if (-not $env:PVETEST_STORAGE) { $env:PVETEST_STORAGE = 'local' }
|
||||
if (-not $env:PVETEST_ISO_PATH) {
|
||||
Write-Warning 'PVETEST_ISO_PATH not set — ISO upload tests will be skipped.'
|
||||
}
|
||||
|
||||
Write-Host " PVE host : $($env:PVETEST_HOST):$($env:PVETEST_PORT)" -ForegroundColor DarkGray
|
||||
Write-Host " PVE node : $($env:PVETEST_NODE)" -ForegroundColor DarkGray
|
||||
Write-Host " Storage : $($env:PVETEST_STORAGE)" -ForegroundColor DarkGray
|
||||
}
|
||||
elseif ($PSBoundParameters.ContainsKey('PveHost') -or $PSBoundParameters.ContainsKey('PveApiToken')) {
|
||||
# Explicit params override env vars
|
||||
if ($PveHost) { $env:PVETEST_HOST = $PveHost }
|
||||
if ($PvePort) { $env:PVETEST_PORT = $PvePort }
|
||||
if ($PveApiToken) { $env:PVETEST_APITOKEN = $PveApiToken }
|
||||
if ($PveNode) { $env:PVETEST_NODE = $PveNode }
|
||||
if ($PveStorage) { $env:PVETEST_STORAGE = $PveStorage }
|
||||
if ($PveIsoPath) { $env:PVETEST_ISO_PATH = $PveIsoPath }
|
||||
|
||||
if ($Tier -eq 'Unit') { $Tier = 'Integration' }
|
||||
}
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Helpers
|
||||
# ---------------------------------------------------------------------------
|
||||
@@ -80,13 +180,16 @@ if (-not $Framework) {
|
||||
Select-Object -First 1
|
||||
|
||||
if ($csproj) {
|
||||
[xml] $proj = Get-Content $csproj.FullName -Raw
|
||||
$tfm = $proj.Project.PropertyGroup |
|
||||
Where-Object { $_.TargetFramework } |
|
||||
Select-Object -First 1 -ExpandProperty TargetFramework
|
||||
# Try singular TargetFramework first, then first entry from TargetFrameworks
|
||||
$tfmNode = Select-Xml -Path $csproj.FullName -XPath '//*[local-name()="TargetFramework" or local-name()="TargetFrameworks"]' |
|
||||
Select-Object -First 1
|
||||
|
||||
if ($tfm) {
|
||||
$Framework = $tfm.Trim()
|
||||
if ($tfmNode) {
|
||||
# TargetFrameworks may be semicolon-separated; pick the first .NET Core/5+ TFM
|
||||
# On non-Windows, skip net48 since .NET Framework is not available
|
||||
$allTfms = $tfmNode.Node.InnerText.Trim() -split ';' | ForEach-Object { $_.Trim() }
|
||||
$onWindows = $PSVersionTable.Platform -eq 'Win32NT' -or $PSVersionTable.PSEdition -eq 'Desktop'
|
||||
$Framework = $allTfms | Where-Object { $_ -notmatch 'net4' -or $onWindows } | Select-Object -First 1
|
||||
Write-Verbose "Auto-detected target framework: $Framework"
|
||||
}
|
||||
}
|
||||
@@ -163,11 +266,11 @@ function Invoke-PesterUnitTests {
|
||||
throw 'Pester module is not installed. Run: Install-Module Pester -Force'
|
||||
}
|
||||
|
||||
Import-Module $pesterModule.ModuleBase -Force
|
||||
Import-Module -Name Pester -RequiredVersion $pesterModule.Version -Force
|
||||
|
||||
$config = New-PesterConfiguration
|
||||
$config.Run.Path = $pesterTestDir
|
||||
$config.Filter.ExcludeTag = @('Integration')
|
||||
$config.Filter.ExcludeTag = @('Integration', 'MockIntegration')
|
||||
$config.Output.Verbosity = 'Detailed'
|
||||
$config.Run.PassThru = $true
|
||||
|
||||
@@ -210,7 +313,7 @@ function Invoke-PesterIntegrationTests {
|
||||
throw 'Pester module is not installed. Run: Install-Module Pester -Force'
|
||||
}
|
||||
|
||||
Import-Module $pesterModule.ModuleBase -Force
|
||||
Import-Module -Name Pester -RequiredVersion $pesterModule.Version -Force
|
||||
|
||||
$config = New-PesterConfiguration
|
||||
$config.Run.Path = $integrationDir
|
||||
@@ -272,7 +375,7 @@ foreach ($suite in $results.Keys) {
|
||||
|
||||
if ($color -eq 'Red') { $anyFailure = $true }
|
||||
|
||||
Write-Host (' {0,-30} {1}' -f "$suite:", $status) -ForegroundColor $color
|
||||
Write-Host (' {0,-30} {1}' -f "${suite}:", $status) -ForegroundColor $color
|
||||
}
|
||||
|
||||
Write-Host ''
|
||||
|
||||
Reference in New Issue
Block a user