gsadmin/PSProxmoxVE
1
0
Fork 0
mirror of https://github.com/GoodOlClint/PSProxmoxVE.git synced 2026-08-31 17:28:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve net48-only nullable warnings (CS8601, CS8602, CS8604)

Browse Source 
- CS8601: Add null-forgiving operator on guarded dictionary assignments
  in cmdlets where IsNullOrEmpty check precedes the assignment
- CS8602: Add Assert.NotNull after JObject["data"] in xUnit model tests
  (JToken indexer returns nullable on net48)
- CS8604: Add null-forgiving on guarded arguments in NodeService,
  WaitPveTaskCmdlet, GetPveTemplateCmdlet, and auth test parameters

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clint Branham
2026-03-19 08:32:57 -05:00
parent 3075c12768
commit d187b0de52
26 changed files with 165 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PSProxmoxVE.Core.Tests/Models/TaskModelTests.cs
+8
View File
@@ -11,6 +11,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("UPID:pve1:00001234:00ABCDEF:65F00000:qmstart:100:root@pam:", task.Upid);
@@ -21,6 +22,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("stopped", task.Status);
@@ -31,6 +33,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("OK", task.ExitStatus);
@@ -41,6 +44,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_tasks.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.True(task.IsSuccessful);
@@ -51,6 +55,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("UPID:pve1:00001234:00ABCDEF:65F00000:qmstart:100:root@pam:", task.Upid);
@@ -61,6 +66,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Equal("running", task.Status);
@@ -71,6 +77,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.Null(task.ExitStatus);
@@ -81,6 +88,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_task_running.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var task = data.ToObject<PveTask>();
Assert.NotNull(task);
Assert.False(task.IsSuccessful);