gsadmin/PSProxmoxVE
1
0
Fork 0
mirror of https://github.com/GoodOlClint/PSProxmoxVE.git synced 2026-08-28 07:56:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve net48-only nullable warnings (CS8601, CS8602, CS8604)

Browse Source 
- CS8601: Add null-forgiving operator on guarded dictionary assignments
  in cmdlets where IsNullOrEmpty check precedes the assignment
- CS8602: Add Assert.NotNull after JObject["data"] in xUnit model tests
  (JToken indexer returns nullable on net48)
- CS8604: Add null-forgiving on guarded arguments in NodeService,
  WaitPveTaskCmdlet, GetPveTemplateCmdlet, and auth test parameters

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clint Branham
2026-03-19 08:32:57 -05:00
parent 3075c12768
commit d187b0de52
26 changed files with 165 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PSProxmoxVE.Core.Tests/Models/NodeModelTests.cs
+8
View File
@@ -11,6 +11,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_nodes.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var nodes = data.ToObject<PveNode[]>();
Assert.NotNull(nodes);
Assert.Equal(2, nodes.Length);
@@ -25,6 +26,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_nodes.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var nodes = data.ToObject<PveNode[]>();
Assert.NotNull(nodes);
Assert.Equal("pve2", nodes[1].Name);
@@ -38,6 +40,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve8_nodes.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var nodes = data.ToObject<PveNode[]>();
Assert.NotNull(nodes);
Assert.Single(nodes);
@@ -49,6 +52,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve8_nodes.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var nodes = data.ToObject<PveNode[]>();
Assert.NotNull(nodes);
Assert.Equal(4, nodes[0].CpuCount);
@@ -60,6 +64,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_node_status.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var status = data.ToObject<PveNodeStatus>();
Assert.NotNull(status);
Assert.Equal(0.125, status.CpuUsage);
@@ -70,6 +75,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_node_status.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var status = data.ToObject<PveNodeStatus>();
Assert.NotNull(status);
Assert.Equal("pve1", status.Node);
@@ -83,6 +89,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_node_status.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var status = data.ToObject<PveNodeStatus>();
Assert.NotNull(status);
Assert.NotNull(status.MemoryUsage);
@@ -95,6 +102,7 @@ namespace PSProxmoxVE.Core.Tests.Models
{
var json = TestHelper.LoadFixture("pve9_nodes.json");
var data = JObject.Parse(json)["data"];
Assert.NotNull(data);
var nodes = data.ToObject<PveNode[]>();
Assert.NotNull(nodes);
Assert.NotNull(nodes[0].LoadAverage);