gsadmin/PSProxmoxVE
1
0
Fork 0
mirror of https://github.com/GoodOlClint/PSProxmoxVE.git synced 2026-07-26 07:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): move PVE_TARGET_NODE from secret to variable

Browse Source 
The node name "pve" was being masked in all CI logs because GitHub
Actions auto-masks secret values. Since the node name is not sensitive,
use vars.PVE_TARGET_NODE instead of secrets.PVE_TARGET_NODE.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clint Branham
2026-03-24 09:49:21 -05:00
parent cddb3ef71a
commit c1e1442155
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/integration-tests.yml
+5 -3
View File
@@ -16,9 +16,11 @@ name: Integration Tests
# Required repository secrets (for provisioning): # Required repository secrets (for provisioning):
# PVE_ENDPOINT - Parent PVE API URL (e.g. https://pve.example.com:8006) # PVE_ENDPOINT - Parent PVE API URL (e.g. https://pve.example.com:8006)
# PVE_API_TOKEN - Parent PVE API token (for Terraform + uploads) # PVE_API_TOKEN - Parent PVE API token (for Terraform + uploads)
# PVE_TARGET_NODE - Parent PVE node name
# PVE_TEST_PASSWORD - Root password for nested PVE instances # PVE_TEST_PASSWORD - Root password for nested PVE instances
# #
# Required repository variables:
# PVE_TARGET_NODE - Parent PVE node name (variable, not secret, to avoid log masking)
#
# Optional secrets (for skip_provision mode): # Optional secrets (for skip_provision mode):
# PVETEST_HOST - Hostname or IP of a pre-existing nested PVE # PVETEST_HOST - Hostname or IP of a pre-existing nested PVE
# PVETEST_APITOKEN - API token for the pre-existing nested PVE # PVETEST_APITOKEN - API token for the pre-existing nested PVE
@@ -121,7 +123,7 @@ jobs:
env: env:
PVE_ENDPOINT: ${{ secrets.PVE_ENDPOINT }} PVE_ENDPOINT: ${{ secrets.PVE_ENDPOINT }}
PVE_API_TOKEN: ${{ secrets.PVE_API_TOKEN }} PVE_API_TOKEN: ${{ secrets.PVE_API_TOKEN }}
PVE_TARGET_NODE: ${{ secrets.PVE_TARGET_NODE }} PVE_TARGET_NODE: ${{ vars.PVE_TARGET_NODE }}
PVE_PASSWORD: ${{ secrets.PVE_TEST_PASSWORD }} PVE_PASSWORD: ${{ secrets.PVE_TEST_PASSWORD }}
run: bash ${SCRIPTS_DIR}/run-integration.sh provision run: bash ${SCRIPTS_DIR}/run-integration.sh provision
@@ -191,7 +193,7 @@ jobs:
env: env:
PVE_ENDPOINT: ${{ secrets.PVE_ENDPOINT }} PVE_ENDPOINT: ${{ secrets.PVE_ENDPOINT }}
PVE_API_TOKEN: ${{ secrets.PVE_API_TOKEN }} PVE_API_TOKEN: ${{ secrets.PVE_API_TOKEN }}
PVE_TARGET_NODE: ${{ secrets.PVE_TARGET_NODE }} PVE_TARGET_NODE: ${{ vars.PVE_TARGET_NODE }}
run: bash ${SCRIPTS_DIR}/run-integration.sh cleanup run: bash ${SCRIPTS_DIR}/run-integration.sh cleanup
# ── Clean up old container images from GHCR ────────────────────────── # ── Clean up old container images from GHCR ──────────────────────────