From c0a37d5ef3253b0e16519f8edaba6936c5539884 Mon Sep 17 00:00:00 2001
From: Clint Branham <goodolclint@gmail.com>
Date: Tue, 24 Mar 2026 18:18:56 -0500
Subject: [PATCH] fix: resolve F039 bare catches and F084 session secret
 exposure

F039 (regressed): Replace bare catch blocks with filtered catches that
exclude OutOfMemoryException and StackOverflowException, per D004.
- VmService.PingGuestAgent: catch now filters fatal exceptions
- ImportPveOvaCmdlet: catch now filters fatal exceptions + WriteVerbose

F084 (new): Add PveSession format view to PSProxmoxVE.format.ps1xml
that shows only Hostname, Port, AuthMode, IsExpired, and ServerVersion
in default table output. Sensitive properties (Ticket, ApiToken,
CsrfToken) are hidden from default display but remain accessible
via Select-Object * or direct property access.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 src/PSProxmoxVE.Core/Services/VmService.cs    |  2 +-
 .../Cmdlets/Vms/ImportPveOvaCmdlet.cs         |  3 +-
 src/PSProxmoxVE/PSProxmoxVE.format.ps1xml     | 59 +++++++++++++++++++
 3 files changed, 62 insertions(+), 2 deletions(-)

diff --git a/src/PSProxmoxVE.Core/Services/VmService.cs b/src/PSProxmoxVE.Core/Services/VmService.cs
index ff6a47e..412e1ab 100644
--- a/src/PSProxmoxVE.Core/Services/VmService.cs
+++ b/src/PSProxmoxVE.Core/Services/VmService.cs
@@ -550,7 +550,7 @@ namespace PSProxmoxVE.Core.Services
                 client.PostAsync($"nodes/{Uri.EscapeDataString(node)}/qemu/{vmid}/agent/ping").GetAwaiter().GetResult();
                 return true;
             }
-            catch
+            catch (Exception ex) when (ex is not OutOfMemoryException and not StackOverflowException)
             {
                 return false;
             }
diff --git a/src/PSProxmoxVE/Cmdlets/Vms/ImportPveOvaCmdlet.cs b/src/PSProxmoxVE/Cmdlets/Vms/ImportPveOvaCmdlet.cs
index a834c66..dd00cee 100644
--- a/src/PSProxmoxVE/Cmdlets/Vms/ImportPveOvaCmdlet.cs
+++ b/src/PSProxmoxVE/Cmdlets/Vms/ImportPveOvaCmdlet.cs
@@ -274,9 +274,10 @@ namespace PSProxmoxVE.Cmdlets.Vms
                 var vm = vmService.GetVm(session, Node, vmId);
                 WriteObject(vm);
             }
-            catch
+            catch (Exception ex) when (ex is not OutOfMemoryException and not StackOverflowException)
             {
                 // If the VM isn't queryable yet (e.g. disk import still running), return basic info
+                WriteVerbose($"VM retrieval failed, returning basic info: {ex.Message}");
                 WriteObject(new PveVm
                 {
                     VmId = vmId,
diff --git a/src/PSProxmoxVE/PSProxmoxVE.format.ps1xml b/src/PSProxmoxVE/PSProxmoxVE.format.ps1xml
index 39d60c8..9cbb8a5 100644
--- a/src/PSProxmoxVE/PSProxmoxVE.format.ps1xml
+++ b/src/PSProxmoxVE/PSProxmoxVE.format.ps1xml
@@ -1356,5 +1356,64 @@
       </TableControl>
     </View>
 
+    <!-- PSProxmoxVE.Core.Authentication.PveSession -->
+    <!-- Hides sensitive properties (Ticket, ApiToken, CsrfToken) from default output -->
+    <View>
+      <Name>PSProxmoxVE.Core.Authentication.PveSession</Name>
+      <ViewSelectedBy>
+        <TypeName>PSProxmoxVE.Core.Authentication.PveSession</TypeName>
+      </ViewSelectedBy>
+      <TableControl>
+        <TableHeaders>
+          <TableColumnHeader>
+            <Label>Hostname</Label>
+            <Width>25</Width>
+            <Alignment>Left</Alignment>
+          </TableColumnHeader>
+          <TableColumnHeader>
+            <Label>Port</Label>
+            <Width>6</Width>
+            <Alignment>Right</Alignment>
+          </TableColumnHeader>
+          <TableColumnHeader>
+            <Label>AuthMode</Label>
+            <Width>10</Width>
+            <Alignment>Left</Alignment>
+          </TableColumnHeader>
+          <TableColumnHeader>
+            <Label>Expired</Label>
+            <Width>8</Width>
+            <Alignment>Left</Alignment>
+          </TableColumnHeader>
+          <TableColumnHeader>
+            <Label>Version</Label>
+            <Width>15</Width>
+            <Alignment>Left</Alignment>
+          </TableColumnHeader>
+        </TableHeaders>
+        <TableRowEntries>
+          <TableRowEntry>
+            <TableColumnItems>
+              <TableColumnItem>
+                <PropertyName>Hostname</PropertyName>
+              </TableColumnItem>
+              <TableColumnItem>
+                <PropertyName>Port</PropertyName>
+              </TableColumnItem>
+              <TableColumnItem>
+                <PropertyName>AuthMode</PropertyName>
+              </TableColumnItem>
+              <TableColumnItem>
+                <ScriptBlock>if ($_.IsExpired) { 'Yes' } else { 'No' }</ScriptBlock>
+              </TableColumnItem>
+              <TableColumnItem>
+                <ScriptBlock>if ($_.ServerVersion) { $_.ServerVersion.ToString() } else { 'Unknown' }</ScriptBlock>
+              </TableColumnItem>
+            </TableColumnItems>
+          </TableRowEntry>
+        </TableRowEntries>
+      </TableControl>
+    </View>
+
   </ViewDefinitions>
 </Configuration>