mirror of
https://github.com/GoodOlClint/PSProxmoxVE.git
synced 2026-08-31 09:18:19 +00:00
Merge branch 'main' into dependabot/nuget/tests/PSProxmoxVE.Core.Tests/main/Microsoft.NET.Test.Sdk-18.4.0
This commit is contained in:
@@ -26,6 +26,31 @@ jobs:
|
|||||||
with:
|
with:
|
||||||
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
||||||
allowed_bots: 'dependabot[bot]'
|
allowed_bots: 'dependabot[bot]'
|
||||||
plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
|
track_progress: true
|
||||||
plugins: 'code-review@claude-code-plugins'
|
prompt: |
|
||||||
prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
|
REPO: ${{ github.repository }}
|
||||||
|
PR NUMBER: ${{ github.event.pull_request.number }}
|
||||||
|
|
||||||
|
Review this pull request for the PSProxmoxVE PowerShell module.
|
||||||
|
|
||||||
|
Focus areas:
|
||||||
|
1. **DECISIONS.md compliance** — Check against the 13 architectural
|
||||||
|
decisions (D001-D013). Any violation is a regression.
|
||||||
|
2. **Code quality** — Cmdlet conventions (sealed, OutputType,
|
||||||
|
ConfirmImpact.High for destructive, VmId ValidateRange),
|
||||||
|
SecureString for passwords, Uri.EscapeDataString on path params,
|
||||||
|
no bare catch blocks, Newtonsoft-only JSON.
|
||||||
|
3. **API correctness** — Parameter names and enum values must match
|
||||||
|
the PVE OpenAPI spec (see tests/PSProxmoxVE.Core.Tests/Fixtures/
|
||||||
|
pve-api-enums.pve*.json for valid values per PVE version).
|
||||||
|
4. **Tests** — New cmdlets should have xUnit service tests and
|
||||||
|
Pester parameter-validation tests.
|
||||||
|
5. **Security** — No hardcoded credentials, no secrets in logs,
|
||||||
|
TLS verification on by default.
|
||||||
|
|
||||||
|
Provide inline comments for specific issues and a summary comment
|
||||||
|
for general observations. Skip nitpicks unless they indicate a
|
||||||
|
real problem.
|
||||||
|
|
||||||
|
claude_args: |
|
||||||
|
--allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)"
|
||||||
|
|||||||
@@ -108,6 +108,6 @@ jobs:
|
|||||||
Publish-Module -Path ./publish/PSProxmoxVE -NuGetApiKey $env:NUGET_API_KEY -Verbose
|
Publish-Module -Path ./publish/PSProxmoxVE -NuGetApiKey $env:NUGET_API_KEY -Verbose
|
||||||
|
|
||||||
- name: Create GitHub Release
|
- name: Create GitHub Release
|
||||||
uses: softprops/action-gh-release@v2
|
uses: softprops/action-gh-release@v3
|
||||||
with:
|
with:
|
||||||
generate_release_notes: true
|
generate_release_notes: true
|
||||||
|
|||||||
@@ -18,7 +18,7 @@
|
|||||||
|
|
||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
|
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
|
||||||
<PackageReference Include="SharpCompress" Version="0.47.3" />
|
<PackageReference Include="SharpCompress" Version="0.47.4" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
|
||||||
</Project>
|
</Project>
|
||||||
|
|||||||
Reference in New Issue
Block a user