fix: address Copilot review — validation, error handling, MAC case

- Add ValidateSet('8','9','all') to dev.ps1 -Version parameter
- Fix Shell warning to reference $DevContainer not $InfraContainer
- Fix Skip-IfNoNodeB to check $PasswordB not $Password
- Pass PVE_TARGET_NODE to wait-for-pve.sh instead of auto-discovering
- Add error default cases to all pve_* helper functions
- Lowercase MAC addresses for answer server matching
- Create answer file paths before terraform destroy in cleanup

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clint Branham
2026-03-25 15:50:07 -05:00
parent 7cb64811b7
commit 7ffc57e16f
4 changed files with 21 additions and 14 deletions
+2 -1
View File
@@ -103,6 +103,7 @@ param(
[string[]] $Tests,
[Alias('PveVersion')]
[ValidateSet('8', '9', 'all')]
[string] $Version = 'all',
[string] $DockerHost,
@@ -214,7 +215,7 @@ if ($Rebuild) {
if ($Shell) {
if ($DockerHost) {
Write-Warning "Interactive shell over remote Docker is not supported. Use: ssh $DockerHost 'docker exec -it $InfraContainer pwsh -NoProfile'"
Write-Warning "Interactive shell over remote Docker is not supported. Use: ssh $DockerHost 'docker exec -it $DevContainer pwsh -NoProfile'"
return
}
Start-DevContainer