gsadmin/PSProxmoxVE
1
0
Fork 0
mirror of https://github.com/GoodOlClint/PSProxmoxVE.git synced 2026-08-27 23:47:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): fix integration test failures for SDN, containers, OVA, suspend

Browse Source 
- SDN: zone ID cannot contain hyphens — rename 'pester-zone' to 'pesterz'
- SDN: subnet removal uses original CIDR, not transformed ID
- Containers: New-PveContainer now auto-assigns VM ID via /cluster/nextid
  when -VmId is omitted (was missing, unlike New-PveVm)
- OVA: enable 'images' content type on local storage for import-from
- Suspend: add delay before status check, use Should -Not -Throw pattern

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Clint Branham
2026-03-20 14:35:53 -05:00
parent 1c4c112565
commit 531deafdb7
3 changed files with 26 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PSProxmoxVE.Tests/Integration/Integration.Tests.ps1
+13 -11
View File
@@ -464,17 +464,19 @@ Describe 'Integration Tests' -Tag 'Integration' {
# Start the VM
Start-PveVm -Node $script:Node -VmId $script:TestVmId -Wait | Out-Null
# Suspend
$suspendTask = Suspend-PveVm -Node $script:Node -VmId $script:TestVmId -Wait
$suspendTask | Should -Not -BeNullOrEmpty
# Suspend — sends QMP stop to QEMU
{ Suspend-PveVm -Node $script:Node -VmId $script:TestVmId -Wait -ErrorAction Stop } |
Should -Not -Throw
Start-Sleep -Seconds 3
$vm = Get-PveVm -Node $script:Node | Where-Object { $_.VmId -eq $script:TestVmId }
$vm.Status | Should -Be 'paused'
# Resume
$resumeTask = Resume-PveVm -Node $script:Node -VmId $script:TestVmId -Wait
$resumeTask | Should -Not -BeNullOrEmpty
# Resume — sends QMP cont to QEMU
{ Resume-PveVm -Node $script:Node -VmId $script:TestVmId -Wait -ErrorAction Stop } |
Should -Not -Throw
Start-Sleep -Seconds 2
$vm = Get-PveVm -Node $script:Node | Where-Object { $_.VmId -eq $script:TestVmId }
$vm.Status | Should -Be 'running'
@@ -742,7 +744,7 @@ Describe 'Integration Tests' -Tag 'Integration' {
if (Skip-IfNoTarget) { return }
if ($script:SkipSdn) { Set-ItResult -Skipped -Because $script:SkipSdn; return }
{ New-PveSdnZone -Zone 'pester-zone' -Type 'simple' -ErrorAction Stop } |
{ New-PveSdnZone -Zone 'pesterz' -Type 'simple' -ErrorAction Stop } |
Should -Not -Throw
}
@@ -752,7 +754,7 @@ Describe 'Integration Tests' -Tag 'Integration' {
$zones = Get-PveSdnZone
$zones | Should -Not -BeNullOrEmpty
$zones | Where-Object { $_.Zone -eq 'pester-zone' } |
$zones | Where-Object { $_.Zone -eq 'pesterz' } |
Should -Not -BeNullOrEmpty
}
@@ -760,7 +762,7 @@ Describe 'Integration Tests' -Tag 'Integration' {
if (Skip-IfNoTarget) { return }
if ($script:SkipSdn) { Set-ItResult -Skipped -Because $script:SkipSdn; return }
{ New-PveSdnVnet -Vnet 'pestervn' -Zone 'pester-zone' -ErrorAction Stop } |
{ New-PveSdnVnet -Vnet 'pestervn' -Zone 'pesterz' -ErrorAction Stop } |
Should -Not -Throw
}
@@ -794,7 +796,7 @@ Describe 'Integration Tests' -Tag 'Integration' {
if (Skip-IfNoTarget) { return }
if ($script:SkipSdn) { Set-ItResult -Skipped -Because $script:SkipSdn; return }
{ Remove-PveSdnSubnet -Vnet 'pestervn' -Subnet 'pestervn-10.99.0.0-24' `
{ Remove-PveSdnSubnet -Vnet 'pestervn' -Subnet '10.99.0.0/24' `
-Confirm:$false -ErrorAction Stop } | Should -Not -Throw
}
@@ -810,7 +812,7 @@ Describe 'Integration Tests' -Tag 'Integration' {
if (Skip-IfNoTarget) { return }
if ($script:SkipSdn) { Set-ItResult -Skipped -Because $script:SkipSdn; return }
{ Remove-PveSdnZone -Zone 'pester-zone' -Confirm:$false -ErrorAction Stop } |
{ Remove-PveSdnZone -Zone 'pesterz' -Confirm:$false -ErrorAction Stop } |
Should -Not -Throw
}
}
tests/infrastructure/scripts/prepare-test-environment.sh
+1 -1
View File
@@ -30,7 +30,7 @@ echo "=== Preparing test environment on ${NESTED_IP} ==="
# Enable snippets and import content types on local storage
echo "Configuring local storage content types..."
${SSH_CMD} "mkdir -p /var/lib/vz/snippets && pvesm set local --content iso,vztmpl,snippets,import"
${SSH_CMD} "mkdir -p /var/lib/vz/snippets && pvesm set local --content images,iso,vztmpl,snippets,import"
# Upload cloud-init user-data snippet (no API for snippet upload)
echo "Uploading cloud-init user-data snippet..."