From 4cc4e86cfb749de3e5c763628fb283aa7b6a3275 Mon Sep 17 00:00:00 2001
From: "goodolclint-claude[bot]"
 <323206664+goodolclint-claude[bot]@users.noreply.github.com>
Date: Wed, 2 Sep 2026 13:20:57 -0500
Subject: [PATCH] ci: read the release tag from the environment, and refuse
 tags that are not a version (#159)

The tag name was substituted into the pwsh script text by expression, so a
tag containing a quote could run arbitrary PowerShell in the job that holds
NUGET_API_KEY. The script now reads it from an env var and rejects anything
that is not vX.Y.Z with an optional prerelease suffix.

Co-authored-by: goodolclint-claude[bot] <323206664+goodolclint-claude[bot]@users.noreply.github.com>
---
 .github/workflows/publish.yml | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index fa024e4..d75f673 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -72,17 +72,19 @@ jobs:
           name: module-netstandard2.0
           path: ./publish/PSProxmoxVE/
 
-      - name: Extract version from tag
-        id: version
-        run: echo "version=${GITHUB_REF_NAME#v}" >> "$GITHUB_OUTPUT"
-
+      # The tag name reaches the script through the environment, never through
+      # expression substitution into the script text. A tag is free-form and
+      # this job holds NUGET_API_KEY.
       - name: Update module version in manifest
         shell: pwsh
+        env:
+          TAG: ${{ github.ref_name }}
         run: |
+          if ($env:TAG -notmatch '^v(\d+\.\d+\.\d+)(-[0-9A-Za-z.-]+)?$') {
+            throw "Tag '$env:TAG' is not vX.Y.Z or vX.Y.Z-prerelease"
+          }
           $manifestPath = './publish/PSProxmoxVE/PSProxmoxVE.psd1'
-          $version = '${{ steps.version.outputs.version }}'
-          # Strip prerelease suffix for ModuleVersion (must be X.Y.Z)
-          $moduleVersion = ($version -split '-')[0]
+          $moduleVersion = $Matches[1]
           $content = Get-Content $manifestPath -Raw
           $content = $content -replace "ModuleVersion\s*=\s*'[^']*'", "ModuleVersion     = '$moduleVersion'"
           Set-Content $manifestPath $content