From 339ffaf0bdfb201d4b7c3e64fb3ad26f2b73cd85 Mon Sep 17 00:00:00 2001 From: Clint Branham Date: Mon, 23 Mar 2026 15:02:04 -0500 Subject: [PATCH] fix(ci): remove net48 build target from unit-tests, skip integration for dependabot unit-tests.yml: The publishable project targets netstandard2.0 only (D009/F047), so the net48 build matrix entry fails. PS 5.1 loads netstandard2.0 assemblies on .NET Framework 4.8, so the PS 5.1 Pester tests now use the netstandard2.0 artifact. integration-tests.yml: Skip entire workflow for dependabot PRs since integration tests on the self-hosted runner are expensive and dependency bumps don't warrant full end-to-end testing. Also updates dotnet SDK from 9.0.x to 10.0.x for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/integration-tests.yml | 4 +++- .github/workflows/unit-tests.yml | 4 +--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index a35d8c1..6f95fca 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -24,6 +24,7 @@ on: branches: [ main ] pull_request: branches: [ main ] + types: [ opened, synchronize, reopened ] workflow_dispatch: inputs: skip_provision: @@ -45,6 +46,7 @@ env: jobs: # ── Build module artifact (GitHub-hosted) ──────────────────────────── build: + if: github.actor != 'dependabot[bot]' runs-on: ubuntu-latest timeout-minutes: 10 steps: @@ -53,7 +55,7 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v5 with: - dotnet-version: '9.0.x' + dotnet-version: '10.0.x' - name: Build module run: dotnet publish src/PSProxmoxVE/PSProxmoxVE.csproj --configuration Release --framework netstandard2.0 --output ./publish/netstandard2.0 diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index a7faf3b..a66aa57 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -15,8 +15,6 @@ jobs: fail-fast: false matrix: include: - - os: windows-latest - framework: net48 - os: windows-latest framework: netstandard2.0 - os: ubuntu-latest @@ -53,7 +51,7 @@ jobs: include: - os: windows-latest ps_version: '5.1' - framework: net48 + framework: netstandard2.0 artifact_os: windows-latest shell: powershell - os: windows-latest