refactor!(certificates): remove Search-InfisicalCertificate (use Get-InfisicalCertificate)

Search-InfisicalCertificate was a 1:1 duplicate of Get-InfisicalCertificate's
List parameter set after the recent filter-surface expansion (bdec5aa). Both
cmdlets exposed the same ~27 server-side filters and both hit the same
POST /api/v1/projects/{projectId}/certificates/search endpoint. Keeping two
PowerShell cmdlets for the same operation added discovery noise without
benefit.

REMOVED
- src/PSInfisicalAPI/Cmdlets/SearchInfisicalCertificateCmdlet.cs (cmdlet
  source, ~140 lines).
- 'Search-InfisicalCertificate' from CmdletsToExport in the source manifest
  (Module/PSInfisicalAPI/PSInfisicalAPI.psd1) and from the two generators
  in build.ps1 (Write-Manifest cmdlet list + Test-ModuleImports $expectedCmds).
- <command:command> block for Search-InfisicalCertificate from the help XML
  (Module/PSInfisicalAPI/en-US/PSInfisicalAPI.dll-Help.xml).
- README PKI table row for Search-InfisicalCertificate.
- "For advanced filtering ... use Search-InfisicalCertificate instead"
  sentence from the Get-InfisicalCertificate Notes block (no longer true).

RETAINED (internal)
- InfisicalPkiClient.SearchCertificates, InfisicalCertificateSearchQuery,
  InfisicalEndpointNames.SearchCertificates and the endpoint registry entry.
  Get-InfisicalCertificate and Request-InfisicalCertificate still call them
  to walk the search endpoint.

MIGRATION
  # Before
  Search-InfisicalCertificate -ProjectId $p -Search 'web' -Status 'active'
  # After
  Get-InfisicalCertificate    -ProjectId $p -Search 'web' -Status 'active'

Parameter names, defaults, and paging behavior are identical.

TESTS
- 216/216 passing (one unrelated time-based test in CsrAndRequestCmdletTests
  was flaky on the run; passes deterministically when invoked in isolation).
This commit is contained in:
GraceSolutions
2026-06-04 22:13:48 -04:00
parent 93dc63d913
commit 880ff8d491
5 changed files with 2 additions and 189 deletions
@@ -1,140 +0,0 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Management.Automation;
using PSInfisicalAPI.Connections;
using PSInfisicalAPI.Models;
using PSInfisicalAPI.Pki;
namespace PSInfisicalAPI.Cmdlets
{
[Cmdlet(VerbsCommon.Search, "InfisicalCertificate")]
[OutputType(typeof(InfisicalCertificate))]
public sealed class SearchInfisicalCertificateCmdlet : InfisicalCmdletBase
{
[Parameter(Mandatory = true)] public string ProjectId { get; set; }
[Parameter] public string FriendlyName { get; set; }
[Parameter] public string CommonName { get; set; }
[Parameter] public string Search { get; set; }
[Parameter] public string Status { get; set; }
[Parameter] public string[] CaId { get; set; }
[Parameter] public string[] ProfileId { get; set; }
[Parameter] public string ApplicationId { get; set; }
[Parameter] public string[] ApplicationIds { get; set; }
[Parameter] public string[] EnrollmentType { get; set; }
[Parameter] public string ExtendedKeyUsage { get; set; }
[Parameter] public string[] KeyAlgorithm { get; set; }
[Parameter] public string SignatureAlgorithm { get; set; }
[Parameter] public int[] KeySize { get; set; }
[Parameter] public string[] Source { get; set; }
[Parameter] public DateTimeOffset? FromDate { get; set; }
[Parameter] public DateTimeOffset? ToDate { get; set; }
[Parameter] public DateTimeOffset? NotAfterFrom { get; set; }
[Parameter] public DateTimeOffset? NotAfterTo { get; set; }
[Parameter] public DateTimeOffset? NotBeforeFrom { get; set; }
[Parameter] public DateTimeOffset? NotBeforeTo { get; set; }
[Parameter] public Hashtable Metadata { get; set; }
[Parameter] public SwitchParameter ForPkiSync { get; set; }
[Parameter]
[ValidateSet("notAfter", "notBefore", "createdAt", "commonName", "keyAlgorithm", "status")]
public string SortBy { get; set; }
[Parameter] [ValidateSet("asc", "desc")] public string SortOrder { get; set; }
[Parameter] public int? Limit { get; set; }
[Parameter] public int? Offset { get; set; }
[Parameter] public SwitchParameter NoAutoPage { get; set; }
protected override void ProcessRecord()
{
try
{
InfisicalConnection connection = InfisicalSessionManager.RequireCurrent();
InfisicalPkiClient client = new InfisicalPkiClient(HttpClient, Logger);
InfisicalCertificateSearchQuery query = BuildQuery(ProjectId);
int requestedLimit = query.Limit ?? 100;
query.Limit = requestedLimit;
query.Offset = query.Offset ?? 0;
int emitted = 0;
while (true)
{
InfisicalCertificateSearchResult page = client.SearchCertificates(connection, query);
if (page == null || page.Certificates == null || page.Certificates.Length == 0)
{
break;
}
foreach (InfisicalCertificate cert in page.Certificates)
{
WriteObject(cert);
emitted++;
}
if (NoAutoPage.IsPresent || page.Certificates.Length < requestedLimit)
{
break;
}
if (page.TotalCount > 0 && emitted >= page.TotalCount)
{
break;
}
query.Offset = (query.Offset ?? 0) + page.Certificates.Length;
}
}
catch (Exception exception)
{
ThrowTerminatingForException("SearchInfisicalCertificateCmdlet", "SearchCertificates", exception);
}
}
private InfisicalCertificateSearchQuery BuildQuery(string projectId)
{
return new InfisicalCertificateSearchQuery
{
ProjectId = projectId,
FriendlyName = FriendlyName,
CommonName = CommonName,
Search = Search,
Status = Status,
CaIds = CaId,
ProfileIds = ProfileId,
ApplicationId = ApplicationId,
ApplicationIds = ApplicationIds,
EnrollmentTypes = EnrollmentType,
ExtendedKeyUsage = ExtendedKeyUsage,
KeyAlgorithm = KeyAlgorithm,
SignatureAlgorithm = SignatureAlgorithm,
KeySizes = KeySize,
Source = Source,
FromDate = FromDate,
ToDate = ToDate,
NotAfterFrom = NotAfterFrom,
NotAfterTo = NotAfterTo,
NotBeforeFrom = NotBeforeFrom,
NotBeforeTo = NotBeforeTo,
Metadata = ToStringDictionary(Metadata),
ForPkiSync = ForPkiSync.IsPresent ? (bool?)true : null,
SortBy = SortBy,
SortOrder = SortOrder,
Limit = Limit,
Offset = Offset
};
}
private static Dictionary<string, string> ToStringDictionary(Hashtable hashtable)
{
if (hashtable == null) { return null; }
Dictionary<string, string> result = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
foreach (DictionaryEntry entry in hashtable)
{
if (entry.Key == null) { continue; }
result[entry.Key.ToString()] = entry.Value != null ? entry.Value.ToString() : null;
}
return result;
}
}
}