refactor!(cmdlets): drop vestigial -List switch from Get-* cmdlets
The -List switch was a no-op marker on the default parameter set of six Get-* cmdlets. Each cmdlet was declared with DefaultParameterSetName = "List" and the -List switch was the only parameter unique to that set, so it served no purpose beyond visual decoration: omitting it already routed to List (because it was the default) and supplying it produced identical behavior. REMOVED -List from - Get-InfisicalCertificate - Get-InfisicalEnvironment - Get-InfisicalFolder - Get-InfisicalProject - Get-InfisicalSecret - Get-InfisicalTag UNCHANGED - DefaultParameterSetName = "List" remains on each cmdlet. - All other parameters on the List set (filters, ProjectId, etc.) remain on ParameterSetName = "List" and continue to disambiguate List vs Single. - The Single set still requires its keying parameter (-SerialNumber, -SecretName, -EnvironmentSlugOrId, -FolderNameOrId, -TagSlugOrId, -ProjectId on Get-InfisicalProject) to opt into single mode. BREAKING - Scripts that pass -List explicitly (e.g. `Get-InfisicalSecret -List ...`) must drop the switch. No other call shape changes. TESTS - PkiEndpointRegistryTests.GetInfisicalCertificate_Cmdlet_Exposes_List_Filter_Properties no longer asserts the presence of a "List" property. - 216/216 tests passing.
This commit is contained in:
@@ -86,7 +86,6 @@ namespace PSInfisicalAPI.Tests
|
||||
Assert.NotNull(cmdletType.GetProperty("Limit"));
|
||||
Assert.NotNull(cmdletType.GetProperty("Offset"));
|
||||
Assert.NotNull(cmdletType.GetProperty("NoAutoPage"));
|
||||
Assert.NotNull(cmdletType.GetProperty("List"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
|
||||
@@ -16,7 +16,6 @@ namespace PSInfisicalAPI.Cmdlets
|
||||
[Alias("Id", "Identifier")]
|
||||
public string SerialNumber { get; set; }
|
||||
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter List { get; set; }
|
||||
[Parameter(ParameterSetName = "List", Mandatory = true)] public string ProjectId { get; set; }
|
||||
[Parameter(ParameterSetName = "List")] public string CommonName { get; set; }
|
||||
[Parameter(ParameterSetName = "List")] public string FriendlyName { get; set; }
|
||||
|
||||
@@ -16,8 +16,6 @@ namespace PSInfisicalAPI.Cmdlets
|
||||
|
||||
[Parameter(Mandatory = true)] public string ProjectId { get; set; }
|
||||
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter List { get; set; }
|
||||
|
||||
protected override void ProcessRecord()
|
||||
{
|
||||
try
|
||||
|
||||
@@ -18,8 +18,6 @@ namespace PSInfisicalAPI.Cmdlets
|
||||
[Parameter(Mandatory = true)] public string Environment { get; set; }
|
||||
[Parameter] public string Path { get; set; }
|
||||
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter List { get; set; }
|
||||
|
||||
protected override void ProcessRecord()
|
||||
{
|
||||
try
|
||||
|
||||
@@ -14,8 +14,6 @@ namespace PSInfisicalAPI.Cmdlets
|
||||
[Alias("Id")]
|
||||
public string ProjectId { get; set; }
|
||||
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter List { get; set; }
|
||||
|
||||
[Parameter(ParameterSetName = "List")]
|
||||
[ValidateSet("secret-manager", "cert-manager", "kms", "ssh", "secret-scanning", "pam", "ai")]
|
||||
public string Type { get; set; }
|
||||
|
||||
@@ -26,7 +26,6 @@ namespace PSInfisicalAPI.Cmdlets
|
||||
[Parameter(ParameterSetName = "Single")] public int? Version { get; set; }
|
||||
[Parameter(ParameterSetName = "Single")] public InfisicalSecretType Type { get; set; } = InfisicalSecretType.Shared;
|
||||
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter List { get; set; }
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter Recursive { get; set; }
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter IncludePersonalOverrides { get; set; }
|
||||
[Parameter(ParameterSetName = "List")] public Hashtable MetadataFilter { get; set; }
|
||||
|
||||
@@ -16,8 +16,6 @@ namespace PSInfisicalAPI.Cmdlets
|
||||
|
||||
[Parameter(Mandatory = true)] public string ProjectId { get; set; }
|
||||
|
||||
[Parameter(ParameterSetName = "List")] public SwitchParameter List { get; set; }
|
||||
|
||||
protected override void ProcessRecord()
|
||||
{
|
||||
try
|
||||
|
||||
Reference in New Issue
Block a user