mirror of
https://github.com/Shik3i/KoalaSync.git
synced 2026-08-19 15:46:15 +00:00
KoalaDev
36e1291d2c
The weighted score summed incomparable units, so size could outvote traits that disqualify an element outright. Measured on a real page: a display:none preload reports its full 1080p intrinsic size and scored 2073600, beating a visible unmuted player at 509920. Selection now compares an ordered list of signals, highest priority first: has a source, is rendered, is not a silent background loop, rendered size bucket, is playing, has controls, duration. Rendered size replaces intrinsic resolution, and mute state is gone from the ranking entirely: it is a viewer preference, not evidence about which element is the player. It stays a ranking rather than a filter, so a page of only bad candidates still yields one and findVideo never returns null where a video exists. The new tests/e2e suite runs the shipped finder against real fixture pages and drives the packed extension for injection, reinjection and remote play/pause/seek into a first-party frame. All five scoring scenarios fail against the previous implementation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
12 lines
697 B
HTML
12 lines
697 B
HTML
<!doctype html>
|
|
<meta charset="utf-8">
|
|
<title>Two players, one playing</title>
|
|
<h1>Identical players, the second one is the one being watched</h1>
|
|
<!-- Same size, same asset, same mute state. Playback is the only signal that
|
|
tells the two apart, so a scorer that ignores it picks by DOM order. -->
|
|
<!-- The longer asset gives the watched player enough runway that it cannot
|
|
reach its end while the test is still looking at it. -->
|
|
<video id="idle" width="854" height="480" controls src="../media/player-1080p-30s.mp4"></video>
|
|
<video id="watched" data-expected width="854" height="480" controls data-autoplay src="../media/player-1080p-30s.mp4"></video>
|
|
<script src="ready.js"></script>
|