From e23f9ab226410106b93a4d7b352b25caadcc68fc Mon Sep 17 00:00:00 2001
From: KoalaDev <6156589+Shik3i@users.noreply.github.com>
Date: Sun, 28 Jun 2026 14:03:59 +0200
Subject: [PATCH] fix: wire up Regenerate Peer ID button + remove arbitrary
 MAX_CONTROLLERS cap
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Two pre-existing issues surfaced during audit follow-up:

1. popup.js bound elements.regenId but never attached a click handler —
   the 'Regenerate Peer ID' button has been dead UI since it was added
   (verified across full git history). Wired it up to send REGENERATE_ID;
   the background handler already did the right thing (rotate peerId,
   persist, force reconnect). The button is functional (regen ID on
   duplicate-identity errors), not privacy-theater — username is already
   user-changeable in settings, so it stays out of scope.

2. MAX_CONTROLLERS=10 was arbitrary. Payload math (25 controllers ×
   16-char IDs ≈ 500 bytes) is well under the 4KB maxHttpBufferSize,
   controllers.has() is O(1) on a Set, and 'just use everyone mode' is
   not a real answer when a host wants 12 controllers + 3 guests in a
   15-person room. Removed the cap entirely; the only real upper bound
   is MAX_PEERS_PER_ROOM (25).

Added TOAST_ID_REGENERATED to en.json — the i18n fallback merge
(Object.assign({}, enDict, targetDict)) covers the other 14 locales
automatically with English until they're translated.
---
 extension/locales/en.json |  1 +
 extension/popup.js        | 14 ++++++++++++++
 server/index.js           |  9 ---------
 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/extension/locales/en.json b/extension/locales/en.json
index 786dd15..416d6b4 100644
--- a/extension/locales/en.json
+++ b/extension/locales/en.json
@@ -109,6 +109,7 @@
   "BTN_REGEN_ID_TOOLTIP": "Regenerate your internal ID and reconnect",
   "REGEN_ID_DESC": "Use this if you see \"Duplicate Identity\" errors.",
   "REGEN_ID_OTHER_ISSUE": "Other issue? Open a GitHub Issue",
+  "TOAST_ID_REGENERATED": "Identity regenerated — reconnecting…",
   "LABEL_CONN_STATUS": "Connection Status",
   "LABEL_CONN_STATUS_TOOLTIP": "Current WebSocket connection state",
   "CONN_STATUS_DISCONNECTED": "Disconnected",
diff --git a/extension/popup.js b/extension/popup.js
index d1449f1..6a73613 100644
--- a/extension/popup.js
+++ b/extension/popup.js
@@ -1645,6 +1645,20 @@ elements.clearLogs.addEventListener('click', () => {
     });
 });
 
+if (elements.regenId) {
+    elements.regenId.addEventListener('click', () => {
+        elements.regenId.disabled = true;
+        chrome.runtime.sendMessage({ type: 'REGENERATE_ID' }, (res) => {
+            elements.regenId.disabled = false;
+            if (chrome.runtime.lastError || !res || !res.peerId) {
+                showToast(getMessage('TOAST_ID_REGENERATED') || 'Failed to regenerate identity', 'error');
+                return;
+            }
+            showToast(getMessage('TOAST_ID_REGENERATED') || 'Identity regenerated — reconnecting…', 'success', 3000);
+        });
+    });
+}
+
 elements.copyInvite.addEventListener('click', () => {
     navigator.clipboard.writeText(elements.inviteLink.value).then(() => {
         const original = elements.copyInvite.textContent;
diff --git a/server/index.js b/server/index.js
index 43d50b8..b3966e0 100644
--- a/server/index.js
+++ b/server/index.js
@@ -175,10 +175,6 @@ const SERVER_CAPABILITIES = [CAPABILITIES.HOST_CONTROL, CAPABILITIES.CO_HOST];
 // from generating one broadcast per toggle across all peers.
 const CONTROL_MODE_MIN_INTERVAL_MS = 500;
 
-// Co-Host: max peers (incl. the owner) allowed to drive a 'host-only' room. Bounds
-// the controller set + the CONTROL_MODE payload. Beyond this, just use 'everyone'.
-const MAX_CONTROLLERS = 10;
-
 // Canonical control-mode/role snapshot sent to clients. controllers always includes
 // the owner (hostPeerId). Built in one place so every emit stays consistent.
 function controlModePayload(room) {
@@ -748,11 +744,6 @@ io.on('connection', (socket) => {
 
         if (makeController) {
             if (room.controllers.has(targetPeerId)) return; // no-op
-            if (room.controllers.size >= MAX_CONTROLLERS) {
-                log('ROOM', `Controller cap (${MAX_CONTROLLERS}) reached in ${mapping.roomId.substring(0, 3)}***`);
-                socket.emit(EVENTS.CONTROL_MODE, controlModePayload(room)); // re-sync owner UI
-                return;
-            }
             room.controllers.add(targetPeerId);
         } else {
             if (!room.controllers.has(targetPeerId)) return; // no-op