gsadmin/KoalaSync
1
0
Fork 0
mirror of https://github.com/Shik3i/KoalaSync.git synced 2026-08-13 04:57:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(server): optimize failedAuthAttempts LRU eviction to O(1)

Browse Source
This commit is contained in:
Koala
2026-06-03 11:44:06 +02:00
parent b51e66d824
commit a6be6b2670
4 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/index.js
+10 -7
View File
@@ -149,17 +149,19 @@ function recordAuthFailure(ip, roomId) {
for (const [key, record] of failedAuthAttempts.entries()) {
if (now - record.lastAttempt > 15 * 60 * 1000) {
failedAuthAttempts.delete(key);
} else {
break; // Since entries are insertion-ordered by time, all subsequent entries are newer
}
}
// 2. If still over 50k, perform LRU-style eviction on the oldest 10,000 entries
// 2. If still over 50k, perform LRU-style eviction on the oldest 10,000 entries (first items in Map order)
if (failedAuthAttempts.size > 50000) {
log('SECURITY', 'failedAuthAttempts size exceeded 50000. Performing LRU-style eviction.');
const sortedEntries = Array.from(failedAuthAttempts.entries())
.sort((a, b) => a[1].lastAttempt - b[1].lastAttempt);
for (let i = 0; i < 10000 && i < sortedEntries.length; i++) {
failedAuthAttempts.delete(sortedEntries[i][0]);
log('SECURITY', 'failedAuthAttempts size exceeded 50000. Performing insertion-order eviction.');
for (const [key] of failedAuthAttempts.entries()) {
if (failedAuthAttempts.size <= 40000) {
break;
}
failedAuthAttempts.delete(key);
}
}
}
@@ -167,6 +169,7 @@ function recordAuthFailure(ip, roomId) {
const record = failedAuthAttempts.get(key) || { count: 0, lastAttempt: 0 };
record.count++;
record.lastAttempt = Date.now();
failedAuthAttempts.delete(key); // Remove first to update insertion order (moves key to the end of iteration)
failedAuthAttempts.set(key, record);
}