gsadmin/KoalaSync
1
0
Fork 0
mirror of https://github.com/Shik3i/KoalaSync.git synced 2026-08-28 11:37:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve duplicate peerList IDs and refine server deduplication emission

Browse Source
This commit is contained in:
Timo
2026-04-22 11:18:32 +02:00
parent 80f3801b79
commit 9a2ccd27ca
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extension/popup.html
+1 -1
View File
@@ -286,7 +286,7 @@
<div style="margin-bottom: 20px;"> <div style="margin-bottom: 20px;">
<label>Peers in Room</label> <label>Peers in Room</label>
<div id="peerList" class="info-card"> <div id="peerListSync" class="info-card">
<div style="text-align:center; color: var(--text-muted); font-size: 12px;">No peers connected</div> <div style="text-align:center; color: var(--text-muted); font-size: 12px;">No peers connected</div>
</div> </div>
</div> </div>
extension/popup.js
+10 -2
View File
@@ -41,6 +41,8 @@ const elements = {
sectionActive: document.getElementById('section-active'), sectionActive: document.getElementById('section-active'),
activeRoomId: document.getElementById('activeRoomId'), activeRoomId: document.getElementById('activeRoomId'),
activeServer: document.getElementById('activeServer'), activeServer: document.getElementById('activeServer'),
peerList: document.getElementById('peerList'),
peerListSync: document.getElementById('peerListSync'),
playBtn: document.getElementById('playBtn'), playBtn: document.getElementById('playBtn'),
pauseBtn: document.getElementById('pauseBtn') pauseBtn: document.getElementById('pauseBtn')
}; };
@@ -110,14 +112,14 @@ function updateUI(roomId, password, useCustomServer = false, serverUrl = '') {
} }
function updatePeerList(peers) { function updatePeerList(peers) {
if (!peers || !elements.peerList) return; if (!peers) return;
// UI Throttle: Only re-render if the peer state actually changed // UI Throttle: Only re-render if the peer state actually changed
const currentPeersJson = JSON.stringify(peers); const currentPeersJson = JSON.stringify(peers);
if (currentPeersJson === lastPeersJson) return; if (currentPeersJson === lastPeersJson) return;
lastPeersJson = currentPeersJson; lastPeersJson = currentPeersJson;
elements.peerList.innerHTML = peers.map(p => { const html = peers.map(p => {
const id = escapeHtml(typeof p === 'object' ? p.peerId : p); const id = escapeHtml(typeof p === 'object' ? p.peerId : p);
const titleText = (typeof p === 'object' && p.tabTitle) ? escapeHtml(p.tabTitle) : ''; const titleText = (typeof p === 'object' && p.tabTitle) ? escapeHtml(p.tabTitle) : '';
const title = titleText ? `<div style="font-size:10px; color:var(--text-muted);">${titleText}</div>` : ''; const title = titleText ? `<div style="font-size:10px; color:var(--text-muted);">${titleText}</div>` : '';
@@ -131,6 +133,12 @@ function updatePeerList(peers) {
</div> </div>
`; `;
}).join(''); }).join('');
const emptyHtml = '<div style="text-align:center; color: var(--text-muted); font-size: 12px;">No peers connected</div>';
if (elements.peerList) elements.peerList.innerHTML = html || emptyHtml;
if (elements.peerListSync) elements.peerListSync.innerHTML = html || emptyHtml;
// Re-populate tabs to update Star Matching when peers change // Re-populate tabs to update Star Matching when peers change
populateTabs(peers); populateTabs(peers);
} }
server/index.js
+1
View File
@@ -228,6 +228,7 @@ io.on('connection', (socket) => {
room.peers.delete(sid); room.peers.delete(sid);
room.peerIds.delete(sid); room.peerIds.delete(sid);
room.peerData.delete(sid); room.peerData.delete(sid);
socket.to(roomId).emit(EVENTS.PEER_STATUS, { peerId: data.peerId, status: 'left' });
log('ROOM', `Deduplicated peer ${peerId} from room ${roomId}`); log('ROOM', `Deduplicated peer ${peerId} from room ${roomId}`);
} }
} }