From 3e4b97b11a700c97358b1e9bb6489d2da08ab08b Mon Sep 17 00:00:00 2001 From: Skrockle Date: Wed, 1 Jul 2026 18:37:25 +0200 Subject: [PATCH] Fix: Remove redundant TITLE_PRIVACY_MODES array in popup.js - Remove duplicate local TITLE_PRIVACY_MODES array definition - Use Object.values(TITLE_PRIVACY_MODES).includes() for validation instead - Keeps single source of truth in title-privacy.js Co-Authored-By: Claude --- extension/popup.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/extension/popup.js b/extension/popup.js index 35240eb..a5b02e7 100644 --- a/extension/popup.js +++ b/extension/popup.js @@ -89,7 +89,6 @@ let pendingConnectionErrorMsg = null; let roomListRefreshTimer = null; let roomListRefreshInterval = null; const ROOM_LIST_REFRESH_COOLDOWN_MS = 11000; -const TITLE_PRIVACY_MODES = ['full', 'episode', 'hidden']; const FEATURE_HINTS = [ { key: 'audio_processing', @@ -211,7 +210,7 @@ async function init() { elements.username.value = username; if (elements.filterNoise) elements.filterNoise.checked = localData.filterNoise !== false; if (elements.autoSyncNextEpisode) elements.autoSyncNextEpisode.checked = localData.autoSyncNextEpisode !== false; - if (elements.titlePrivacyMode) elements.titlePrivacyMode.value = TITLE_PRIVACY_MODES.includes(localData.titlePrivacyMode) ? localData.titlePrivacyMode : 'full'; + if (elements.titlePrivacyMode) elements.titlePrivacyMode.value = Object.values(TITLE_PRIVACY_MODES).includes(localData.titlePrivacyMode) ? localData.titlePrivacyMode : 'full'; if (elements.forceSyncMode) elements.forceSyncMode.value = localData.forceSyncMode || 'jump-to-others'; if (elements.browserNotifications) elements.browserNotifications.checked = localData.browserNotifications === true; if (elements.autoCopyInvite) elements.autoCopyInvite.checked = localData.autoCopyInvite !== false;