feat: rank player candidates by ordered signals, add browser E2E suite

The weighted score summed incomparable units, so size could outvote traits that disqualify an element outright. Measured on a real page: a display:none preload reports its full 1080p intrinsic size and scored 2073600, beating a visible unmuted player at 509920. Selection now compares an ordered list of signals, highest priority first: has a source, is rendered, is not a silent background loop, rendered size bucket, is playing, has controls, duration. Rendered size replaces intrinsic resolution, and mute state is gone from the ranking entirely: it is a viewer preference, not evidence about which element is the player. It stays a ranking rather than a filter, so a page of only bad candidates still yields one and findVideo never returns null where a video exists. The new tests/e2e suite runs the shipped finder against real fixture pages and drives the packed extension for injection, reinjection and remote play/pause/seek into a first-party frame. All five scoring scenarios fail against the previous implementation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-31 13:08:15 +00:00 · 2026-08-14 07:23:12 +02:00
parent 79a2204a97
commit 36e1291d2c
30 changed files with 781 additions and 29 deletions
@@ -0,0 +1,72 @@
+#!/usr/bin/env node
+/**
+ * Static file server for the E2E fixtures. Local only, no directory listing,
+ * paths are resolved and then checked to stay inside the fixture root.
+ */
+import http from 'node:http';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), 'fixtures');
+const port = Number(process.argv[2] || 4173);
+
+const TYPES = {
+    '.html': 'text/html; charset=utf-8',
+    '.js': 'text/javascript; charset=utf-8',
+    '.mp4': 'video/mp4',
+    '.json': 'application/json'
+};
+
+const server = http.createServer((req, res) => {
+    const requested = decodeURIComponent(new URL(req.url, 'http://localhost').pathname);
+    const filePath = path.resolve(root, `.${requested}`);
+
+    if (!filePath.startsWith(root + path.sep)) {
+        res.writeHead(403).end('forbidden');
+        return;
+    }
+
+    fs.stat(filePath, (statErr, stat) => {
+        if (statErr || !stat.isFile()) {
+            res.writeHead(404).end('not found');
+            return;
+        }
+
+        const contentType = TYPES[path.extname(filePath)] || 'application/octet-stream';
+        // Media needs byte ranges: without them Chromium reports an empty
+        // seekable range and seeking silently does nothing, which would make
+        // the remote-seek test fail for a reason that has nothing to do with
+        // the extension.
+        const range = /^bytes=(\d*)-(\d*)$/.exec(req.headers.range || '');
+        if (range) {
+            const start = range[1] ? Number(range[1]) : 0;
+            const end = range[2] ? Number(range[2]) : stat.size - 1;
+            if (Number.isNaN(start) || Number.isNaN(end) || start > end || end >= stat.size) {
+                res.writeHead(416, { 'Content-Range': `bytes */${stat.size}` }).end();
+                return;
+            }
+            res.writeHead(206, {
+                'Content-Type': contentType,
+                'Content-Length': end - start + 1,
+                'Content-Range': `bytes ${start}-${end}/${stat.size}`,
+                'Accept-Ranges': 'bytes',
+                'Cache-Control': 'no-store'
+            });
+            fs.createReadStream(filePath, { start, end }).pipe(res);
+            return;
+        }
+
+        res.writeHead(200, {
+            'Content-Type': contentType,
+            'Content-Length': stat.size,
+            'Accept-Ranges': 'bytes',
+            'Cache-Control': 'no-store'
+        });
+        fs.createReadStream(filePath).pipe(res);
+    });
+});
+
+server.listen(port, '127.0.0.1', () => {
+    console.log(`fixture server on http://localhost:${port}`);
+});