From c03f158b7717fc2a2ad7cb18e61637ce3f7ff760 Mon Sep 17 00:00:00 2001 From: Przemyslaw Klys Date: Sat, 16 Sep 2023 09:37:44 +0200 Subject: [PATCH] Changed pipeline into standard foreach --- Public/Get-GPOZaurrAD.ps1 | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/Public/Get-GPOZaurrAD.ps1 b/Public/Get-GPOZaurrAD.ps1 index 7bcbcb4..ed28605 100644 --- a/Public/Get-GPOZaurrAD.ps1 +++ b/Public/Get-GPOZaurrAD.ps1 @@ -85,25 +85,26 @@ } Write-Verbose -Message "Get-GPOZaurrAD - Searching domain $Domain with filter $($Splat['Filter'])" - Get-ADObject @Splat -Properties DisplayName, Name, Created, Modified, ntSecurityDescriptor, gPCFileSysPath, gPCFunctionalityVersion, gPCWQLFilter, gPCMachineExtensionNames, Description, CanonicalName, DistinguishedName | ForEach-Object -Process { - $DomainCN = ConvertFrom-DistinguishedName -DistinguishedName $_.DistinguishedName -ToDomainCN - $GUID = $_.Name -replace '{' -replace '}' + $Objects = Get-ADObject @Splat -Properties DisplayName, Name, Created, Modified, ntSecurityDescriptor, gPCFileSysPath, gPCFunctionalityVersion, gPCWQLFilter, gPCMachineExtensionNames, Description, CanonicalName, DistinguishedName + foreach ($Object in $Objects) { + $DomainCN = ConvertFrom-DistinguishedName -DistinguishedName $Object.DistinguishedName -ToDomainCN + $GUID = $Object.Name -replace '{' -replace '}' if (($GUID).Length -ne 36) { - Write-Warning "Get-GPOZaurrAD - GPO GUID ($($($GUID.Replace("`n",' ')))) is incorrect. Skipping $($_.DisplayName) / Domain: $($DomainCN)" + Write-Warning "Get-GPOZaurrAD - GPO GUID ($($($GUID.Replace("`n",' ')))) is incorrect. Skipping $($Object.DisplayName) / Domain: $($DomainCN)" } else { [PSCustomObject]@{ - 'DisplayName' = $_.DisplayName + 'DisplayName' = $Object.DisplayName 'DomainName' = $DomainCN - 'Description' = $_.Description + 'Description' = $Object.Description 'GUID' = $GUID - 'Path' = $_.gPCFileSysPath - #$Output['FunctionalityVersion'] = $_.gPCFunctionalityVersion - 'Created' = $_.Created - 'Modified' = $_.Modified - 'Owner' = $_.ntSecurityDescriptor.Owner - 'GPOCanonicalName' = $_.CanonicalName - 'GPODomainDistinguishedName' = ConvertFrom-DistinguishedName -DistinguishedName $_.DistinguishedName -ToDC - 'GPODistinguishedName' = $_.DistinguishedName + 'Path' = $Object.gPCFileSysPath + #$Output['FunctionalityVersion'] = $Object.gPCFunctionalityVersion + 'Created' = $Object.Created + 'Modified' = $Object.Modified + 'Owner' = $Object.ntSecurityDescriptor.Owner + 'GPOCanonicalName' = $Object.CanonicalName + 'GPODomainDistinguishedName' = ConvertFrom-DistinguishedName -DistinguishedName $Object.DistinguishedName -ToDC + 'GPODistinguishedName' = $Object.DistinguishedName } } }