From e4d7d5ecf045403ebd4c0c81f9eaee9bd43fc390 Mon Sep 17 00:00:00 2001
From: NimBold <NimBold@users.noreply.github.com>
Date: Sat, 18 Jul 2026 12:02:17 +0330
Subject: [PATCH] feat(locations): make directory memory opt-in

Keep the last Add-window directory disabled until enabled in Settings > Locations.

Refs #23
---
 src-tauri/src/settings.rs          | 6 +++---
 src/store/useSettingsStore.test.ts | 6 ++++++
 src/store/useSettingsStore.ts      | 2 +-
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/src-tauri/src/settings.rs b/src-tauri/src/settings.rs
index cca401d..58edaa1 100644
--- a/src-tauri/src/settings.rs
+++ b/src-tauri/src/settings.rs
@@ -451,7 +451,7 @@ fn default_settings() -> PersistedSettings {
         proxy_port: 8080,
         custom_user_agent: String::new(),
         ask_where_to_save_each_file: false,
-        remember_last_used_download_directory: true,
+        remember_last_used_download_directory: false,
         prevents_sleep_while_downloading: true,
         media_cookie_source: MediaCookieSource::default(),
         site_logins: Vec::new(),
@@ -704,8 +704,8 @@ mod tests {
     }
 
     #[test]
-    fn remembers_last_used_download_directory_by_default() {
-        assert!(default_settings().remember_last_used_download_directory);
+    fn does_not_remember_last_used_download_directory_by_default() {
+        assert!(!default_settings().remember_last_used_download_directory);
     }
 
     #[test]
diff --git a/src/store/useSettingsStore.test.ts b/src/store/useSettingsStore.test.ts
index 43d33cf..41360b8 100644
--- a/src/store/useSettingsStore.test.ts
+++ b/src/store/useSettingsStore.test.ts
@@ -15,6 +15,12 @@ vi.mock('../utils/logger', () => ({
   info: vi.fn()
 }));
 
+describe('last used download directory preference', () => {
+  it('is disabled by default', () => {
+    expect(useSettingsStore.getState().rememberLastUsedDownloadDirectory).toBe(false);
+  });
+});
+
 describe('useSettingsStore global speed limit persistence', () => {
   beforeEach(() => {
     vi.clearAllMocks();
diff --git a/src/store/useSettingsStore.ts b/src/store/useSettingsStore.ts
index 7f9af44..48455f3 100644
--- a/src/store/useSettingsStore.ts
+++ b/src/store/useSettingsStore.ts
@@ -273,7 +273,7 @@ export const useSettingsStore = create<SettingsState>()(
       categorySubfoldersEnabled: true,
       categorySubfolders: { ...DEFAULT_CATEGORY_SUBFOLDERS },
       categoryDirectoryOverrides: {},
-      rememberLastUsedDownloadDirectory: true,
+      rememberLastUsedDownloadDirectory: false,
       lastUsedDownloadDirectory: null,
       approvedDownloadRoots: [],
       maxConcurrentDownloads: 3,