From e2744526d804a574894c6df84da756d7ed0394c7 Mon Sep 17 00:00:00 2001 From: NimBold Date: Mon, 15 Jun 2026 19:07:15 +0330 Subject: [PATCH] fix(yt-dlp): remove invalid --js-runtime-path flag The previous refactor introduced a hallucinated yt-dlp flag from the review report, which caused yt-dlp to immediately fail with 'no such option: --js-runtime-path'. This commit fixes the syntax to correctly format the runtime path into the --js-runtimes argument. --- src-tauri/src/lib.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src-tauri/src/lib.rs b/src-tauri/src/lib.rs index 298c209..7c63d7e 100644 --- a/src-tauri/src/lib.rs +++ b/src-tauri/src/lib.rs @@ -190,8 +190,7 @@ async fn fetch_media_metadata(app_handle: tauri::AppHandle, url: String, cookie_ .arg("--retries").arg("3") .arg("--extractor-retries").arg("3") .arg("--compat-options").arg("no-youtube-unavailable-videos") - .arg("--js-runtimes").arg("deno,node") - .arg("--js-runtime-path").arg(format!("deno:{}", deno_path.display())) + .arg("--js-runtimes").arg(format!("deno:{},node", deno_path.display())) .arg("--extractor-args").arg("youtube:player_client=ios,tv"); if let Some(browser) = cookie_browser { @@ -838,8 +837,7 @@ pub(crate) async fn start_media_download_internal( .arg("--concurrent-fragments").arg("4") .arg("--no-warnings") .arg("--compat-options").arg("no-youtube-unavailable-videos") - .arg("--js-runtimes").arg("deno,node") - .arg("--js-runtime-path").arg(format!("deno:{}", deno_path.display())) + .arg("--js-runtimes").arg(format!("deno:{},node", deno_path.display())) .arg("--extractor-args").arg("youtube:player_client=ios,tv") .arg("--progress-template").arg("download:[%(progress.downloaded_bytes)s/%(progress.total_bytes)s]") .arg("-o").arg(out_path.to_string_lossy().to_string());