From b71a58ae06bcd35224e250eb915292150fb25ef5 Mon Sep 17 00:00:00 2001 From: nimbold <11913706+nimbold@users.noreply.github.com> Date: Mon, 8 Jun 2026 16:41:09 +0330 Subject: [PATCH] fix: resolve duplicate resolution window not closing - Dispatch executeAddDownloads asynchronously after closing the sheet to avoid swallowing dismiss() --- CHANGELOG.md | 1 + Sources/Firelink/AddDownloadsView.swift | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1af5804..5018067 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.6.2] - 2026-06-08 ### Fixes +- Fix a bug where confirming a duplicate resolution failed to close the Add Downloads window, misleading users into thinking the download didn't start. - Fix keyboard shortcut collision that caused the main window to intercept Enter/Escape keys when the duplicate resolution sheet was open. - Fix UI freeze when checking release notes for an update by parsing HTML asynchronously on a background thread. - Improve Sparkle changelog formatting by converting HTML tags to clean Markdown instead of stripping them into an unreadable block of text. diff --git a/Sources/Firelink/AddDownloadsView.swift b/Sources/Firelink/AddDownloadsView.swift index e6d830e..7ce69c5 100644 --- a/Sources/Firelink/AddDownloadsView.swift +++ b/Sources/Firelink/AddDownloadsView.swift @@ -56,7 +56,9 @@ struct AddDownloadsView: View { conflicts: $conflictingDownloads, onConfirm: { showingDuplicates = false - executeAddDownloads(start: pendingStartFlag, conflicts: conflictingDownloads) + DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) { + executeAddDownloads(start: pendingStartFlag, conflicts: conflictingDownloads) + } }, onCancel: { showingDuplicates = false