gsadmin/Firelink
1
0
Fork 0
mirror of https://github.com/nimbold/Firelink.git synced 2026-08-11 03:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(download): require aria2 for file transfers

Browse Source 
Update yt-dlp to 2026.07.04 and refresh the bundled macOS runtime plus engine locks.

Route every non-media download through aria2 by removing the native HTTP fallback path, native GID handling, and the old direct-download harness.

Retry transient aria2 startup/RPC failures before failing, then show the real last error in the download row and Properties modal so Windows failures are diagnosable instead of silent.

Refresh docs and tests around the aria2-only file-download contract, and advance the Firefox extension submodule to its published wording cleanup.
This commit is contained in:
NimBold
2026-07-05 20:00:53 +03:30
parent 3aaf32f9ee
commit 757e313f71
88 changed files with 251 additions and 1423 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src-tauri/tests/queue_manager.rs
+8 -22
View File
@@ -12,7 +12,6 @@ use tokio::time::timeout;
struct CountingSpawner {
add_uri_calls: AtomicUsize,
media_calls: AtomicUsize,
native_calls: AtomicUsize,
}
struct DelayedAria2Spawner {
@@ -47,10 +46,6 @@ impl SidecarSpawner for DelayedAria2Spawner {
async fn run_media(&self, _id: &str, _payload: &SpawnPayload) -> Result<(), String> {
unreachable!("media is not used by delayed aria2 tests")
}
async fn run_native(&self, _id: &str, _payload: &SpawnPayload) -> Result<(), String> {
unreachable!("native is not used by delayed aria2 tests")
}
}
impl CountingSpawner {
@@ -58,7 +53,6 @@ impl CountingSpawner {
Self {
add_uri_calls: AtomicUsize::new(0),
media_calls: AtomicUsize::new(0),
native_calls: AtomicUsize::new(0),
}
}
}
@@ -76,10 +70,6 @@ impl firelink_lib::queue::SidecarSpawner for CountingSpawner {
self.media_calls.fetch_add(1, Ordering::SeqCst);
Ok(())
}
async fn run_native(&self, _id: &str, _payload: &SpawnPayload) -> Result<(), String> {
self.native_calls.fetch_add(1, Ordering::SeqCst);
Ok(())
}
}
/// Build a QueueManager with a fake spawner. Tauri's mock AppHandle is needed
@@ -97,7 +87,7 @@ fn sample_task(id: &str) -> QueuedTask {
QueuedTask {
id: id.to_string(),
queue_id: "main".to_string(),
kind: TaskKind::Native,
kind: TaskKind::Aria2,
payload: SpawnPayload::default(),
}
}
@@ -243,18 +233,18 @@ async fn grow_releases_immediately_and_dispatches_waiting_tasks() {
// Give dispatcher time to dispatch 2 (capacity) of the 4.
tokio::time::sleep(Duration::from_millis(100)).await;
let native_after_initial = spawner.native_calls.load(Ordering::SeqCst);
let aria2_after_initial = spawner.add_uri_calls.load(Ordering::SeqCst);
assert_eq!(
native_after_initial, 2,
aria2_after_initial, 2,
"only capacity-many tasks dispatch initially"
);
// Grow to 4; the remaining 2 should dispatch.
mgr_arc.set_capacity(4);
tokio::time::sleep(Duration::from_millis(100)).await;
let native_after_grow = spawner.native_calls.load(Ordering::SeqCst);
let aria2_after_grow = spawner.add_uri_calls.load(Ordering::SeqCst);
assert_eq!(
native_after_grow, 4,
aria2_after_grow, 4,
"grow must allow the waiting tasks to dispatch"
);
@@ -276,7 +266,7 @@ async fn shrink_converges_to_target_without_killing_active() {
// Let 4 dispatch (capacity).
tokio::time::sleep(Duration::from_millis(100)).await;
assert_eq!(spawner.native_calls.load(Ordering::SeqCst), 4);
assert_eq!(spawner.add_uri_calls.load(Ordering::SeqCst), 4);
// Shrink to 2 while 4 are "active" (permits parked).
mgr_arc.set_capacity(2);
@@ -288,7 +278,7 @@ async fn shrink_converges_to_target_without_killing_active() {
tokio::time::sleep(Duration::from_millis(100)).await;
assert_eq!(
spawner.native_calls.load(Ordering::SeqCst),
spawner.add_uri_calls.load(Ordering::SeqCst),
4,
"pending tasks must not dispatch while active count already meets the shrunken target"
);
@@ -298,7 +288,7 @@ async fn shrink_converges_to_target_without_killing_active() {
tokio::time::sleep(Duration::from_millis(100)).await;
assert_eq!(
spawner.native_calls.load(Ordering::SeqCst),
spawner.add_uri_calls.load(Ordering::SeqCst),
6,
"pending tasks dispatch after active count falls below the shrunken target"
);
@@ -372,10 +362,6 @@ impl SidecarSpawner for FixedMediaSpawner {
async fn run_media(&self, _id: &str, _payload: &SpawnPayload) -> Result<(), String> {
self.outcome.clone()
}
async fn run_native(&self, _id: &str, _payload: &SpawnPayload) -> Result<(), String> {
unreachable!("native downloads are not used by media terminal-state tests")
}
}
fn make_media_manager(