diff --git a/src-tauri/src/commands.rs b/src-tauri/src/commands.rs index 465a1e8..ad4e020 100644 --- a/src-tauri/src/commands.rs +++ b/src-tauri/src/commands.rs @@ -1,7 +1,6 @@ use std::ffi::OsString; use std::path::{Component, Path, PathBuf}; use tauri_plugin_opener::OpenerExt; -use tauri_plugin_store::StoreExt; #[tauri::command] pub async fn reveal_in_file_manager( @@ -91,41 +90,7 @@ fn authorize_download_path( } fn known_download_paths(app_handle: &tauri::AppHandle) -> Result, String> { - let store = app_handle - .store("store.bin") - .map_err(|e| format!("Failed to load download ownership data: {e}"))?; - let settings = crate::settings::load_settings(app_handle).ok(); - let downloads = store - .get("download_queue") - .map(|value| serde_json::from_value::>(value.clone())) - .transpose() - .map_err(|e| format!("Invalid download ownership data: {e}"))? - .unwrap_or_default(); - - Ok(downloads - .into_iter() - .filter_map(|download| { - let category = format!("{:?}", download.category); - let destination = download - .destination - .filter(|destination| !destination.trim().is_empty()) - .or_else(|| { - settings - .as_ref() - .and_then(|settings| settings.download_directories.get(&category).cloned()) - }) - .or_else(|| { - settings - .as_ref() - .map(|settings| settings.default_download_path.clone()) - }) - .unwrap_or_else(|| "~/Downloads".to_string()); - let filename = Path::new(&download.file_name.replace('\\', "/")) - .file_name()? - .to_owned(); - Some(crate::resolve_path(&destination, app_handle).join(filename)) - }) - .collect()) + crate::download_ownership::known_primary_paths(app_handle) } fn authorize_exact_path(requested: &Path, allowed_paths: &[PathBuf]) -> Result { diff --git a/src-tauri/src/download_ownership.rs b/src-tauri/src/download_ownership.rs new file mode 100644 index 0000000..b688d33 --- /dev/null +++ b/src-tauri/src/download_ownership.rs @@ -0,0 +1,184 @@ +use serde::{Deserialize, Serialize}; +use std::path::{Path, PathBuf}; +use tauri_plugin_store::StoreExt; + +const STORE_NAME: &str = "store.bin"; +const OWNERSHIP_KEY: &str = "download_ownership"; + +#[derive(Clone, Debug, Serialize, Deserialize)] +#[serde(rename_all = "camelCase")] +struct DownloadOwnershipRecord { + id: String, + primary_path: String, +} + +pub fn expected_primary_path( + app_handle: &tauri::AppHandle, + destination: &str, + filename: &str, +) -> Result { + let resolved_dest = crate::resolve_path(destination, app_handle); + if !crate::is_safe_path(&resolved_dest, app_handle) { + return Err("Path traversal blocked".to_string()); + } + + let safe_filename = Path::new(&filename.replace('\\', "/")) + .file_name() + .ok_or_else(|| "Download filename is invalid".to_string())? + .to_owned(); + Ok(resolved_dest.join(safe_filename)) +} + +pub fn register_expected( + app_handle: &tauri::AppHandle, + id: &str, + destination: &str, + filename: &str, +) -> Result<(), String> { + let path = expected_primary_path(app_handle, destination, filename)?; + set_primary_path(app_handle, id, &path) +} + +pub fn set_primary_path( + app_handle: &tauri::AppHandle, + id: &str, + path: &Path, +) -> Result<(), String> { + if !path.is_absolute() { + return Err("Download ownership path must be absolute".to_string()); + } + if path.components().any(|component| { + matches!( + component, + std::path::Component::ParentDir | std::path::Component::CurDir + ) + }) { + return Err("Download ownership path traversal is not allowed".to_string()); + } + if std::fs::symlink_metadata(path).is_ok_and(|metadata| metadata.file_type().is_symlink()) { + return Err("Download ownership path may not be a symlink".to_string()); + } + + let mut records = load_records(app_handle)?; + records.retain(|record| record.id != id); + records.push(DownloadOwnershipRecord { + id: id.to_string(), + primary_path: path.to_string_lossy().to_string(), + }); + save_records(app_handle, records) +} + +pub fn remove(app_handle: &tauri::AppHandle, id: &str) -> Result<(), String> { + let mut records = load_records(app_handle)?; + let before = records.len(); + records.retain(|record| record.id != id); + if records.len() == before { + return Ok(()); + } + save_records(app_handle, records) +} + +pub fn known_primary_paths(app_handle: &tauri::AppHandle) -> Result, String> { + let mut paths: Vec = load_records(app_handle)? + .into_iter() + .map(|record| PathBuf::from(record.primary_path)) + .collect(); + + // One-time compatibility for downloads created before the backend-owned + // registry existed. This imports the exact persisted queue path only. + for path in legacy_download_queue_paths(app_handle)? { + if !paths.iter().any(|existing| existing == &path) { + paths.push(path); + } + } + + Ok(paths) +} + +fn load_records(app_handle: &tauri::AppHandle) -> Result, String> { + let store = app_handle + .store(STORE_NAME) + .map_err(|error| format!("Failed to load download ownership store: {error}"))?; + store + .get(OWNERSHIP_KEY) + .map(|value| serde_json::from_value::>(value.clone())) + .transpose() + .map_err(|error| format!("Invalid download ownership data: {error}")) + .map(|records| records.unwrap_or_default()) +} + +fn save_records( + app_handle: &tauri::AppHandle, + records: Vec, +) -> Result<(), String> { + let store = app_handle + .store(STORE_NAME) + .map_err(|error| format!("Failed to load download ownership store: {error}"))?; + let value = serde_json::to_value(records) + .map_err(|error| format!("Failed to encode download ownership data: {error}"))?; + store.set(OWNERSHIP_KEY, value); + store + .save() + .map_err(|error| format!("Failed to save download ownership data: {error}")) +} + +fn legacy_download_queue_paths(app_handle: &tauri::AppHandle) -> Result, String> { + let store = app_handle + .store(STORE_NAME) + .map_err(|error| format!("Failed to load download queue: {error}"))?; + let settings = crate::settings::load_settings(app_handle).ok(); + let downloads = store + .get("download_queue") + .map(|value| serde_json::from_value::>(value.clone())) + .transpose() + .map_err(|error| format!("Invalid download queue ownership data: {error}"))? + .unwrap_or_default(); + + let mut paths = Vec::new(); + for download in downloads { + let category = format!("{:?}", download.category); + let mut destinations = Vec::new(); + + if let Some(destination) = download + .destination + .clone() + .filter(|destination| !destination.trim().is_empty()) + { + destinations.push(destination); + } + + let category_destination = settings + .as_ref() + .and_then(|settings| settings.download_directories.get(&category).cloned()); + let default_destination = settings + .as_ref() + .map(|settings| settings.default_download_path.clone()); + + if destinations.is_empty() { + let fallback_destination = category_destination.clone().or(default_destination.clone()); + if let Some(destination) = fallback_destination { + destinations.push(destination); + } + } + + if matches!(download.status, crate::ipc::DownloadStatus::Completed) { + if let Some(destination) = category_destination { + destinations.push(destination); + } + if let Some(destination) = default_destination { + destinations.push(destination); + } + destinations.push("~/Downloads".to_string()); + } + + for destination in destinations { + if let Ok(path) = expected_primary_path(app_handle, &destination, &download.file_name) { + if !paths.iter().any(|existing| existing == &path) { + paths.push(path); + } + } + } + } + + Ok(paths) +} diff --git a/src-tauri/src/lib.rs b/src-tauri/src/lib.rs index 5939e6f..27f7ea8 100644 --- a/src-tauri/src/lib.rs +++ b/src-tauri/src/lib.rs @@ -1145,6 +1145,7 @@ pub mod ipc; mod parity; pub mod error; pub mod commands; +pub mod download_ownership; pub mod retry; mod settings; pub use error::AppError; @@ -2327,6 +2328,7 @@ async fn remove_download( filepath: Option, ) -> Result<(), String> { log::info!("remove_download called for id: {}", id); + let _ = crate::download_ownership::remove(&app_handle, &id); let active_kind = state.queue_manager.active_kind(&id).await; state.queue_manager.remove_from_pending(&id).await; @@ -2529,19 +2531,35 @@ async fn get_pending_order(state: tauri::State<'_, AppState>) -> Result, item: queue::EnqueueItem, ) -> Result { let id = item.id.clone(); + crate::download_ownership::register_expected( + &app_handle, + &item.id, + &item.destination, + &item.filename, + )?; state.queue_manager.push(item.into_task()).await; Ok(id) } #[tauri::command] async fn enqueue_many( + app_handle: tauri::AppHandle, state: tauri::State<'_, AppState>, items: Vec, ) -> Result<(), AppError> { + for item in &items { + crate::download_ownership::register_expected( + &app_handle, + &item.id, + &item.destination, + &item.filename, + )?; + } let tasks = items.into_iter().map(queue::EnqueueItem::into_task).collect(); state.queue_manager.enqueue_many(tasks).await; Ok(()) @@ -2557,8 +2575,16 @@ async fn move_in_queue( } #[tauri::command] -async fn remove_from_queue(state: tauri::State<'_, AppState>, id: String) -> Result { - Ok(state.queue_manager.remove_from_pending(&id).await) +async fn remove_from_queue( + app_handle: tauri::AppHandle, + state: tauri::State<'_, AppState>, + id: String, +) -> Result { + let removed = state.queue_manager.remove_from_pending(&id).await; + if removed { + crate::download_ownership::remove(&app_handle, &id)?; + } + Ok(removed) } #[tauri::command] diff --git a/src-tauri/src/queue.rs b/src-tauri/src/queue.rs index cfa72db..dd3d3e1 100644 --- a/src-tauri/src/queue.rs +++ b/src-tauri/src/queue.rs @@ -910,6 +910,15 @@ impl SidecarSpawner for ProductionSpawner { &mut cancel_rx, ) .await; + if outcome.is_ok() { + if let Ok(path) = crate::download_ownership::expected_primary_path( + &self.app_handle, + &payload.destination, + &payload.filename, + ) { + let _ = crate::download_ownership::set_primary_path(&self.app_handle, id, &path); + } + } let _ = state.download_coordinator.finish_media(id.to_string()).await; outcome } @@ -924,13 +933,15 @@ impl SidecarSpawner for ProductionSpawner { .and_then(|n| n.to_str()) .unwrap_or("download") .to_string(); + let output_path = resolved_dest.join(safe_filename); + let _ = crate::download_ownership::set_primary_path(&self.app_handle, id, &output_path); state .download_coordinator .send(crate::download::DownloadCmd::Start(Box::new( crate::download::DownloadPayload { id: download_id, urls: crate::collect_download_uris(&payload.url, payload.mirrors.as_deref()), - output_path: resolved_dest.join(safe_filename), + output_path, speed_limit: payload.speed_limit.clone(), username: payload.username.clone(), password: payload.password.clone(),