fix: address post-audit regressions across queue, db, and ui

- Preserved extension-captured cookies through the Add modal, with a clean fallback when captured cookies break metadata fetching.
- Prevented batched extension captures from losing URLs or reusing stale cookie/header contexts.
- Fixed pause/resume and enqueue generation races, including cancellation during queue reservation and replay after task removal.
- Made startup database initialization safe under React StrictMode.
- Serialized keyring operations and corrected Linux legacy migration/deletion behavior.
- Restored `Downloading` state after yt-dlp retries.
- Replaced hardcoded media heights with dynamically detected formats, including nonstandard qualities such as 576p and 2880p.

src/store/useDownloadStore.test.ts

@@ -90,7 +90,6 @@ describe('useDownloadStore', () => {
       pendingAddMediaUrls: [],
       pendingAddRequestContexts: {},
       pendingAddRequestVersion: 0,
-      pendingAddLatestUrls: '',
     });
   });
 
@@ -315,6 +314,15 @@ describe('useDownloadStore', () => {
       );
     });
     const pause = useDownloadStore.getState().pauseDownload('paused');
+    await vi.waitFor(() => {
+      expect(ipc.invokeCommand).toHaveBeenCalledWith(
+        'cancel_enqueue_generation',
+        expect.objectContaining({ id: 'paused' })
+      );
+    });
+    expect(
+      vi.mocked(ipc.invokeCommand).mock.calls.some(([command]) => command === 'pause_download')
+    ).toBe(false);
     resolveEnqueue({ id: 'paused', filename: 'paused.bin' });
 
     await expect(pause).resolves.toBeUndefined();
@@ -784,21 +792,22 @@ describe('useDownloadStore', () => {
       'https://first.example/file.zip\nhttps://second.example/file.zip'
     );
     expect(state.pendingAddRequestVersion).toBe(2);
-    expect(state.pendingAddLatestUrls).toBe('https://second.example/file.zip');
     expect(state.pendingAddRequestContexts).toEqual({
       'https://first.example/file.zip': {
         version: 1,
         referer: 'https://first.example/page',
         filename: 'first.zip',
         headers: 'User-Agent: First Browser',
-        cookies: 'first=session'
+        cookies: 'first=session',
+        media: false
       },
       'https://second.example/file.zip': {
         version: 2,
         referer: 'https://second.example/page',
         filename: 'second.zip',
         headers: 'User-Agent: Second Browser',
-        cookies: 'second=session'
+        cookies: 'second=session',
+        media: false
       }
     });
   });
@@ -818,7 +827,38 @@ describe('useDownloadStore', () => {
     expect(state.isAddModalOpen).toBe(true);
     expect(state.pendingAddUrls).toBe('https://adult.example/watch/123');
     expect(state.pendingAddMediaUrls).toEqual(['https://adult.example/watch/123']);
-    expect(state.pendingAddCookies).toBe('');
+    expect(state.pendingAddCookies).toBe('session=secret');
+  });
+
+  it('clears stale request context when the same URL is captured without it later', async () => {
+    const url = 'https://example.com/file.zip';
+    await useDownloadStore.getState().handleExtensionDownload({
+      urls: [url],
+      referer: 'https://example.com/private',
+      silent: true,
+      filename: 'private.zip',
+      headers: 'Authorization: secret',
+      cookies: 'session=secret',
+      media: false
+    });
+    await useDownloadStore.getState().handleExtensionDownload({
+      urls: [url],
+      referer: null,
+      silent: true,
+      filename: null,
+      headers: null,
+      cookies: null,
+      media: false
+    });
+
+    expect(useDownloadStore.getState().pendingAddRequestContexts[url]).toEqual({
+      version: 2,
+      referer: '',
+      filename: '',
+      headers: '',
+      cookies: '',
+      media: false
+    });
   });
 
   it('deduplicates forced media URLs and drops stale media intent when opening fresh', async () => {

src/store/useDownloadStore.ts

@@ -311,6 +311,7 @@ export type PendingAddRequestContext = {
   filename: string;
   headers: string;
   cookies: string;
+  media: boolean;
 };
 
 export type DeleteModalState = {
@@ -338,7 +339,6 @@ interface DownloadState {
   pendingAddMediaUrls: string[];
   pendingAddRequestContexts: Record<string, PendingAddRequestContext>;
   pendingAddRequestVersion: number;
-  pendingAddLatestUrls: string;
   selectedPropertiesDownloadId: string | null;
   toggleAddModal: (isOpen: boolean) => void;
   openAddModalWithUrls: (
@@ -475,7 +475,6 @@ export const useDownloadStore = create<DownloadState>((set, get) => ({
   pendingAddMediaUrls: [],
   pendingAddRequestContexts: {},
   pendingAddRequestVersion: 0,
-  pendingAddLatestUrls: '',
   selectedPropertiesDownloadId: null,
   deleteModalState: { isOpen: false },
   openDeleteModal: (downloadIds) => set({ 
@@ -493,8 +492,7 @@ export const useDownloadStore = create<DownloadState>((set, get) => ({
     pendingAddHeaders: '',
     pendingAddCookies: '',
     pendingAddMediaUrls: [],
-    pendingAddRequestContexts: {},
-    pendingAddLatestUrls: ''
+    pendingAddRequestContexts: {}
   }),
   openAddModalWithUrls: (urls, referer, filename, headers, cookies, media = false) => set((state) => {
     const isAppending = state.isAddModalOpen && Boolean(state.pendingAddUrls);
@@ -512,28 +510,30 @@ export const useDownloadStore = create<DownloadState>((set, get) => ({
     const cleanHeaders = headers?.trim() || '';
     const cleanCookies = cookies?.trim() || '';
     const requestVersion = state.pendingAddRequestVersion + 1;
-    const hasRequestContext = Boolean(cleanReferer || cleanFilename || cleanHeaders || cleanCookies);
     const pendingAddRequestContexts = isAppending
       ? { ...state.pendingAddRequestContexts }
       : {};
-    if (hasRequestContext) {
-      for (const rawUrl of urls.split('\n')) {
-        const trimmedUrl = rawUrl.trim();
-        if (!trimmedUrl) continue;
-        let key = trimmedUrl;
-        try {
-          key = new URL(trimmedUrl).href;
-        } catch {
-          // The Add modal will mark malformed input invalid; retain its original key here.
-        }
-        pendingAddRequestContexts[key] = {
-          version: requestVersion,
-          referer: cleanReferer,
-          filename: cleanFilename,
-          headers: cleanHeaders,
-          cookies: cleanCookies
-        };
+    // Every handoff gets a versioned row context, including an intentionally
+    // empty one. Otherwise a later request for the same URL cannot clear stale
+    // cookies/headers from an earlier capture, and batched React renders can
+    // lose all but the most recent appended URL.
+    for (const rawUrl of urls.split('\n')) {
+      const trimmedUrl = rawUrl.trim();
+      if (!trimmedUrl) continue;
+      let key = trimmedUrl;
+      try {
+        key = new URL(trimmedUrl).href;
+      } catch {
+        // The Add modal will mark malformed input invalid; retain its original key here.
       }
+      pendingAddRequestContexts[key] = {
+        version: requestVersion,
+        referer: cleanReferer,
+        filename: cleanFilename,
+        headers: cleanHeaders,
+        cookies: cleanCookies,
+        media
+      };
     }
     return {
       isAddModalOpen: true,
@@ -544,25 +544,19 @@ export const useDownloadStore = create<DownloadState>((set, get) => ({
       pendingAddCookies: cleanCookies,
       pendingAddMediaUrls,
       pendingAddRequestContexts,
-      pendingAddRequestVersion: requestVersion,
-      pendingAddLatestUrls: urls
+      pendingAddRequestVersion: requestVersion
     };
   }),
   handleExtensionDownload: async (request) => {
     const urls = [...new Set(request.urls.map(url => url.trim()).filter(Boolean))];
     if (urls.length === 0) return;
 
-    // Explicit media uses yt-dlp and its configured browser-cookie source.
-    // Passing Firefox's complete page Cookie header can exceed YouTube's
-    // request-header limit; ordinary captured file downloads keep it.
-    const cookies = request.media === true ? null : request.cookies;
-
     get().openAddModalWithUrls(
       urls.join('\n'),
       request.referer,
       urls.length === 1 ? request.filename : null,
       request.headers,
-      cookies,
+      request.cookies,
       request.media === true
     );
   },
@@ -687,7 +681,10 @@ export const useDownloadStore = create<DownloadState>((set, get) => ({
     syncSystemIntegrations();
   },
   pauseDownload: async (id) => {
-    const { generation } = await invalidateDispatch(id);
+    const { generation, pendingDispatch } = await invalidateDispatch(id);
+    if (pendingDispatch) {
+      await pendingDispatch;
+    }
 
     await invoke('pause_download', { id });