fix(settings): harden Torrent network validation

- Align the DHT message-timeout range with bundled Aria2 1.37.0.
- Validate and canonicalize Torrent network text settings at the native boundary.
- Fence delayed input responses and reject contradictory IPv6 bind state.
- Add regression coverage for malformed settings and cross-field races.
This commit is contained in:
NimBold
2026-08-13 16:40:46 +03:30
parent 4b43e8ed5c
commit 314f4e2e00
16 changed files with 389 additions and 164 deletions
+32 -1
View File
@@ -10319,6 +10319,16 @@ fn db_load_settings(
.transpose()
}
#[tauri::command]
fn canonicalize_torrent_network_setting(
caller: tauri::WebviewWindow,
field: String,
value: String,
) -> Result<String, String> {
properties_window::ensure_main_window(&caller)?;
crate::settings::canonicalize_torrent_network_setting(&field, &value)
}
#[tauri::command]
fn db_get_all_downloads(
caller: tauri::WebviewWindow,
@@ -11350,6 +11360,26 @@ mod tests {
.collect::<Vec<_>>(),
vec!["--dht-message-timeout=10"]
);
let mut maximum = std::process::Command::new("aria2c");
apply_aria2_torrent_dht_options(&mut maximum, queue::MAX_TORRENT_DHT_MESSAGE_TIMEOUT);
assert_eq!(
maximum
.get_args()
.map(|arg| arg.to_string_lossy().into_owned())
.collect::<Vec<_>>(),
vec!["--dht-message-timeout=60"]
);
let mut out_of_range = std::process::Command::new("aria2c");
apply_aria2_torrent_dht_options(&mut out_of_range, 61);
assert_eq!(
out_of_range
.get_args()
.map(|arg| arg.to_string_lossy().into_owned())
.collect::<Vec<_>>(),
vec!["--dht-message-timeout=10"]
);
}
#[test]
@@ -15451,7 +15481,8 @@ pub fn run() {
properties_window::properties_window_registry_remove_for_download,
parity::get_system_proxy, parity::get_file_category, parity::check_for_updates, parity::is_supported_media, parity::get_supported_media_domains,
parity::create_category_directories,
db_save_settings, db_load_settings, db_get_all_downloads, db_replace_downloads,
db_save_settings, db_load_settings, canonicalize_torrent_network_setting,
db_get_all_downloads, db_replace_downloads,
db_commit_download_state,
clear_torrent_removal_paths, reconcile_torrent_removal_reservations,
db_get_all_queues, db_replace_queues,