mirror of
https://github.com/nimbold/Firelink.git
synced 2026-08-07 01:44:01 +00:00
fix(app): decouple completion chime
Play the completion sound through the app with Web Audio so it is not tied to whether desktop notifications are enabled or whether a platform-specific notification sound name is supported. Keep the notification body focused on completion status and leave the settings toggle available even when notifications are disabled.
This commit is contained in:
@@ -526,19 +526,6 @@ runEngineChecks(false);
|
||||
className="app-control w-24 text-center"
|
||||
/>
|
||||
</div>
|
||||
<div className="mac-settings-row">
|
||||
<div className="settings-row-label">
|
||||
<span>Global speed limit:</span>
|
||||
<small>{settings.globalSpeedLimit || 'Unlimited'}</small>
|
||||
</div>
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => settings.setActiveView('speedLimiter')}
|
||||
className="app-button px-3 text-xs"
|
||||
>
|
||||
Configure…
|
||||
</button>
|
||||
</div>
|
||||
<div className="mac-settings-row">
|
||||
<div className="settings-row-label">
|
||||
<span>Automatic retries:</span>
|
||||
@@ -571,12 +558,11 @@ runEngineChecks(false);
|
||||
className="mac-switch"
|
||||
/>
|
||||
</label>
|
||||
<label className="mac-settings-row cursor-default" style={{ opacity: settings.showNotifications ? 1 : 0.5 }}>
|
||||
<label className="mac-settings-row cursor-default">
|
||||
<span className="text-[13px] text-text-primary">Play sound when download completes</span>
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={settings.playCompletionSound}
|
||||
disabled={!settings.showNotifications}
|
||||
onChange={(e) => settings.setPlayCompletionSound(e.target.checked)}
|
||||
className="mac-switch"
|
||||
/>
|
||||
|
||||
Reference in New Issue
Block a user