Files
DynamoDNS/client/src/pages/users-roles.tsx
T
alphaeusmote c42b464cfe Fix: Improved type safety in user role management
Replit-Commit-Author: Agent
Replit-Commit-Session-Id: 9111ef36-26c8-4085-84ca-a35dc1fec1b5
Replit-Commit-Screenshot-Url: https://storage.googleapis.com/screenshot-production-us-central1/7083d608-d6d3-4a6a-9a27-6286c5109627/75cbeba5-9116-4410-bb46-9a7acc4192de.jpg
2025-04-10 01:18:45 +00:00

709 lines
24 KiB
TypeScript

import { useState } from "react";
import { useQuery, useMutation } from "@tanstack/react-query";
import { MainLayout } from "@/components/layouts/main-layout";
import { User, InsertUser, systemRoles, UserRole } from "@shared/schema";
import { useAuth } from "@/hooks/use-auth";
import { apiRequest, queryClient } from "@/lib/queryClient";
import { useToast } from "@/hooks/use-toast";
import { useForm } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod";
import { z } from "zod";
import {
Table,
TableBody,
TableCell,
TableHead,
TableHeader,
TableRow,
} from "@/components/ui/table";
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import {
Form,
FormControl,
FormField,
FormItem,
FormLabel,
FormMessage,
} from "@/components/ui/form";
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
import {
AlertDialog,
AlertDialogAction,
AlertDialogCancel,
AlertDialogContent,
AlertDialogDescription,
AlertDialogFooter,
AlertDialogHeader,
AlertDialogTitle,
} from "@/components/ui/alert-dialog";
import {
Card,
CardContent,
CardDescription,
CardHeader,
CardTitle,
} from "@/components/ui/card";
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Badge } from "@/components/ui/badge";
import { Pagination } from "@/components/shared/pagination";
import { Loader2, MoreVertical, UserPlus, Lock, Shield, UserCog } from "lucide-react";
import { formatDistanceToNow } from "date-fns";
import { useOrganization } from "@/context/organization-context";
// User form schema
const userFormSchema = z.object({
username: z.string().min(3, "Username must be at least 3 characters"),
email: z.string().email("Please enter a valid email"),
password: z.string().min(8, "Password must be at least 8 characters"),
fullName: z.string().optional(),
role: z.enum(systemRoles as unknown as [string, ...string[]]),
organizationId: z.number().optional(),
});
export default function UsersRolesPage() {
const { toast } = useToast();
const { user } = useAuth();
const { currentOrganization } = useOrganization();
const [isAddUserDialogOpen, setIsAddUserDialogOpen] = useState(false);
const [isEditRoleDialogOpen, setIsEditRoleDialogOpen] = useState(false);
const [isDeleteDialogOpen, setIsDeleteDialogOpen] = useState(false);
const [selectedUser, setSelectedUser] = useState<User | null>(null);
const [currentPage, setCurrentPage] = useState(1);
const pageSize = 10;
// Fetch users
const { data: users = [], isLoading } = useQuery<User[]>({
queryKey: ["/api/users"],
enabled: !!user && user.role === "admin",
});
// Fetch organizations for select
const { data: organizations = [] } = useQuery({
queryKey: ["/api/organizations"],
});
// Form for adding a user
const addUserForm = useForm<z.infer<typeof userFormSchema>>({
resolver: zodResolver(userFormSchema),
defaultValues: {
username: "",
email: "",
password: "",
fullName: "",
role: "user",
organizationId: currentOrganization?.id,
},
});
// Form for editing a user's role
const editRoleForm = useForm<{ role: UserRole }>({
resolver: zodResolver(z.object({
role: z.enum(systemRoles as unknown as [string, ...string[]]),
})),
defaultValues: {
role: "user",
},
});
// Add user mutation
const addUserMutation = useMutation({
mutationFn: async (data: z.infer<typeof userFormSchema>) => {
const res = await apiRequest("POST", "/api/register", data);
return await res.json();
},
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ["/api/users"] });
setIsAddUserDialogOpen(false);
addUserForm.reset();
toast({
title: "User added",
description: "The user has been successfully added.",
});
},
onError: (error) => {
toast({
title: "Failed to add user",
description: error.message,
variant: "destructive",
});
},
});
// Update user role mutation
const updateRoleMutation = useMutation({
mutationFn: async ({ userId, role }: { userId: number, role: UserRole }) => {
const res = await apiRequest("PUT", `/api/users/${userId}`, { role });
return await res.json();
},
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ["/api/users"] });
setIsEditRoleDialogOpen(false);
setSelectedUser(null);
toast({
title: "Role updated",
description: "The user's role has been successfully updated.",
});
},
onError: (error) => {
toast({
title: "Failed to update role",
description: error.message,
variant: "destructive",
});
},
});
// Delete user mutation
const deleteUserMutation = useMutation({
mutationFn: async (userId: number) => {
await apiRequest("DELETE", `/api/users/${userId}`);
},
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ["/api/users"] });
setIsDeleteDialogOpen(false);
setSelectedUser(null);
toast({
title: "User deleted",
description: "The user has been successfully deleted.",
});
},
onError: (error) => {
toast({
title: "Failed to delete user",
description: error.message,
variant: "destructive",
});
},
});
// Form submission handler for adding user
const onAddUserSubmit = (data: z.infer<typeof userFormSchema>) => {
addUserMutation.mutate(data);
};
// Form submission handler for editing role
const onEditRoleSubmit = (data: { role: UserRole }) => {
if (selectedUser) {
updateRoleMutation.mutate({ userId: selectedUser.id, role: data.role });
}
};
// Handle role editing
const handleEditRole = (user: User) => {
setSelectedUser(user);
editRoleForm.reset({ role: user.role as UserRole });
setIsEditRoleDialogOpen(true);
};
// Handle user deletion
const handleDeleteUser = (user: User) => {
setSelectedUser(user);
setIsDeleteDialogOpen(true);
};
// Confirm deletion
const confirmDeleteUser = () => {
if (selectedUser) {
deleteUserMutation.mutate(selectedUser.id);
}
};
// Get role badge
const getRoleBadge = (role: string) => {
switch (role) {
case "admin":
return (
<Badge variant="outline" className="bg-destructive/10 text-destructive border-destructive/20">
Admin
</Badge>
);
case "manager":
return (
<Badge variant="outline" className="bg-warning/10 text-warning border-warning/20">
Manager
</Badge>
);
case "user":
return (
<Badge variant="outline" className="bg-primary/10 text-primary border-primary/20">
User
</Badge>
);
case "readonly":
return (
<Badge variant="outline" className="bg-muted/10 text-muted-foreground">
Read-only
</Badge>
);
default:
return (
<Badge variant="outline">
{role}
</Badge>
);
}
};
// Calculate pagination
const startIndex = (currentPage - 1) * pageSize;
const endIndex = startIndex + pageSize;
const paginatedUsers = users.slice(startIndex, endIndex);
const totalPages = Math.ceil(users.length / pageSize);
// Check if current user is admin
if (user?.role !== "admin") {
return (
<MainLayout
title="Users & Roles"
description="Manage users and their access permissions."
>
<Card>
<CardContent className="pt-6 flex flex-col items-center justify-center h-64">
<Lock className="h-12 w-12 text-muted-foreground mb-4" />
<h3 className="text-lg font-medium mb-2">Access Restricted</h3>
<p className="text-center text-muted-foreground">
You don't have permission to access this page. Only administrators can manage users and roles.
</p>
</CardContent>
</Card>
</MainLayout>
);
}
return (
<MainLayout
title="Users & Roles"
description="Manage users and their access permissions."
>
<div className="mb-6 flex justify-between items-center">
<div className="space-y-1">
<h2 className="text-xl font-semibold">User Management</h2>
<p className="text-sm text-muted-foreground">
Add, edit, and manage user accounts and their permissions.
</p>
</div>
<Button onClick={() => setIsAddUserDialogOpen(true)}>
<UserPlus className="mr-2 h-4 w-4" />
Add User
</Button>
</div>
{/* Role descriptions card */}
<Card className="mb-6">
<CardHeader>
<CardTitle>Role Permissions</CardTitle>
<CardDescription>
Understanding the different access levels in DynamiDNS
</CardDescription>
</CardHeader>
<CardContent>
<div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-4 gap-4">
<div className="border rounded-lg p-4">
<div className="flex items-center mb-2">
<Shield className="mr-2 h-5 w-5 text-destructive" />
<h3 className="font-medium">Administrator</h3>
</div>
<p className="text-sm text-muted-foreground">
Full access to all features, including user management, organization settings, and system configuration.
</p>
</div>
<div className="border rounded-lg p-4">
<div className="flex items-center mb-2">
<UserCog className="mr-2 h-5 w-5 text-warning" />
<h3 className="font-medium">Manager</h3>
</div>
<p className="text-sm text-muted-foreground">
Can manage domains, DNS records, and API tokens, but cannot modify system settings or manage users.
</p>
</div>
<div className="border rounded-lg p-4">
<div className="flex items-center mb-2">
<UserCog className="mr-2 h-5 w-5 text-primary" />
<h3 className="font-medium">User</h3>
</div>
<p className="text-sm text-muted-foreground">
Can view domains and manage DNS records, but cannot add domains or manage API tokens.
</p>
</div>
<div className="border rounded-lg p-4">
<div className="flex items-center mb-2">
<UserCog className="mr-2 h-5 w-5 text-muted-foreground" />
<h3 className="font-medium">Read-only</h3>
</div>
<p className="text-sm text-muted-foreground">
Can only view domains and DNS records without making any changes.
</p>
</div>
</div>
</CardContent>
</Card>
{/* Users Table */}
<Card>
<CardHeader>
<CardTitle>Users</CardTitle>
<CardDescription>
Manage user accounts and their roles
</CardDescription>
</CardHeader>
<CardContent>
{isLoading ? (
<div className="flex justify-center items-center py-8">
<Loader2 className="h-8 w-8 animate-spin text-primary" />
</div>
) : users.length === 0 ? (
<div className="text-center py-8">
<div className="mx-auto flex h-12 w-12 items-center justify-center rounded-full bg-primary/10">
<UserCog className="h-6 w-6 text-primary" />
</div>
<h3 className="mt-4 text-lg font-medium">No users found</h3>
<p className="mt-2 text-sm text-muted-foreground">
Get started by adding your first user.
</p>
<div className="mt-6">
<Button onClick={() => setIsAddUserDialogOpen(true)}>
Add User
</Button>
</div>
</div>
) : (
<>
<div className="overflow-x-auto">
<Table>
<TableHeader>
<TableRow>
<TableHead>Username</TableHead>
<TableHead>Email</TableHead>
<TableHead>Name</TableHead>
<TableHead>Role</TableHead>
<TableHead>Organization</TableHead>
<TableHead>Created</TableHead>
<TableHead className="text-right">Actions</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{paginatedUsers.map((user) => (
<TableRow key={user.id}>
<TableCell className="font-medium">{user.username}</TableCell>
<TableCell>{user.email}</TableCell>
<TableCell>{user.fullName || "-"}</TableCell>
<TableCell>{getRoleBadge(user.role)}</TableCell>
<TableCell>
{user.organizationId ?
organizations.find(org => org.id === user.organizationId)?.name ||
`Org ID: ${user.organizationId}` :
"-"}
</TableCell>
<TableCell>
{formatDistanceToNow(new Date(user.createdAt), { addSuffix: true })}
</TableCell>
<TableCell className="text-right">
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button variant="ghost" size="icon">
<MoreVertical className="h-4 w-4" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
<DropdownMenuItem
onClick={() => handleEditRole(user)}
>
Change Role
</DropdownMenuItem>
<DropdownMenuItem
onClick={() => handleDeleteUser(user)}
className="text-destructive focus:text-destructive"
disabled={user.id === user.id} // Can't delete yourself
>
Delete
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</TableCell>
</TableRow>
))}
</TableBody>
</Table>
</div>
{users.length > pageSize && (
<div className="mt-4">
<Pagination
currentPage={currentPage}
totalPages={totalPages}
onPageChange={setCurrentPage}
itemLabel="users"
totalItems={users.length}
itemsPerPage={pageSize}
/>
</div>
)}
</>
)}
</CardContent>
</Card>
{/* Add User Dialog */}
<Dialog open={isAddUserDialogOpen} onOpenChange={setIsAddUserDialogOpen}>
<DialogContent>
<DialogHeader>
<DialogTitle>Add User</DialogTitle>
<DialogDescription>
Create a new user account with specified permissions.
</DialogDescription>
</DialogHeader>
<Form {...addUserForm}>
<form onSubmit={addUserForm.handleSubmit(onAddUserSubmit)} className="space-y-4">
<FormField
control={addUserForm.control}
name="username"
render={({ field }) => (
<FormItem>
<FormLabel>Username</FormLabel>
<FormControl>
<Input placeholder="Enter username" {...field} />
</FormControl>
<FormMessage />
</FormItem>
)}
/>
<FormField
control={addUserForm.control}
name="email"
render={({ field }) => (
<FormItem>
<FormLabel>Email</FormLabel>
<FormControl>
<Input placeholder="Enter email" type="email" {...field} />
</FormControl>
<FormMessage />
</FormItem>
)}
/>
<FormField
control={addUserForm.control}
name="password"
render={({ field }) => (
<FormItem>
<FormLabel>Password</FormLabel>
<FormControl>
<Input placeholder="Enter password" type="password" {...field} />
</FormControl>
<FormMessage />
</FormItem>
)}
/>
<FormField
control={addUserForm.control}
name="fullName"
render={({ field }) => (
<FormItem>
<FormLabel>Full Name (Optional)</FormLabel>
<FormControl>
<Input placeholder="Enter full name" {...field} />
</FormControl>
<FormMessage />
</FormItem>
)}
/>
<FormField
control={addUserForm.control}
name="role"
render={({ field }) => (
<FormItem>
<FormLabel>Role</FormLabel>
<Select
onValueChange={field.onChange}
defaultValue={field.value}
>
<FormControl>
<SelectTrigger>
<SelectValue placeholder="Select role" />
</SelectTrigger>
</FormControl>
<SelectContent>
{systemRoles.map(role => (
<SelectItem key={role} value={role}>
{role.charAt(0).toUpperCase() + role.slice(1)}
</SelectItem>
))}
</SelectContent>
</Select>
<FormMessage />
</FormItem>
)}
/>
<FormField
control={addUserForm.control}
name="organizationId"
render={({ field }) => (
<FormItem>
<FormLabel>Organization</FormLabel>
<Select
onValueChange={(value) => field.onChange(parseInt(value))}
defaultValue={field.value?.toString()}
>
<FormControl>
<SelectTrigger>
<SelectValue placeholder="Select organization" />
</SelectTrigger>
</FormControl>
<SelectContent>
{organizations.map((org) => (
<SelectItem
key={org.id}
value={org.id.toString()}
>
{org.name}
</SelectItem>
))}
</SelectContent>
</Select>
<FormMessage />
</FormItem>
)}
/>
<DialogFooter>
<Button
type="submit"
disabled={addUserMutation.isPending}
>
{addUserMutation.isPending ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
Adding...
</>
) : (
"Add User"
)}
</Button>
</DialogFooter>
</form>
</Form>
</DialogContent>
</Dialog>
{/* Edit Role Dialog */}
<Dialog open={isEditRoleDialogOpen} onOpenChange={setIsEditRoleDialogOpen}>
<DialogContent>
<DialogHeader>
<DialogTitle>Change User Role</DialogTitle>
<DialogDescription>
Update the role for user {selectedUser?.username}.
</DialogDescription>
</DialogHeader>
<Form {...editRoleForm}>
<form onSubmit={editRoleForm.handleSubmit(onEditRoleSubmit)} className="space-y-4">
<FormField
control={editRoleForm.control}
name="role"
render={({ field }) => (
<FormItem>
<FormLabel>New Role</FormLabel>
<Select
onValueChange={field.onChange}
defaultValue={field.value}
>
<FormControl>
<SelectTrigger>
<SelectValue placeholder="Select role" />
</SelectTrigger>
</FormControl>
<SelectContent>
{systemRoles.map(role => (
<SelectItem key={role} value={role}>
{role.charAt(0).toUpperCase() + role.slice(1)}
</SelectItem>
))}
</SelectContent>
</Select>
<FormMessage />
</FormItem>
)}
/>
<DialogFooter>
<Button
type="submit"
disabled={updateRoleMutation.isPending}
>
{updateRoleMutation.isPending ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
Updating...
</>
) : (
"Update Role"
)}
</Button>
</DialogFooter>
</form>
</Form>
</DialogContent>
</Dialog>
{/* Delete Confirmation Dialog */}
<AlertDialog open={isDeleteDialogOpen} onOpenChange={setIsDeleteDialogOpen}>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>Delete User</AlertDialogTitle>
<AlertDialogDescription>
This will permanently delete the user <strong>{selectedUser?.username}</strong>.
All data associated with this user will be lost. This action cannot be undone.
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel>Cancel</AlertDialogCancel>
<AlertDialogAction
onClick={confirmDeleteUser}
className="bg-destructive text-destructive-foreground hover:bg-destructive/90"
disabled={deleteUserMutation.isPending}
>
{deleteUserMutation.isPending ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
Deleting...
</>
) : (
"Delete"
)}
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
</MainLayout>
);
}