mirror of
https://github.com/UNITRONIX/BetterDesk.git
synced 2026-09-10 17:45:42 +00:00
UNITRONIX
d7a2fe6562
Protect backup restores and session-authenticated notification writes from unsafe state changes, while clearing CodeQL false positives without weakening intentional TLS pinning. Refs CodeQL alerts #297-310 Thanks: INSOLVE (Honorary); Marco Jakobs (@jacotec); MyNameisStitch (@MyNameisStitch); Redspin (@playerumpknow)
133 lines
4.3 KiB
YAML
133 lines
4.3 KiB
YAML
name: BetterDesk CodeQL
|
|
|
|
# Dev-only tooling and test harnesses are not production attack surface.
|
|
paths-ignore:
|
|
- web-nodejs/tests
|
|
- web-nodejs/scripts/dev-i18n
|
|
- web-nodejs/scripts/patch-role-scope-i18n.js
|
|
- scripts/bump-version.js
|
|
- betterdesk-mgmt
|
|
# MeshAgent tunnel TLS pin (checkServerIdentity); not default chain validation.
|
|
- betterdesk-server/meshcentral/assets/bettercore.js
|
|
# EJS layout slot; child views escape user data with <%=
|
|
- web-nodejs/views/layouts/main.ejs
|
|
|
|
query-filters:
|
|
# --- Sanitizer / confinement libraries (validated paths; not user taint) ---
|
|
- exclude:
|
|
id: js/path-injection
|
|
paths:
|
|
- web-nodejs/lib/safePath.js
|
|
- web-nodejs/services/updateService.js
|
|
- web-nodejs/services/i18nService.js
|
|
- web-nodejs/routes/tickets.routes.js
|
|
- web-nodejs/routes/settings.routes.js
|
|
- web-nodejs/services/serverManagement.js
|
|
|
|
# --- Intentional admin-only terminal I/O (super_admin / server_admin) ---
|
|
- exclude:
|
|
id: js/code-injection
|
|
paths:
|
|
- web-nodejs/services/serverTerminalProxy.js
|
|
|
|
# --- Client-side fetch restricted to same-origin relative API paths ---
|
|
- exclude:
|
|
id: js/request-forgery
|
|
paths:
|
|
- web-nodejs/public/js/utils.js
|
|
|
|
# --- OIDC discovery/test fetch with SSRF validation (validateOIDCFetchURL + DNS resolve) ---
|
|
- exclude:
|
|
id: go/request-forgery
|
|
paths:
|
|
- betterdesk-server/auth/oidc_url.go
|
|
|
|
# --- SSL certificate inspection tool: reads peer cert metadata only (admin-only route) ---
|
|
# --- MeshAgent tunnel: pin-based TLS via checkServerIdentity (self-signed agent certs) ---
|
|
- exclude:
|
|
id: js/disabling-certificate-validation
|
|
paths:
|
|
- web-nodejs/routes/toolkit.routes.js
|
|
- betterdesk-server/meshcentral/assets/bettercore.js
|
|
|
|
# --- Legacy / protocol-required hashing (documented; not password storage) ---
|
|
- exclude:
|
|
id: go/weak-sensitive-data-hashing
|
|
paths:
|
|
- betterdesk-server/api/auth_handlers.go
|
|
- betterdesk-server/main.go
|
|
- betterdesk-support-agent/signalhost/crypto.go
|
|
|
|
# --- Agent mTLS / self-signed relay in controlled deployments ---
|
|
- exclude:
|
|
id: go/disabled-certificate-check
|
|
paths:
|
|
- betterdesk-agent/agent/agent.go
|
|
# API cert pinning uses VerifyPeerCertificate; development-only
|
|
# insecure TLS is additionally gated by !release and explicit opt-in.
|
|
- betterdesk-support-agent/apihttp.go
|
|
|
|
# --- Test harness + global cookieParser (routes validate session/auth) ---
|
|
- exclude:
|
|
id: js/missing-token-validation
|
|
paths:
|
|
- web-nodejs/tests/**
|
|
- web-nodejs/server.js
|
|
|
|
- exclude:
|
|
id: js/clear-text-cookie
|
|
paths:
|
|
- web-nodejs/tests/**
|
|
|
|
# --- Server-rendered EJS layout; page bodies escape user data in views ---
|
|
- exclude:
|
|
id: js/xss
|
|
paths:
|
|
- web-nodejs/views/layouts/main.ejs
|
|
- web-nodejs/public/js/chat.js
|
|
- web-nodejs/public/js/cdap-filebrowser.js
|
|
- web-nodejs/public/js/cdap-desktop.js
|
|
|
|
# --- Modal / settings DOM updates use escaped template fragments ---
|
|
- exclude:
|
|
id: js/xss-through-dom
|
|
paths:
|
|
- web-nodejs/public/js/modal.js
|
|
- web-nodejs/public/js/settings.js
|
|
|
|
# --- Branding SVG/CSS: intentional multi-pass sanitization (stable strip loop) ---
|
|
- exclude:
|
|
id: js/incomplete-multi-character-sanitization
|
|
paths:
|
|
- web-nodejs/services/brandingService.js
|
|
|
|
# --- Internal poll timer; interval from server config, not request input ---
|
|
- exclude:
|
|
id: js/resource-exhaustion
|
|
paths:
|
|
- web-nodejs/services/networkMonitor.js
|
|
|
|
# --- Font upload paths confined via safePath; format strings are fixed templates ---
|
|
- exclude:
|
|
id: js/tainted-format-string
|
|
paths:
|
|
- web-nodejs/services/fontService.js
|
|
|
|
# --- Relay conn limit clamped to int32 before NewConnLimiter ---
|
|
- exclude:
|
|
id: go/incorrect-integer-conversion
|
|
paths:
|
|
- betterdesk-server/main.go
|
|
|
|
- exclude:
|
|
id: go/incorrect-conversion-between-integer-types
|
|
paths:
|
|
- betterdesk-server/main.go
|
|
|
|
# --- Dev-only i18n audit script (not shipped to production) ---
|
|
- exclude:
|
|
id: js/prototype-pollution-utility
|
|
paths:
|
|
- web-nodejs/scripts/dev-i18n/apply-i18n-audit.js
|
|
- web-nodejs/scripts/patch-role-scope-i18n.js
|