From 7b30765efee3cfc85dd757f43d4242336fe36b97 Mon Sep 17 00:00:00 2001 From: UNITRONIX <36471318+UNITRONIX@users.noreply.github.com> Date: Wed, 29 Jul 2026 19:05:46 +0200 Subject: [PATCH] fix(devices): kebab Unban no longer calls Ban API (Fixes #323) --- CHANGELOG.md | 3 +++ web-nodejs/public/js/devices.js | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 694fb814..74968e11 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,9 @@ ### Changed - _(none yet)_ +### Fixed +- **Devices kebab Unban called Ban (#323):** kebab menu passed boolean `device.banned` while the handler only treated the string `'true'` as banned, so Unban opened the Ban modal and POSTed `/ban`. Both boolean and dataset string are accepted now. Ships via panel update. + --- ## [3.4.2] — 2026-07-28 diff --git a/web-nodejs/public/js/devices.js b/web-nodejs/public/js/devices.js index 48c47556..2dfae19c 100644 --- a/web-nodejs/public/js/devices.js +++ b/web-nodejs/public/js/devices.js @@ -1154,7 +1154,8 @@ break; case 'toggle-ban': - await toggleBan(deviceId, data.banned === 'true'); + // Kebab passes device object (boolean); context menu passes dataset (string) + await toggleBan(deviceId, data.banned === true || data.banned === 'true'); break; case 'change-id':