gsadmin/BetterDesk
1
0
Fork 0
mirror of https://github.com/UNITRONIX/BetterDesk.git synced 2026-09-10 17:45:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(rdclient): encode protobuf string enums via fromObject (keyboard control keys)

Browse Source 
serializeMessage used Message.create() which does NOT convert string enum names to numeric values. A KeyEvent with controlKey:'Backspace' (or Space/Tab/Return/arrows) and mode:'Legacy' was encoded as control_key=0 (Unknown), so every non-character key was silently dropped by the peer while numeric chr letter keys worked. Switched to Message.fromObject() which converts enum name strings to their numeric values and preserves Uint8Array byte fields (clipboard content, file blocks, password, public keys). Verified round-trip: Backspace->2, Space->30, mode Legacy->0, bytes/login/file-block/mouse intact.

This commit was made possible thanks to Insolve.
This commit is contained in:
UNITRONIX
2026-05-31 06:04:33 +02:00
parent 934e305040
commit 141171990a
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web-nodejs/public/js/rdclient/protocol.js
+8 -1
View File
@@ -107,9 +107,16 @@ class RDProtocol {
/**
* Serialize a Message to raw protobuf bytes (NO frame header)
* Use this when encryption will be applied before framing
*
* Uses fromObject() (not create()) so that string enum names — e.g. a
* KeyEvent's `controlKey: 'Backspace'` or `mode: 'Legacy'` — are converted
* to their numeric enum values. create() leaves them as strings, which the
* encoder writes as 0 (Unknown), breaking every non-character key. Byte
* fields supplied as Uint8Array (clipboard content, file blocks, keys) are
* preserved as-is by fromObject().
*/
serializeMessage(msgObj) {
const msg = this.types.Message.create(msgObj);
const msg = this.types.Message.fromObject(msgObj);
return this.types.Message.encode(msg).finish();
}