mirror of
https://github.com/okieselbach/AutopilotMonitor.git
synced 2026-10-25 13:10:13 +00:00
Oliver Kieselbach
ec0d8ad735
- DiagnosticsBlobStreamer disposes the download result on every exit path (it was disposed only on the 413 branch), measures open and transfer separately and fires DiagnosticsDownloadProxied after the copy with Completed=true/false. - UserDelegationKeyCache: one user delegation key per process (24 h, re-mint under a lock with 2 h margin or when a SAS would outlive it) instead of one storage round-trip per download or upload SAS. - KevDataService is resolved as one singleton over the typed-client handler pipeline; the cache warmer used to hydrate a throwaway transient instance while the correlation service held a cold one. - Admin and tenant configuration services single-flight concurrent cache misses (Lazy<Task> per key); the MemoryCache and the in-place projection semantics stay untouched. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
84 lines
3.8 KiB
C#
84 lines
3.8 KiB
C#
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using AutopilotMonitor.Functions.Services;
|
|
using AutopilotMonitor.Shared.DataAccess;
|
|
using AutopilotMonitor.Shared.Models;
|
|
using AutopilotMonitor.Shared.Models.Config;
|
|
using Microsoft.Extensions.Caching.Memory;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Moq;
|
|
using Xunit;
|
|
|
|
namespace AutopilotMonitor.Functions.Tests;
|
|
|
|
/// <summary>
|
|
/// Concurrent cache misses on the two configuration services share one repository read
|
|
/// (audit 2026-09-05 F12). The MemoryCache stays: the hit path and the in-place projection
|
|
/// semantics are untouched, only the miss path is single-flighted.
|
|
/// </summary>
|
|
public class ConfigurationServiceSingleFlightTests
|
|
{
|
|
[Fact]
|
|
public async Task Admin_config_concurrent_misses_issue_one_repository_read()
|
|
{
|
|
var gate = new TaskCompletionSource<AdminConfiguration?>();
|
|
var repo = new Mock<IConfigRepository>();
|
|
repo.Setup(r => r.GetAdminConfigurationAsync()).Returns(gate.Task);
|
|
var sut = new AdminConfigurationService(repo.Object, NullLogger<AdminConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()));
|
|
|
|
var calls = Enumerable.Range(0, 10).Select(_ => sut.GetConfigurationAsync()).ToArray();
|
|
gate.SetResult(AdminConfiguration.CreateDefault());
|
|
var results = await Task.WhenAll(calls);
|
|
|
|
repo.Verify(r => r.GetAdminConfigurationAsync(), Times.Once);
|
|
Assert.All(results, r => Assert.Same(results[0], r));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Admin_config_after_completion_the_next_miss_reads_again()
|
|
{
|
|
var repo = new Mock<IConfigRepository>();
|
|
repo.Setup(r => r.GetAdminConfigurationAsync()).ReturnsAsync(AdminConfiguration.CreateDefault());
|
|
var sut = new AdminConfigurationService(repo.Object, NullLogger<AdminConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()));
|
|
|
|
await sut.GetConfigurationAsync();
|
|
sut.InvalidateCache();
|
|
await sut.GetConfigurationAsync();
|
|
|
|
repo.Verify(r => r.GetAdminConfigurationAsync(), Times.Exactly(2));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Tenant_config_concurrent_misses_for_one_tenant_issue_one_repository_read()
|
|
{
|
|
const string tenantId = "11111111-1111-1111-1111-111111111111";
|
|
var gate = new TaskCompletionSource<TenantConfiguration?>();
|
|
var repo = new Mock<IConfigRepository>();
|
|
repo.Setup(r => r.GetTenantConfigurationAsync(tenantId)).Returns(gate.Task);
|
|
var sut = new TenantConfigurationService(repo.Object, NullLogger<TenantConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()));
|
|
|
|
var calls = Enumerable.Range(0, 10).Select(_ => sut.GetConfigurationAsync(tenantId)).ToArray();
|
|
gate.SetResult(TenantConfiguration.CreateDefault(tenantId));
|
|
var results = await Task.WhenAll(calls);
|
|
|
|
repo.Verify(r => r.GetTenantConfigurationAsync(tenantId), Times.Once);
|
|
Assert.All(results, r => Assert.Same(results[0], r));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Tenant_config_different_tenants_do_not_share_a_flight()
|
|
{
|
|
const string a = "11111111-1111-1111-1111-111111111111";
|
|
const string b = "22222222-2222-2222-2222-222222222222";
|
|
var repo = new Mock<IConfigRepository>();
|
|
repo.Setup(r => r.GetTenantConfigurationAsync(It.IsAny<string>()))
|
|
.Returns<string>(id => Task.FromResult<TenantConfiguration?>(TenantConfiguration.CreateDefault(id)));
|
|
var sut = new TenantConfigurationService(repo.Object, NullLogger<TenantConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()));
|
|
|
|
await Task.WhenAll(sut.GetConfigurationAsync(a), sut.GetConfigurationAsync(b));
|
|
|
|
repo.Verify(r => r.GetTenantConfigurationAsync(a), Times.Once);
|
|
repo.Verify(r => r.GetTenantConfigurationAsync(b), Times.Once);
|
|
}
|
|
}
|