mirror of
https://github.com/okieselbach/AutopilotMonitor.git
synced 2026-10-22 19:55:35 +00:00
Oliver Kieselbach
98d87a8579
The root .editorconfig raises IDE0051, IDE0052 and IDE0060 (non-public methods) to warning, and Directory.Build.props sets EnforceCodeStyleInBuild, so the warning freeze turns them into build errors in every project, the net48 agent included. Cleanup to start at zero, each finding checked for leftover vs. missing behaviour (none was a feature that silently never ran): - 38 injected dependencies nobody read: loggers, configuration, and services whose last read had moved to a live replacement (the IME reseed writes through the rule repository, the offboarding poison OpsEvent comes from the handler, the vulnerability gate sits in the correlate handler). Removed with their constructor parameters and the argument at every construction site. - unused private members: SelfUpdater.IsNewerVersion, a GatherRuleExecutor wrapper, test constants and an unused test overload. RjPhaseCompletedFirstDeployment now replaces the two literal 110s it names. - unused parameters removed together with their arguments; test fakes bound as method groups use discards. - the commented-out backend-URL connectivity check and its plumbing are gone; the reason the backend stays out remains as a comment. - DiagnosticsPackageService names the blob in its upload-failure warnings, as its doc already said. - stale docs fixed on the way: OnboardedAt no longer claims a maintenance backfill (shared manifest and wire types regenerated), the vulnerability functions' policy comments match the catalog, a misplaced summary moved to its method. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
16 lines
917 B
XML
16 lines
917 B
XML
<Project>
|
|
<!-- Warning freeze (2026-08-13, backlog cleared to zero): every .NET build in this repo
|
|
must stay warning-free. Compiler, MSBuild and NuGet restore warnings are all fatal.
|
|
Exception: NuGet audit advisories (NU1901-NU1904) stay warnings — a CVE published
|
|
against an already-referenced package must not block an unrelated hotfix deploy;
|
|
advisories are handled by bumping the package, not by failing the build. -->
|
|
<PropertyGroup>
|
|
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
|
|
<MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
|
|
<WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
|
|
<!-- Run the IDE code-style analyzers in the build too, so the rules .editorconfig raises
|
|
to warning fail it like any compiler warning. -->
|
|
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
|
|
</PropertyGroup>
|
|
</Project>
|